Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich

Re: Review Request 124397: Add today button to calendar

git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review83118 --- On Juli 28, 2015, 8:32 nachm., Bernhard Friedreich wrote

Re: Review Request 124397: Add today button to calendar

Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing

Re: Review Request 124397: Add today button to calendar

-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

On Juli 19, 2015, 4:51 nachm., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think

Re: Review Request 122488: Improved calendar navigation

On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote: Bump. Can we get this in for 5.4? Marco Martin wrote: ugh, i almost forgot about this... yes please Just tested the patch. Working beautifully for me from a user perspective :) - Bernhard

Review Request 124397: Add today button to calendar

is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On Juli 19, 2015, 2:25 nachm., Bernhard Friedreich wrote

Review Request 124394: Timer: trying to fix missing translation in config file (not working)

i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:04 nachm

Re: Review Request 124397: Add today button to calendar

://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124397: Add today button to calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82663 --- On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote

Re: Review Request 124397: Add today button to calendar

://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8f09567eae260a1241e65e2ec2a9e9ba28bbf0ad by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

://git.reviewboard.kde.org/r/123420/#review79243 --- On April 18, 2015, 6:14 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

On April 20, 2015, 7:59 vorm., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended Bernhard Friedreich wrote: the whole resizing mechanism of the plasmoid will need to be rewritten

Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

--- On April 18, 2015, 6:14 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- On April 17, 2015, 8:02 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332

Re: Review Request 123332: Timer: Added config ui for notification and title text

-c8bd-4cbb-b1d1-2757b3016fd1__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123332: Timer: Added config ui for notification and title text

-2757b3016fd1__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123332: Timer: Added config ui for notification and title text

the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78905 --- On April 13, 2015, 7:33 nachm., Bernhard Friedreich wrote

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using

Re: Review Request 123332: Timer: Added config ui for notification and title text

., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 11, 2015, 2:16 nachm

Review Request 123332: Timer: Added config ui for notification and title text

(showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

25) https://git.reviewboard.kde.org/r/123274/#comment53803 removed already locally - Bernhard Friedreich On April 7, 2015, 3:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 57aeac6278d8085b481850d62eb2f2ad8109a316 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains

Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

--- Tested using plasmashell directly and using plasmoidviewer Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 1:11 nachm., Bernhard Friedreich wrote

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Bernhard Friedreich wrote: Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

. So I'm clear, what do you see the use case of this being? Bernhard Friedreich wrote: Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config

Re: Plasma 5 is awesome...and some help required with build instructions

, Bernhard Friedreich 2015-03-28 19:23 GMT+01:00 Siddhartha sh.siddhar...@gmail.com: Hi David, Thanks a lot for your comments! On 28 March 2015 at 20:23, David Edmundson da...@davidedmundson.co.uk wrote: I don't think we should tell people to download's David Faure's kdesrc-buildrc file

Re: Plasma 5 is awesome...and some help required with build instructions

I finally found the problem - the instructions on the wiki were updated since my setup and I was lacking some lib64 directories in the runPlasma5.sh script.. Thanks for the documentation and your help! :) 2015-03-31 20:44 GMT+02:00 Bernhard Friedreich fries...@gmail.com: To me

Re: Plasma 5 is awesome...and some help required with build instructions

, maybe it is because I changed paths from /opt to /products?) (yeah I know decreasing selinux security isn't a solution) 2.) I can start the session from sddm but plasmashell and krunner crash instantly.. Any ideas? (attached the output/bt I got from gdb) Thanks :) Bye, Bernhard Friedreich 2015

Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/#review78176 --- On März 29, 2015, 2:20 nachm., Bernhard Friedreich wrote

Review Request 123173: Timer Plasmoid: Add notification on timer completion

? (Both have to be true) false true How can I send a notification from qml (without c++)? Am I on the right track? Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Commit 1: Fixed codingstyle Commit 2: Fixed warning Unable to assign int

Re: Review Request 123161: Add copy and paste support for calculator widget

. It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10) Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich ___ Plasma-devel mailing

Re: Review Request 123161: Add copy and paste support for calculator widget

., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ --- (Updated März 27, 2015, 11:21 nachm

Re: Review Request 123161: Add copy and paste support for calculator widget

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David Edmundson on behalf of Bernhard Friedreich to branch master. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons

Review Request 123161: Add copy and paste support for calculator widget

entered text with the pasted content (this could be worked around - should it append?) *) Pasting = 5 + 3 passes through validation - no idea why yet - this should be possible I guess? Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard