D28172: [applets/digital-clock] Fix date sizing in vertical panel

2020-03-23 Thread Christian Muehlhaeuser
muesli added a comment. While it's not completely consistent yet, it still's an improvement that reverts the recent regression. As such, I'm tempted to say LGTM. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28172 To: ngraham, #vdg, #plasma Cc: muesli, pl

D28172: [applets/digital-clock] Fix date sizing in vertical panel

2020-03-21 Thread Christian Muehlhaeuser
muesli added a comment. Your patch indeed makes the date behave like in previous releases again! However I noticed it's still not quite consistent in its behavior: when I start plasmashell freshly, the date is a lot wider than after resizing it to roughly the same width. I've added a new att

D28083: Use methods in KF5-activities to switch to previous/next activity

2020-03-17 Thread Christian Muehlhaeuser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:805e70bb6e75: Use methods in KF5-activities to switch to previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28083?

D28083: Use methods in KF5-activities to switch to previous/next activity

2020-03-16 Thread Christian Muehlhaeuser
muesli created this revision. muesli added reviewers: ngraham, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY Since the release of KDE Frameworks 5.68.0 we can now use the methods exposed in KActivities:

D26861: [Applet/Task Manager] Move audio indicator to the corner

2020-01-23 Thread Christian
Fuchs added a comment. Looks good to me, thank you very much for the work :-) Sidesnotes that I mentioned in the group, just so they are documented here: - I think for a clickable action it can become too small, so it takes too much aiming. However, it doesn't get in the way, and peo

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d6b5376eaa7: Add global shortcuts for switching to the previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?v

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser
muesli added a comment. Alright, I think this looks sane again. @ngraham Mind if I land this in its current state? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-13 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 73412. muesli added a comment. Hopefully fix phabricator getting out of sync with the changeset. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=73354&id=73412 BRANCH shortcut-prevnext-activity (branc

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser
muesli added a comment. Oops, I'm not sure what I've did here was what I intended: I rebased master (>800 commits since my original changeset) into my feature branch because I otherwise couldn't build/test my changes anymore, but obviously I didn't touch/change > 600 files. Is this how pha

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-12 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 73354. muesli added a comment. - Remove default key-sequence for "Previous/Next Activity" shortcut REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=61521&id=73354 BRANCH shortcut-prevnext-activity (bra

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-11 Thread Christian Muehlhaeuser
muesli added a comment. While waiting for that separate discussion and decision, does anyone mind if I land this _without_ default shortcuts set? At least it enables people to switch to the previous/next activity when they configure a shortcut manually. Currently that's not possible, as

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-27 Thread Christian
Fuchs accepted this revision. Fuchs added a comment. This revision is now accepted and ready to land. Good for me, hopefully the upstream bug will be fixed, too :) REPOSITORY R119 Plasma Desktop BRANCH explanatory-text (branched from master) REVISION DETAIL https://phabricator.kde.org/

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2019-12-14 Thread Christian
Fuchs added a comment. Then as soon as you actually run the app there will be a duplicate, the launcher and the entry in the task manager. If I understood correctly, pinned tabs in browsers avoid that. You have a small, icon only variant when not open and a full variant (at the same position

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2019-12-14 Thread Christian
Fuchs added a comment. If I remember correctly, the main argument against the launcher was that pinned apps should be pinned and thus not change their location / order, but exactly that would happen with a launcher once you open the app (that, or a duplicate entry in the window list) REPOSI

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

2019-12-11 Thread Christian
Fuchs added a comment. Sidenote, maybe an upstream bug / wish can be added about > Oh darn, so it does. I checked the docs and tried setting SH_ScrollBar_MiddleClickAbsolutePosition explicitly, but it looks like there's actually no option to do page-by-page navigation for clicking in

D22382: Add global shortcuts for switching to the previous/next activity

2019-10-22 Thread Christian Muehlhaeuser
muesli added a comment. Would love to finish this one up! :) Any suggestions how to move forward? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The

D22381: Add previous-/nextActivity methods

2019-10-03 Thread Christian Muehlhaeuser
This revision was automatically updated to reflect the committed changes. muesli marked an inline comment as done. Closed by commit R161:e3a7cb2f1b18: Add previous-/nextActivity methods (authored by muesli). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabrica

D22381: Add previous-/nextActivity methods

2019-10-03 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 67276. muesli added a comment. Fix typo in 'nameBasedOrdering' REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61590&id=67276 BRANCH prevnext-activity (branched from master) REVISION DETAIL

D22382: Add global shortcuts for switching to the previous/next activity

2019-10-03 Thread Christian Muehlhaeuser
muesli added a comment. In D22382#541626 , @ivan wrote: > I'm not thrilled about having default shortcuts set. We have the shortcuts space quite polluted as it is. I'm happy to remove the defaults (even though I consider them fairly cons

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 61590. muesli added a comment. Move nameBaseOrdering to an anonymous namespace and mark it as inline. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61589&id=61590 BRANCH prevnext-activity (

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 61589. muesli added a comment. Addressed @ivan's change requests Summary: - Renamed sorting method to nameBaseOrdering - Remove activity from sorted cache without re-sorting the entire list - Switch to prev/next running activity, skipping other

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 61588. muesli added a comment. Use a QVector instead of a QList to store sorted activities. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22381?vs=61579&id=61588 BRANCH prevnext-activity (branched f

D22396: Fix typo in CREATE_GETTER_AND_SETTER

2019-07-11 Thread Christian Muehlhaeuser
This revision was automatically updated to reflect the committed changes. Closed by commit R161:d15446776e23: Fix typo in CREATE_GETTER_AND_SETTER (authored by muesli). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22396?vs=61581&id=61586 R

D22396: Fix typo in CREATE_GETTER_AND_SETTER

2019-07-11 Thread Christian Muehlhaeuser
muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY Fix typo when undefining CREATE_GETTER_AND_SETTER. REPOSITORY R161 KActivity Manager Service BRANCH

D22381: Add previous-/nextActivity methods

2019-07-11 Thread Christian Muehlhaeuser
muesli updated this revision to Diff 61579. muesli added a comment. Keep an alphabetically sorted list of activities Summary: Instead of re-sorting the activity list every time previous-/nextActivity gets called, maintain a sorted list. REPOSITORY R161 KActivity Manager Service CHA

D22381: Add previous-/nextActivity methods

2019-07-10 Thread Christian Muehlhaeuser
muesli added inline comments. INLINE COMMENTS > ivan wrote in Activities.cpp:218 > I don't like the fact that it constantly resorts the activities. > > The second problem is that ListActivities returns a list in one order, and > this traverses activities in another order. If this will work by n

D22382: Add global shortcuts for switching to the previous/next activity

2019-07-10 Thread Christian Muehlhaeuser
muesli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY We currently have a mouse-wheel action to switch to the previous/next desktop, but it wasn't possible to assign a global keyboard sh

D22381: Add previous-/nextActivity methods

2019-07-10 Thread Christian Muehlhaeuser
muesli created this revision. muesli added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. muesli requested review of this revision. REVISION SUMMARY These two methods can be used to switch to the previous/next activity in alphabetical order. They are

D20569: RFC: Use more compact OSD

2019-04-15 Thread Christian
Fuchs added a comment. In D20569#450462 , @broulik wrote: > > No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is

D20569: RFC: Use more compact OSD

2019-04-15 Thread Christian
Fuchs added a comment. I like the first, small but centered variant. But I can see how people might want it differently: most of the time I use my PC for work. I assume if you are watching movies on it, a centered design is more of a bother than a corner one, whilst for work the center o

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Christian
Fuchs added a comment. One minor nitpick: if it is on all virtual desktops there is no text shown, maybe some "is on all virtual desktops" or so would be nice, for consistency. But it might entirely be that it didn't do that before either, at least the code looks like it. Also this would

D19257: [Task Manager] Fix virtual desktops subtext on task tooltip

2019-02-23 Thread Christian
Fuchs added a comment. Yep, that works here, even with groups spanning multiple desktops. Thanks for the quick fix! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19257 To: hein, #plasma Cc: Fuchs, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesli

D16988: [Kickoff] Make the visible search field unfocused by default

2018-11-19 Thread Christian Hempfling
chempfling added a comment. In D16988#362160 , @rooty wrote: > Okay so from what I can tell: > > (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the

D16309: Add accessibility information to desktop icons

2018-10-22 Thread Christian Hempfling
chempfling added a comment. In D16309#347071 , @hein wrote: > I'll land it for you (it needs a manual step, which requires a dev account - which you should eventually apply for if you wind up contributing regularly!). Ok Thanks, I ll tr

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment. Ok, so nothing to do then. Is this merged automatically once per day or something? Or how do i get the patch into master now? I mark the task as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To: chempfling, hein, g

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added a comment. Do i need to do anythin else to get it into master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16309 To: chempfling, hein, gladhorn Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D16309: Add accessibility information to desktop icons

2018-10-19 Thread Christian Hempfling
chempfling added inline comments. INLINE COMMENTS > gladhorn wrote in FolderItemDelegate.qml:45 > Is Canvas what Gnome uses for desktop icons? I'm fine with this, since I > don't have a better suggestion. Canvas is used by Nautilus. The default filemanager. Joanie would prefer the Role „Icon“

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-15 Thread Christian
Fuchs accepted this revision. Fuchs added a comment. if it falls back then all is perfect :) REPOSITORY R120 Plasma Workspace BRANCH broom-style-clear-history-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmu

D14105: Use a broom-style icon for clearing clipboard and notification history

2018-07-15 Thread Christian
Fuchs added a comment. In D14105#292183 , @ngraham wrote: > Thanks! @fuchs and/or @broulik? Can't test it currently, looks fine, just one question: did you test what happens on other icon sets than breeze? If that doesn't work, I'd say

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-06-19 Thread Christian
Fuchs added a comment. In D13593#280112 , @ngraham wrote: > How about in a tooltip? whatever is search- and findable, I guess. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13593 To: ngraham, #plasma, #

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-06-19 Thread Christian
Fuchs added a comment. Maybe add the technical term in brackets though, for those people who search for the technical term and don't find it otherwise? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13593 To: ngraham, #plasma, #vdg Cc: Fuchs, abetts, nicolas

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

2018-05-22 Thread Christian
Fuchs added a comment. In D12969#266503 , @hein wrote: > > In that case I would honestly argument for dropping Task Manager pinning entirely: I've never entirely liked that it complicates the Task Manager toward doing multiple thin

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

2018-05-22 Thread Christian
Fuchs added a comment. Maybe we need to discuss things, especially also with https://phabricator.kde.org/D12463 where I have an interest in, on a broader scale. I agree that both need to exist and have different use cases, personally I think I'd only show the task manager pin in the con

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-05-02 Thread Christian
Fuchs added a comment. In D12462#257021 , @mart wrote: > In D12462#252987 , @Fuchs wrote: > > > In D12462#252982 , @mart wrote: > > > > > I like the idea

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-24 Thread Christian
Fuchs added a comment. In D12462#252982 , @mart wrote: > I like the idea a lot, > tough i am not sure i like the implementation: right now is kindof hortogonal to pinned tasks and gets confusing as it has a partial, but not complete overlap.

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-23 Thread Christian
Fuchs added a comment. On the existing bug: it's related to the TODO, changing that to for (int i = 0; i < d->concatProxyModel->rowCount(); ++i) { const QModelIndex &itIndex = d->concatProxyModel->index(i, 0); // Launchers can't be pinned / unpinned if (itInd

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-23 Thread Christian
Fuchs added a comment. In D12463#252419 , @ngraham wrote: > This is a neat feature, but I worry that it would muddy the difference between the regular task manager and the icons-only task manager. It's not inconceivable that a user wanting to ge

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs added a comment. Also needs https://phabricator.kde.org/D12463 What it does: adds a new menu entry for the non-icon-only task manager which allows to set an application "icon only", so it will always be displayed without label (like a launcher) even if in running state. Both sor

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs created this revision. Fuchs added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY Frontend part for https://phabricator.kde.org/D12462, please check that as

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs created this revision. Fuchs added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY This adds backend support for pinned tasks, which will only show an icon i

D12161: [Kickoff] Support non-square icons

2018-04-12 Thread Christian
Fuchs added a comment. happy fox now happy, says thanks :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12161 To: broulik, #plasma, #vdg, Fuchs, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Christian
Fuchs added a comment. Personal opinions, based on discussions here and on TG - fixed, (default) wallpaper has the advantage of not risking privacy, not munching power and being usable in, at least from login to desktop to lock screen, have a consistent feel for new users. Downside is th

D11356: [Media Controller] Show track length if available even if seeking isn't possible

2018-03-15 Thread Christian
Fuchs accepted this revision. Fuchs added a comment. This revision is now accepted and ready to land. +1, looks great to me. Bit of duplicate control, but given there can be one at most, that seems fine to me. Also progress bar makes sense, since a playing track is progress, so it sho

D11306: Give the "Clear History" button some text

2018-03-14 Thread Christian
Fuchs added a comment. In D11306#225695 , @ngraham wrote: > I agree that consistency is important! For that reason, I would propose adding text everywhere. Buttons without text are inherently ambiguous unless their icons are //perfect// (and eve

D11306: Give the "Clear History" button some text

2018-03-14 Thread Christian
Fuchs added a comment. In D11306#225691 , @ngraham wrote: > How about just "Clear" for the text? That should be short enough even in German, no? The word "history" is pretty redundant anyway. Actually the oppposite, if you only do "clear"

D11306: Give the "Clear History" button some text

2018-03-14 Thread Christian
Fuchs added a subscriber: broulik. Fuchs added a comment. In D11306#225671 , @broulik wrote: > Do whatever you want with this button. Okay, recommendation: due to all plasma buttons that have an icon having it on the left (see e.g. F57539

D11306: Give the "Clear History" button some text

2018-03-14 Thread Christian
Fuchs added a comment. In D11306#225667 , @broulik wrote: > Either remove the icon or put it on the right, then I wouldn't really mind this change. putting it on the right would make it inconsistent with every single plasma and KDE butto

D11306: Give the "Clear History" button some text

2018-03-13 Thread Christian
Fuchs added a comment. Sorry, but clear -1 from me for the reasons outlined in the Telegram channel. It looks cluttered, and with the very limited space in plasmoids it becomes unpredictable with translations. It removes the very alignment that broulik and I worked hard to achieve.

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. In D11261#224058 , @abetts wrote: > In D11261#224056 , @Fuchs wrote: > > > In D11261#224054 , @abetts wrote: > > > > > We have di

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. In D11261#224054 , @abetts wrote: > We have discussed something like this before. My only worry with this implementation is that we have so much red on the screen that it becomes distracting. Not the fault of this patch, b

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs added a comment. New screenshot with fixes F5750621: clearhistory.png REPOSITORY R120 Plasma Workspace BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc:

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29325. Fuchs added a comment. - Better hack for placement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29321&id=29325 BRANCH fuchs-notification-clearhistory (branched from master) REVISION DETAIL

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29321. Fuchs added a comment. - Change the layout import according to kbroulik REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29320&id=29321 BRANCH fuchs-notification-clearhistory (branched from maste

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29320. Fuchs added a comment. - Use Math.round() as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29319&id=29320 BRANCH fuchs-notification-clearhistory (branched from master) REVISION

D11261: Add a button to clear the notification history

2018-03-12 Thread Christian
Fuchs updated this revision to Diff 29319. Fuchs added a comment. - Capitalized History in the tooltip label as per discussion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11261?vs=29318&id=29319 BRANCH fuchs-notification-clearhistory (branche

D11261: Add a button to clear the notification historyBUG: 386068FIXED-IN: 5.13.0

2018-03-12 Thread Christian
Fuchs added a comment. Screenshot: F5750498: clear_history.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11261 To: Fuchs, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D11261: Add a button to clear the notification historyBUG: 386068FIXED-IN: 5.13.0

2018-03-12 Thread Christian
Fuchs created this revision. Fuchs added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY Adds a button in the plasmoid header to clear the history, same as the

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs updated this revision to Diff 28221. Fuchs added a comment. Adapt code style. With regards to wording: even if we can't guarantee that audio is playing / being recorded, the wording is still correct. Since if there will be audio played / recorded, it will be on the device the us

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs marked an inline comment as done. Fuchs added a comment. In D10901#215274 , @ngraham wrote: > You're definitely not the only one who wants this. See: > > - https://www.reddit.com/r/kde/comments/7yrkmt/my_one_and_only_wish_please_excuse_

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10901 To: Fuchs, broulik, drosca Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs updated this revision to Diff 28219. Fuchs added a comment. Move text back to if/else for at least a bit of readability, reverted the check to go for > 1 since that is what we are interested in. Final revision, hopefully. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10901?v

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs added a comment. In D10901#215263 , @ngraham wrote: > At this point, let me also mention that screenshots are not only much appreciated, but vastly increase the chance of your patch (and name!) being featured in the next week's installment

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs updated this revision to Diff 28218. Fuchs marked an inline comment as done. Fuchs added a comment. According to discussion on IRC, sacrifice some more readability for brevity. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10901?vs=28214&id=28218 REVISION DETAIL https://pha

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs updated this revision to Diff 28214. Fuchs added a comment. Updated the text, tried to merge the code blocks. Due to most of it happening in a for loop depending on the type, this was not possible in a sane way without having a helper method created. Personally I think legibility g

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs added a comment. In D10901#215244 , @drosca wrote: > > Can you merge the code into one block? Technically yes, but due to some edge cases it will make it hacky and difficult to read. Example: you can have a second de

D10901: Add "move to device" functionality to hamburger menu

2018-02-27 Thread Christian
Fuchs created this revision. Fuchs added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY This patch adds the possibility to choose a device for a playbac

D10223: Improve preview thumbnail quality

2018-02-08 Thread Christian López
christianlopez added a comment. Hi, i was playing a bit with the code and i'm noticing you can get good looking images without activating the smooth and without making the thumbnails look blurry, also i think i know the reason why the thumbnails look distorted. At the line 239 in FolderItem

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-07-10 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #14 from Christian --- Has this patch been reviewed and been made available yet in Neon? -- You are receiving this mail because: You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-05-10 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #13 from Christian --- It was called the KDE desktop back when I started using Linux so the whole Plasma concept hasn't stuck yet 😊 Good thing out may get into Plasma so I can use this wallpaper option again. Thanks! -- You are rece

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-05-09 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #11 from Christian --- As a non-developer I guess I have to wait until this makes it into KDE before I will be able to use the NatGeo wallpaper again? -- You are receiving this mail because: You are the assignee for the bug.

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-04-21 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #6 from Christian --- (In reply to Kai Uwe Broulik from comment #4) > We run QXmlStreamReader over the page to find the og:image of the picture. > > However, HTML isn't strictly XML and so it chokes on the lines which com

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-04-21 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #5 from Christian --- (In reply to Clemens from comment #3) > In my case, it does not work at all. > Even after I reboot, the picture is not available. > > Plasma Version 5.9.4 I guess I wasn't being clear. Even befo

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-04-20 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 --- Comment #2 from Christian --- Good to know it's not only me, thanks. I still have the problem that the picture isn't changing until I reboot or after more than 24 hours. But that may be a second unrelated bug. We'll see if/when the

[Plasma Workspace Wallpapers] [Bug 379003] New: Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

2017-04-20 Thread Christian
https://bugs.kde.org/show_bug.cgi?id=379003 Bug ID: 379003 Summary: Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all. Product: Plasma Workspace Wallpapers Version: 5.9.4 Plat

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Christian
Fuchs added a comment. In https://phabricator.kde.org/D4838#91385, @colomar wrote: > > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > > (And whilst some of these points might not apply to this very specific use case here: they will else

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Christian
Fuchs added a comment. In https://phabricator.kde.org/D4838#91010, @colomar wrote: > In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > > > I thought of something like this: F2668672: Screenshot_20170228_114914.png > > Is this in li

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2016-12-30 Thread S . Christian Collins
https://bugs.kde.org/show_bug.cgi?id=374311 S. Christian Collins changed: What|Removed |Added Resolution|--- |UPSTREAM Status|UNCONFIRMED

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2016-12-30 Thread S . Christian Collins
https://bugs.kde.org/show_bug.cgi?id=374311 --- Comment #3 from S. Christian Collins --- I have reported this bug for Qt here: https://bugreports.qt.io/browse/QTBUG-57849 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374311] New: it is too easy to activate context menu item if mouse moves during right-click

2016-12-29 Thread S . Christian Collins
https://bugs.kde.org/show_bug.cgi?id=374311 Bug ID: 374311 Summary: it is too easy to activate context menu item if mouse moves during right-click Product: Breeze Version: 5.8.5 Platform: Neon Packages OS: L

[Breeze] [Bug 358224] breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-01-20 Thread Christian Stadelmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358224 Christian Stadelmann changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

[Breeze] [Bug 350682] Double-click on GTK widgets initiates window movement, breaks control of the widget

2016-01-19 Thread Christian Stadelmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=350682 Christian Stadelmann changed: What|Removed |Added CC||dah5a...@genodeftest.de --- Comment #10

[Breeze] [Bug 358224] New: breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-01-19 Thread Christian Stadelmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358224 Bug ID: 358224 Summary: breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable Product: Breeze Version: 5

[Breeze] [Bug 351099] krunner unusable with dark breeze theme

2016-01-19 Thread Christian Stadelmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351099 Christian Stadelmann changed: What|Removed |Added CC||dah5a...@genodeftest.de --- Comment #2

Re: Review Request 125618: Fixes to KameraConfigDialog

2015-10-29 Thread Christian Butcher
interface. Thanks, Christian Butcher ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125618: Fixes to KameraConfigDialog

2015-10-29 Thread Christian Butcher
891536d11f1779ee21a23b18fc2d3558f77bbc89 by Christian Butcher. Manual commit message because I messed up the commit message (forgot the REVIEW: tag) - Christian Butcher On Oct. 27, 2015, 8:45 a.m., Christian Butcher wrote: > > --- > This is an automatically generat

Re: Review Request 125618: Fixes to KameraConfigDialog

2015-10-27 Thread Christian Butcher
can't interface. Thanks, Christian Butcher ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125618: Fixes to KameraConfigDialog

2015-10-26 Thread Christian Butcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/#review87484 --- Are any changes needed? - Christian Butcher On Oct. 13

Review Request 125618: Fixes to KameraConfigDialog

2015-10-12 Thread Christian Butcher
Dolphin allow me to open it nicely, and Kamera KCM shows the phone, but won't allow any actions on it. Unsure if this means that the KCM should discard MTP phones with which it can't interface. Thanks, Christian Butcher ___ Plasma-devel ma

Re: Review Request 125433: kcm_kamera: Double calls to load() lead to strange scrollbars after saving a change

2015-10-08 Thread Christian Butcher
marked as submitted. Review request for KDE Graphics, Plasma and Marcus Meissner. Changes --- Submitted with commit 67f21dab67409261879268c6372b69ad95eb9e74 by Christian Butcher to branch master. Repository: kamera Description --- The displayGPSuccessDialogue(void) function calls

  1   2   3   >