D26241: Remove Kirigami DelegateRecycler

davidedmundson added a comment. Sounds like BUG: 404518 BUG: 411795 Which we have quite a lot of dupes of :/ We know this bug went away with Qt5.14, so maybe it's worth just merging this simple fix. Wait for @notmart, but I say lets merge this into Plasma 5.17.x +1

D26388: Get rid of KGlobalSettings

davidedmundson accepted this revision. davidedmundson added a comment. Couldn't even find a reference in kde-workspace / kdelibs in plasma4 code when I went searching... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26388 To: ervin, #plasma, mart, davidedm

D26338: Ensure WM initializes before session starts

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. On the conceptual level, does it make more sense for the relevant client (konsole) to monitor for compositing changed itself. It's something that could change at r

D26391: DesktopPaths KCM: Remove the moving directory logic

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > it would also leave you stranded in case of an uncompleted move. That's actually quite easy to hit if a move causes conflcts and you press cancel...I just did so

D26462: RFC: Register Secret Agent on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R116:169d398bfeda: egister Secret Agent on startup (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26462?vs=72874&i

D26467: KCM runners: fix default button

davidedmundson added a comment. We're entering an awkward part of the Plasma release cycle. Our next beta is in 3 weeks but will depend on the framework that has just been tagged. Any changes entering master, need to be compilable against 5.66 otherwise they will have to wait until aft

D26462: RFC: Register Secret Agent on startup

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidedmundson requested review of this revision. REVISION SUMMARY Plasma NM's KDED is loaded on boot, but ef

D26438: Runners: Convert foreach to for

davidedmundson added a comment. We don't need any custom code, it's a QMap, it has existing iterators already which can be used. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26438 To: meven, #plasma, davidedmundson, ivan Cc: ivan, davidedmundson, plasma-

D26438: Runners: Convert foreach to for

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Cool, thanks INLINE COMMENTS > fetchsqlite.cpp:100 > query.prepare(sql); > -foreach(const QString &variableName, bindObjects.keys()) { > +for(const QString &var

D26382: Port KCM menu away from PlasmaComponents

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e055c1e1754: Port KCM menu away from PlasmaComponents (authored by davidedmundson). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26382?v

D26382: Port KCM menu away from PlasmaComponents

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidedmundson requested review of this revision. REVISION SUMMARY Plasma's menu can't handle being in a nest

D26344: Fix building plasma-desktop without X11 cursor development headers

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That may fix the build, but it's a somewhat hamfisted approach, lookandfeel is a key KCM, we can't make that depend on an optional feature. We need to either:

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added a comment. > Done, but now opening the KCM prints a ton of these errors: Is this still an issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: davidedmundson, astip

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. maybe drop the ::test method when merging REPOSITORY R120 Plasma Workspace BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phabricator.kde.

D26068: [KCM/Activity] Use KConfigXT to store settings

davidedmundson added inline comments. INLINE COMMENTS > PrivacyTab.cpp:67 > +{ > +mainConfig->deleteLater(); > +pluginConfig->deleteLater(); Why do we explicitly call deleteLater on these? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson added inline comments. INLINE COMMENTS > strutmanager.h:22 > +public Q_SLOTS: > +void setAvailableScreenRect(QString service, QString screenName, > QRect rect); > +void setAvailableScreenRegion(QString service, QString screenName, > QList rects); (const QStri

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson added a comment. Thanks for following up! > I'll open a Qt bug and see how it goes. Can you link it please. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure,

D26224: [kicker] Fix a few unqualified property access

davidedmundson added a comment. Can you show me how you used qmllint -U When I tried it couldn't resolve any of the plasma types REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26224 To: nicolasfella, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, T

D26223: Explictly state which X11 components are required

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we can find X11 without the required xf86vmode and fail at link t

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. After 900f2cb6f7070 in QtBase auto dpi changed it's meaning somewhat. The comment written no longer applies and #ifdef'ing is the correct thing to get the consiste

D25634: Add kconf update script for ksmserver

davidedmundson added a comment. > -1 I'd prefer if the config value was kept See D25609 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-

D26021: Display sub categories when searching

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > MenuModel.cpp:49 > > +QHash MenuModel::roleNames() const > +{ In other models we tend to drop the suffix "Role" from the rolename i.e Qt::DisplayRole

D25935: [Notifications] Add hint for a notification being response to explicit user interaction

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I thought you were going to call it UserActionFeedback? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma, davide

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kmaterka wrote in sniproxy.cpp:228 > xcb_configure_notify_event_t > > @davidedmundson In this commit >

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > main.qml:89 > +evenBeginManField.backend = cA.eveningBeginFixedDefault; > +transTimeField.value = cA.transitionTimeStaged = > cA.transitionTimeDefault; > Please split. REPOS

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

davidedmundson added a comment. That's accepting purely code-wise. Please make sure the text is approved by VDG people before pushing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26018 To: broulik, #plasma, #vdg, davidedmundson Cc: ngraham, plasma-devel

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson added a comment. > In future I will want to cleanup the code a bit (formatting, maybe some refactoring). I don't know if this welcomed because this will break git history. Refactoring, sure go for it. I don't really agree with people worrying about git history, if you ha

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Awesome stuff INLINE COMMENTS > sniproxy.cpp:4 > * Copyright (C) 2015 David Edmundson > * > * This library is free software; you can redistribute it

D25777: Avoid deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a9e84b79e6c: Avoid deprecated method (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25777?vs=70996&id=71780 REVISION DETAIL

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson added a comment. That's quite a good idea. INLINE COMMENTS > sniproxy.cpp:154 > //tell client we're embedding it > -xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, m_containerWid, 0, 0); > +xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, 0, m_containerWid, > XEM

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 593 - Failure!

Dep can't be fetched, problem exists on the CI side. I have filed a sysadmin request to look into this. David

D26021: Display sub categories when searching

davidedmundson added inline comments. INLINE COMMENTS > MenuModel.cpp:102 > +MenuItem *candidate = mi->parent(); > +while ( candidate && candidate->parent() && > candidate->parent()->parent() ) { > +candidate = candidate->parent(); More comments are neede

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > 60: StylePrivate.PropertyWriter is not a type Sounds like you just had your QQC2 style broken. In any case, this code all looks fine. Better to have to port one

D26031: feat: access outputs controls through config control

davidedmundson added a comment. Why do we need to compare names as well as ID? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26031 To: romangg, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zr

D26042: Captive portal notification improvements

davidedmundson added a comment. Due to a confusing design notification objects can delete themselves. If the network changes after the notification is externally closed this will crash. INLINE COMMENTS > portalmonitor.h:42 > +private: > +KNotification *m_notification = nullptr; > }

D26056: [dataengine/geolocalisation] clean debug traces

davidedmundson added a comment. if we're going to fix qDebug, lets fix the qDebug and move to categorized logging // qDebug() << "gpsd not found"; seems like an important warning REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26056 To: meven, a

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson added a comment. Much nicer! Re: string Vs int It can be ints within plasmashell, it just needs to be strings over the dbus protocol. The problem is that on wayland (and to some extent x11 is racey) the order of screens within QApplication::screens might not be i

D26026: refactor: let Control be a QObject

davidedmundson added a comment. > This is a preparatory step to add signals later for watching file changes. I don't think I understand. What for? If it's full output configuration going via the disk that would go against the main part of kscreen architecture. INLINE COMMENTS > contr

D25967: Emit panelTakesFocus for other plamsashell types

davidedmundson planned changes to this revision. davidedmundson added a comment. In hindsight, lets see if we can get something that fixes the widget explorer at the same time. It's basically the same issue. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL htt

D25984: Load translations

davidedmundson added a comment. > Okay. Which app did you test with? Does it link kcoreaddons? Would poke then as well a bit, as I happen to have a related rant blog post lying around ;) ). systemsettings5 exhibits this situation REPOSITORY R169 Kirigami REVISION DETAIL https://pha

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Concept is fine. INLINE COMMENTS > othershellhelper.cpp:7 > + > +OtherShellHelper::OtherShellHelper(ShellCorona *plasmashellCorona) : > QObject(qobject_cast(plasm

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

davidedmundson added a comment. > Maybe it could stay open after click only for the case where it's a tooltip for a grouped item and there are multiple windows in it? IIRC this is what Windows does, now that I think about it. But even so, which case which is more likely: A user want

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

davidedmundson added a comment. There's a huge difference compared to close. With the thumbail case, it's quite common that your next action is to want to interact with the window that's under the thumbnail. With close that isn't the case. Given this was added very explicitly (

D25986: Resize file dialog window before size restore

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2e9f96847432: Resize file dialog window before size restore (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kd

D25986: Resize file dialog window before size restore

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KDEPlatformDialogHelper explicitly resizes the window contents to the windo

D24238: Port the pager applet away from QtWidgets

davidedmundson closed this revision. davidedmundson added a comment. @dfaure You can commandeer and then click close REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n, The-

D25978: Don't hardcode the margin of the CardsListView

davidedmundson added a comment. Makes sense, but I don't understand how this helps, given the path is "private/" ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25967: Emit panelTakesFocus for other plamsashell types

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The semantics of a window taking focus on user interaction apply to more ro

D25933: [applets/pager] Calculate full screen geometry

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code original was QDesktopWidget::geometry() which covers all screens. T

D25826: [emojier] disable session manager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:24e43c524c9e: [emojier] disable session manager (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25826?vs=71140&id=71364 REVISIO

D25873: [KCMs/Workspace] Add explanatory labels for click-related settings

davidedmundson added a comment. It's not a common pattern we do in plasma currently, but that doesn't necessarily mean we shouldn't use it. INLINE COMMENTS > main.qml:131 > > +QQC2.Label { > +text: singleClick.checked ? i18n("Select by clicking on item's > selection ma

D25844: Add grouping options in Icons-only Task Manager

davidedmundson added a comment. > I'm not sure of the history behind why this split is presented in the form of two different applets To give history We had a UX in Plasma 4 where choosing between an analog and digital clock would be an option in the main clock applet, but choosing

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's true that's the only user of it right now, so this is technically correct. I don't think it's a problem for us to emit changes for the other things. KConfigWatcher

D25835: [kcms/launchfeedback] Port to KConfig notifiers

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b9a54826350c: [kcms/launchfeedback] Port to KConfig notifiers (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25835?vs=71161&id=

D25835: [kcms/launchfeedback] Port to KConfig notifiers

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This gets rid of all C++ code in this KCM! It gets rid of a kwin tie in where one shouldn't exist and also expose

D25792: Add notifiers to workspace options kcfg

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b00bcb9bc09: Add notifiers to workspace options kcfg (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25792?vs=71030&id=71155 R

D25826: [emojier] disable session manager

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code is copy pasted from elsewhere REPOSITORY R119 Plasma Desktop BRANCH

D23595: Speed up sending request to ksysguardd

This revision was automatically updated to reflect the committed changes. Closed by commit R111:2791a0c71f24: Speed up sending request to ksysguardd (authored by jpalecek, committed by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

[plasmashell] [Bug 370648] SDDM Breeze theme hardly usable on multiscreen set up with different DPIs

https://bugs.kde.org/show_bug.cgi?id=370648 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #2

[plasmashell] [Bug 374074] Login/Lock Screen: "Show Password" button vulnerable to social engineering

https://bugs.kde.org/show_bug.cgi?id=374074 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk Status

[plasmashell] [Bug 373668] Keyboard layout indicator is easy to miss due to placement in the corner of the screen

https://bugs.kde.org/show_bug.cgi?id=373668 David Edmundson changed: What|Removed |Added Resolution|--- |NOT A BUG CC

[Breeze] [Bug 384129] Rename colors from British to American English

https://bugs.kde.org/show_bug.cgi?id=384129 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #4

D25792: Add notifiers to workspace options kcfg

davidedmundson added a comment. Linked revision is needed to have it work properly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25792 To: davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham

D25792: Add notifiers to workspace options kcfg

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY A write flag got lost in the KCFG port. This adds it back. TEST PLAN dragged slider, kwin animation speed reloaded

D25449: Start of the new Formats KCM

davidedmundson added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmformats.pot > +$EXTRACTRC `find . -name "*.ui"` >> rc.cpp || exit 11 > +$XGETTEXT `find . -name "*.cpp"` -o $podir/kcm5_formats.pot this shou

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > +// FIXME: this doesn't work; it's always invisible > +visible: (monitor.State == Baloo.Baloo.FirstRun || > +monitor.State == Baloo.Baloo.NewFiles || Monitor's proper

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:81 > This is the wrong way round Edit, no it wasn't wrong But I have found what is. I export this as the class Baloo, but the import is also under Baloo So for this to work against my patch it would be Ba

D20222: Plasma-Workspace. The last checkbox in the widget settings

davidedmundson closed this revision. davidedmundson added a comment. https://commits.kde.org/plasma-workspace/eb6f6c2566622b883ca43138f8adee3c29f1f3fa REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham, da

D25777: Avoid deprecated method

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Does the same thing REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.or

D20222: Plasma-Workspace. The last checkbox in the widget settings

davidedmundson added a comment. If it's just a rebase needed, I'll land it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:81 > +id: toggleButton > +text: monitor.state == Baloo.Suspended ? i18n("Resume") : > i18n("Suspend") > +onClicked: monitor.toggleSuspendState() This is the wrong way round REPOSITO

D5346: DigitalClock: Use correct language for month and day names

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes to get it out my queue, as I think it needs more discussion after my comment above I could be maybe persuaded, but adding a bad hack

D5346: DigitalClock: Use correct language for month and day names

davidedmundson added a comment. The thing this fixes is there. It's arguably a tiny bit less relevant as people might now use a custom date format in just the digital clock, instead of choosing a different locale for times. FWIW, I submitted a change that did exactly this at the "co

D25637: Port away from kglobalsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e50eafbf7fe2: Port away from kglobalsettings (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25637?vs=70632&id=70963 REVISION D

D24866: Wired setting: improve handling of link negotiation

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > wiredconnectionwidget.cpp:79 > +m_widget->linkNegotiation->setCurrentIndex(LinkNegotiation::Manual); > +} > can loadConfig can be called m

D25310: Use the right value of EnableMagicMimeActions

davidedmundson added a comment. I can't really object, as you're just following the existing code, but I don't really understand why we're doing this. INLINE COMMENTS > urlgrabber.cpp:106 > -KConfigGroup cg(KSharedConfig::openConfig(), "Actions"); > -if(!cg.readEntry("EnableMagicMime

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in constants.js:23 > I'm not sure exactly what that means or how to do it; can you help me with it? See D25743

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Oh, well done! I'd seen the bug report but hadn't been able to fix it. INLINE COMMENTS > IconMode.cpp:119 > d->categoryView = nullptr; > +moduleView()->setFaceTy

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > + > +visible: fileSearchEnabled.checked && monitor.state != > Constants.State.Idle > + what about: LowPowerIdle? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraha

D25637: Port away from kglobalsettings

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in componentchooserterminal.cpp:87 > No need to notify here? I can't find someone else listening to this REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25637 To: davidedmundson, #plasma Cc: apo

D25668: Port away from deprecated KIconLoader::SmallIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R102:121da761bef1: Port away from deprecated KIconLoader::SmallIcon (authored by davidedmundson). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25668?vs=70702&id=70

D25668: Port away from deprecated KIconLoader::SmallIcon

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles, still get an Xorg icon in the tree REPOSITORY R102 KInfoCenter BRANCH

D25636: Fixup deprecated use of QWeakPointer::data

This revision was automatically updated to reflect the committed changes. Closed by commit R129:a2851338b3d6: Fixup deprecated use of QWeakPointer::data (authored by davidedmundson). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25636?vs=706

D25637: Port away from kglobalsettings

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This was there only to support notifying kdeinit4, which we no longer care

D25636: Fixup deprecated use of QWeakPointer::data

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY At the point init is run we can be sure that our decoration->client() point

D25634: Add kconf update script for ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Config enum value was moved in a recent commit to kcfg we should port the v

D25624: Don't use qmlRegisterType with QT-5.14

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. You'll find this with the other repos too. In general I've been reverting the relevant path of the cmake that forces no deprecated. REPOSITORY R124 System Settings R

D25612: Simplify load of locale variables

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Lovely. There's a writeexports.h in p-d to kill too. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 To: apol,

D25612: Simplify load of locale variables

davidedmundson added a comment. +1 INLINE COMMENTS > startplasma.cpp:143 > if (!QFile::exists(localerc)) { > QFile f(localerc); > f.open(QFile::WriteOnly); This may as well be merged if we're going to open the config next anyway REPOSITORY R120 Plasma Workspace REV

D25609: Port KSMServer's KCM to KConfigXT

davidedmundson added a comment. So much red :D INLINE COMMENTS > kcmsmserver.cpp:203 > - if ( dialog->emptySessionRadio->isChecked() ) > - s = QStringLiteral("default"); > - else if ( dialog->savedSessionRadio->isChecked() ) This patch renames this entry "default" to "emptySession" F

D25602: [System Tray] Restore old pin button size

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't like this * 1.25 business, but you are correct that's what the old code did. REPOSITORY R120 Plasma Workspace BRANCH old-pinbutton-size (branched from master)

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Alternatively, if we need to reset something when our window gets moved...could we watch for our window getting moved? It'll be the more technically correct, and keeps this

Re: Add D24530 to 5.17.4

Any dev can cherry-pick things to the stable branch. Where possible we prefer putting into 5.17 first and then merging 5.17 to master so git tracks it better, but in this case it's already merged. To repeat the full rules for any future questions or anyone else wondering: - we only backport fixe

D25592: handle action for custom shadow background hint

davidedmundson added a comment. Generally +1. Will approve once I've got through the applet change INLINE COMMENTS > ActionButton.qml:36 > > -opacity: action==undefined||action.enabled?1:0.6 > - > -Behavior on opacity { > -NumberAnimation { > -duration: unit

D25549: [kcms/keyboard] Port away from KToolInvokation

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I would prefer KRun::somethingsomething there's a lot of other magic when spawning a new process with environment variables for focus transfer that we don

D25227: Document Kirigami.Theme Better

davidedmundson accepted this revision. davidedmundson added a comment. Do you have commit access? If not can I have your email address? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25227 To: zanny, apol, davidedmundson Cc: davidedmundson, davidre, apol, mart, pla

D25514: Simpler theme deletion

davidedmundson added a comment. We have code here that validates the path, so there must be a pattern. We just need to instead of validating the path, construct it on the helper side. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25514

D25519: Fix broken multimedia control on lockscreen

davidedmundson added a comment. yes REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL https://phabricator.kde.org/D25519 To: ajyotirmay, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25514: Simpler theme deletion

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I also interpret it as such. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25514 To: filipf, davidedmundson, #pl

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > constants.js:23 > + > +var State = { > +Idle: 0, Why doesn't this come from the plugin? > main.qml:111 > +if (monitor.state == Constants.State.ContentIndexing) { > +return i18n("Currently ind

<    2   3   4   5   6   7   8   9   10   11   >