Re: Baloo and remote file systems

2018-07-19 Thread David Kahles
Hi Rainer, > I assume it relies on inotify or something similar to > avoid periodic full scans. I don't know enough about Baloo to answer your questions, but Baloo relies not only on inotify, but additionally on LMDB (lightning memory-mapped database). > Can anybody tell if it is possible to run

D9225: Fix building autotest on platforms where syscalls are not available

2018-01-04 Thread David Kahles
davidk added a comment. Just adding my 2 cent: I think the filter should work fine, as SCMP_SYS is explicit available to support different platforms. If the syscall isn't available, it uses negative pseudo syscall numbers to ignore those syscalls. REPOSITORY R133 KScreenLocker REVISION DE

D9673: Guard against syscalls not available on some platforms

2018-01-04 Thread David Kahles
davidk abandoned this revision. davidk added a comment. In https://phabricator.kde.org/D9673#186294, @bshah wrote: > Uh, sorry I forgot to mention in orignial PR: but https://phabricator.kde.org/D9225 Ok, no problem. I'll close this one. REPOSITORY R133 KScreenLocker REVISION

D9673: Guard against syscalls not available on some platforms

2018-01-04 Thread David Kahles
davidk added reviewers: bshah, graesslin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9673 To: davidk, bshah, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8756: Forbid more syscalls which could modify the filesystem

2018-01-04 Thread David Kahles
davidk added a comment. In https://phabricator.kde.org/D8756#186280, @davidk wrote: > I'm not sure what happens here as well. I guess that arm64 doesn't implement many syscalls. I will prepare a patch to exclude those syscalls if they're not available. Here it is: https://phabric

D8756: Forbid more syscalls which could modify the filesystem

2018-01-04 Thread David Kahles
davidk added a comment. In https://phabricator.kde.org/D8756#176550, @bshah wrote: > Hello, > > It seems this commit doesn't seem to build on arm64 properly: https://build.neon.kde.org/job/xenial_unstable_plasma_kscreenlocker_bin_arm64/1/console > > I don't exactly understand what

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
This revision was automatically updated to reflect the committed changes. Closed by commit R133:7720e8486337: Forbid more syscalls which could modify the filesystem (authored by davidk). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8756?vs=22174&id=221

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk added a reviewer: graesslin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D8756 To: davidk, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Forbid more syscalls. An malicious theme could create directories with the password as name, or encode the password in chmod bits. Also, preve

T5412: Improve Plasma PA usability

2017-03-07 Thread David Kahles
davidk added a comment. >> When having many devices, the list quickly becomes longer than the available space and you need to scroll. Which is difficult, because you can't use the scrollwheel for that on most of the applet because of the sliders. > > That's an issue in systray and not in

[Differential] [Commented On] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk added a comment. In https://phabricator.kde.org/D4324#80955, @broulik wrote: > I think this is just working around the fact that a KCM has no way of postponing the closing/deletion of the dialog when OK is clicked. We have the issue of OK not saving settings properly in vari

[Differential] [Abandoned] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk abandoned this revision. davidk added a comment. This needs more changes, will upload again if everything works. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D4324 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dav

[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated this revision to Diff 10658. davidk added a comment. Fix method name REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4324?vs=10657&id=10658 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4324 AFFECTED FILES src/accoun

[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated this revision to Diff 10657. davidk added a comment. Move the file instead of copying it REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4324?vs=10656&id=10657 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4324 AFFECTE

[Differential] [Updated] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated the summary for this revision. davidk updated the test plan for this revision. davidk added a reviewer: Plasma. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D4324 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the CopyJopb thead will be killed if the user klicks the "OK" button, because kcmshell5 quits. Thus the icon won't get saved. As t

[Breeze] [Bug 358224] breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-11-18 Thread David Kahles
https://bugs.kde.org/show_bug.cgi?id=358224 David Kahles changed: What|Removed |Added CC||david.kahle...@gmail.com --- Comment #4 from

[Differential] [Updated] D3071: Port away from KDELibs4Support

2016-10-25 Thread davidk (David Kahles)
davidk marked an inline comment as done. davidk added a comment. Thanks for pointing this out, pushed in a separate commit. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3071 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Closed] D3134: Bring back usericon region selection

2016-10-25 Thread davidk (David Kahles)
This revision was automatically updated to reflect the committed changes. Closed by commit rUSERMANAGER35715e6a5e22: Bring back usericon region selection (authored by davidk). REPOSITORY rUSERMANAGER User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3134?vs=7605&id=7646 RE

[Differential] [Updated] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk updated the test plan for this revision. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3134 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterbe

[Differential] [Request, 35 lines] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk created this revision. davidk added a reviewer: Plasma. davidk added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Also, improve error checking. TEST PLAN - selected an new icon, got the region selector - without the resize, saving wil

[Differential] [Closed] D3071: Port away from KDELibs4Support

2016-10-22 Thread davidk (David Kahles)
This revision was automatically updated to reflect the committed changes. Closed by commit rUSERMANAGER4aafaf4e5fea: Port away from KDELibs4Support (authored by davidk). REPOSITORY rUSERMANAGER User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3071?vs=7421&id=7603 REVISION

[Differential] [Commented On] D3064: Port away from KDELibs4Support

2016-10-16 Thread davidk (David Kahles)
davidk added a comment. Abandoned, because it includes stuff which should be in it's own RR. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc: plasma-deve

[Differential] [Changed Policy] D3064: Port away from KDELibs4Support

2016-10-16 Thread davidk (David Kahles)
davidk changed the visibility from "No One" to "All Users". REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3064 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk Cc: plasma-devel, lesliezhai, ali-mohamed, jensreute

Re: [Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

2016-10-16 Thread David Kahles
Hey, Sorry, thats my fault. I didn't get the differences between Reviewboard and Phabricator, and included things into the review, which shouldn't be there. When I tried to abandon the revision, I restricted the access to myself. I just uploaded a new RR which should work fine. Am Sonntag, 16.

[Differential] [Request, 125 lines] D3071: Port away from KDELibs4Support

2016-10-16 Thread davidk (David Kahles)
davidk created this revision. davidk added a reviewer: Plasma. davidk added a subscriber: plasma-devel. davidk added a project: Plasma. TEST PLAN Builds and works fine, including the password dialog. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.

[Differential] [Abandoned] D3065: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk abandoned this revision. davidk added a comment. Sorry for the noise, I have some problems with phabricator. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3065 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 125 lines] D3065: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3065 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt

[Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Bring back the usericon region selection Also improve error checking. REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DE

Re: multiscreen logging

2016-07-28 Thread David Kahles
Hi, Am Donnerstag, 28. Juli 2016 12:23:56 CEST schrieb Sebastian Kügler: On donderdag 28 juli 2016 01:18:00 CEST David Kahles wrote: I think the problem with this approach is, that most (or even all?) of these processes aren't units but simple processes. A better approach using the pow

Re: multiscreen logging

2016-07-27 Thread David Kahles
Hi, Am Mittwoch, 27. Juli 2016 22:44:38 CEST schrieb Mark Gaiser: On Tue, Jul 26, 2016 at 3:09 PM, Mark Gaiser wrote: On Tue, Jul 26, 2016 at 2:03 PM, Sebastian Kügler wrote: Hey, [Please keep both lists addressed.] Debugging multiscreen issues is a nightmare: - there are at least 4 dif

Re: Review Request 125755: Fix build with QT5.6

2016-03-18 Thread David Kahles
65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 Diff: https://git.reviewboard.kde.org/r/125755/diff/ Testing --- Compiles now. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 125755: Fix build with QT5.6

2016-03-10 Thread David Kahles
an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125755/#review87258 --- On Oct. 22, 2015, 1:20 p.m., David Kahles wrote: > > --- > This i

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Kahles
> On Jan. 10, 2016, 2:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. > > David Kahles wrote: > I talked to them (see https://codereview.qt-project.org/#/c/144

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Kahles
> On Jan. 10, 2016, 2:06 p.m., David Edmundson wrote: > > That sounds like you're saying Qt has broken API. > > If that's true, they'll want to know about it. I talked to them (see https://codereview.qt-project.org/#/c/144823/) and it seems like we shouldn't have done it like it was before, it

Review Request 125755: Fix build with QT5.6

2015-10-22 Thread David Kahles
Diff: https://git.reviewboard.kde.org/r/125755/diff/ Testing --- Compiles now. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125754: Fix build with QT5.6

2015-10-22 Thread David Kahles
7e610069ab22b8635e05a59450431dbea4c083ee kcms/cursortheme/xcursor/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 Diff: https://git.reviewboard.kde.org/r/125754/diff/ Testing --- Compiles now. Thanks, David Kahles ___ Plasma-devel

Review Request 125754: Fix build with QT5.6

2015-10-22 Thread David Kahles
4fc70a605d5fc3165de78916db92c13bb67c0429 Diff: https://git.reviewboard.kde.org/r/125754/diff/ Testing --- Compiles now. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125694: Use the correct old screen to shift panels to new screen

2015-10-19 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 20778e83026d5390230bb3b2726f9c722878ba78 by David Kahles to branch master. Repository: plasma-workspace Description --- To move the panels of screen [i] to the next screen, we should query for the

Re: Review Request 125693: Prevent changing the primary screen when it doesn't have a view yet

2015-10-19 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 61828df89f3e7319bdc7024409804b51c0ba5b68 by David Kahles to branch master. Repository: plasma-workspace Description --- When a new primary output gets connected, it's possible

Re: Review Request 125696: Fix calculation of available screen region

2015-10-19 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 95d56f617e027a88d25fe37a2bc27ca1383998ac by David Kahles to branch master. Repository: plasma-workspace Description --- Only exclude panels on the requested screen instead of all panels. Diffs

Review Request 125694: Use the correct old screen to shift panels to new screen

2015-10-18 Thread David Kahles
m not sure whether this loop works with more than 2 screens, this needs more investigation.. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125696: Fix calculation of available screen region

2015-10-18 Thread David Kahles
used. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125693: Prevent changing the primary screen when it doesn't have a view yet

2015-10-18 Thread David Kahles
ts() after addOutput() when connecting a new screen set as primary screen. (That doesn't mean it works, but at least there's a bug less) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Kahles
gt; > > if we do block wheel events changing the slider's value, how will > > PulseObject.volume change? > > David Kahles wrote: > It doesn't change the volume. This is a try to implement what I wrote as > a comment above, so it tries to block the w

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-12 Thread David Kahles
> On Oct. 13, 2015, 1:08 a.m., David Edmundson wrote: > > src/kcm/package/contents/ui/VolumeSlider.qml, line 86 > > > > > > I don't understand what this line is doing > > > > if we do block wheel events c

Re: Review Request 125089: Fix changing volume with horizontal scroll

2015-10-10 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/#review86637 --- Ship it! Ship It! - David Kahles On Sept. 7, 2015, 1:41

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-12 Thread David Kahles
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 8a85589afc0b6c242ab50177bc4b0259268352a7 by David Kahles to branch master. Repository: plasma-framework Description --- Remove the documentation of the non-existent parameter

Re: Review Request 125091: Speedup finding the property change signals

2015-09-11 Thread David Kahles
ed to loop there either. Diffs - src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad Diff: https://git.reviewboard.kde.org/r/125091/diff/ Testing --- Everything works as before. Thanks, David Kahles ___ Plasma-devel mailing list Pl

Re: Review Request 125038: Make SourceModel writeable

2015-09-11 Thread David Kahles
- Changing the input volume from the applet works fine now (testes with skype and pavucontrol) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
iff: https://git.reviewboard.kde.org/r/125171/diff/ Testing --- Nothing, I think there's no testing needed Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
needed Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125091: Speedup finding the property change signals

2015-09-07 Thread David Kahles
8ad Diff: https://git.reviewboard.kde.org/r/125091/diff/ Testing --- Everything works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125088: Allow to change volume with mouse wheel

2015-09-07 Thread David Kahles
are other opioins on that? In the kcm, it should work as there is more space and the devices/applications are seperated in tabs, thanks for that. - David Kahles On Sept. 7, 2015, 12:58 p.m., David Rosca wrote: > > --- > This is an a

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
de.org/r/125038/diff/ Testing --- Changing the input volume from the applet works fine now (testes with skype and pavucontrol) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
-------- On Sept. 7, 2015, 2:11 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125038/ > -

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
de.org/r/125038/diff/ Testing --- Changing the input volume from the applet works fine now (testes with skype and pavucontrol) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125038: Make SourceModel writeable

2015-09-06 Thread David Kahles
works fine now (testes with skype and pavucontrol) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125038: Make SourceModel writeable

2015-09-03 Thread David Kahles
https://git.reviewboard.kde.org/r/125038/diff/ Testing --- Changing the input volume from the applet works fine now (testes with skype and pavucontrol) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/p

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
this bug in any other applet configurations. (Maybe they're using different technics, don't know that) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
ics, don't know that) Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-26 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit bba9e301cde90e7442ed1b5f5268061ddaeaad7f by David Kahles to branch master. Repository: plasma-desktop Description --- As offset and length have a different meaning in all alignments, the panel shifts

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit d058c1d44f0d9276f3a6287513023041065afe1c by David Kahles to branch master. Repository: plasma-desktop Description --- Prevent users from moving the panel off the monitor, and prevent users from moving

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit c4617a65b2bfdad2b0bb3274c08f3a45d2c3c4eb by David Kahles to branch master. Repository: plasma-desktop Description --- Add some comments to this IHMO hard to understand code. I hope I understood the

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
/124786/#review84238 --- On Aug. 17, 2015, 12:50 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
enter & AlignLeft To be precise, it's (alignment != Qt.AlignRight) && (alignment & Qt.AlignRight) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.o

Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-26 Thread David Kahles
- David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/#review84194 --- On Aug. 17, 2015, 11:31 a.m., David

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124782/diff/ Testing --- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-17 Thread David Kahles
e. It works for horizontal and vertical panels. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-17 Thread David Kahles
efore. It works for horizontal and vertical panels. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-17 Thread David Kahles
figuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 Diff: https://git.reviewboard.kde.org/r/124785/diff/ Testing --- When changing the alignment, the offset gets 0, so there are no invalid panel positions on alignment change Thanks, Da

Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-16 Thread David Kahles
--- Changing the size and position works as before. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

2015-08-02 Thread David Kahles
: https://git.reviewboard.kde.org/r/124434/diff/ Testing --- Using the panel configuration bar works much better now as it doesn't hide immediately. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/ma

Re: Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-27 Thread David Kahles
/ Testing --- Deleting applets or hovering over the dialog feels better now Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124481: [Panel] Fix min/max size sliderhandles

2015-07-27 Thread David Kahles
: https://git.reviewboard.kde.org/r/124481/diff/ Testing --- Changing the panel size (min- and maximum size) works well in all alignments. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-27 Thread David Kahles
reply, visit: https://git.reviewboard.kde.org/r/124433/#review83020 --- On July 27, 2015, 11:53 a.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-27 Thread David Kahles
hovering over the dialog feels better now Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-27 Thread David Kahles
> On July 26, 2015, 3:39 p.m., Marco Martin wrote: > > Same concerns as the panel controller one > > David Kahles wrote: > No, this is unrelated to the panel controller. The widget deletion dialog > disappears even with the click to focus strategy. > This RR

Review Request 124481: [Panel] Fix min/max size sliderhandles

2015-07-26 Thread David Kahles
- and maximum size) works well in all alignments. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-26 Thread David Kahles
n July 23, 2015, 5:18 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124433/ > --- > >

Re: Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

2015-07-24 Thread David Kahles
> On July 24, 2015, 1:25 a.m., David Edmundson wrote: > > the panel doesn't currently hide when the mouse leaves, only when another > > window gets focus. > > > > Do you have focus follows mouse set? > > David Kahles wrote: > Yes I have, without fo

Re: Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

2015-07-24 Thread David Kahles
> On July 24, 2015, 1:25 a.m., David Edmundson wrote: > > the panel doesn't currently hide when the mouse leaves, only when another > > window gets focus. > > > > Do you have focus follows mouse set? > > David Kahles wrote: > Yes I have, without fo

Re: Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

2015-07-23 Thread David Kahles
----- On July 23, 2015, 6:02 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124434/ >

Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

2015-07-23 Thread David Kahles
much better now as it doesn't hide immediately. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124433: [Panel] Delay disappearance of widget deletion dialog

2015-07-23 Thread David Kahles
prevent disappearing. Diffs - containments/panel/contents/ui/ConfigOverlay.qml 170aa389f8b4695ee97151081d2f2799754d0619 Diff: https://git.reviewboard.kde.org/r/124433/diff/ Testing --- Deleting applets or hovering over the dialog feels better now Thanks, David Kahles

Re: Lockscreen multiscreen behavior

2015-06-20 Thread David Kahles
On 06/17/2015 05:07 PM, Martin Gräßlin wrote: Am 2015-06-17 14:39, schrieb David Kahles: On 06/17/2015 05:30 AM, Martin Gräßlin wrote: Am 2015-06-16 16:58, schrieb David Kahles: Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen

Re: Lockscreen multiscreen behavior

2015-06-19 Thread David Kahles
On 06/17/2015 05:07 PM, Martin Gräßlin wrote: Am 2015-06-17 14:39, schrieb David Kahles: On 06/17/2015 05:30 AM, Martin Gräßlin wrote: Am 2015-06-16 16:58, schrieb David Kahles: Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen

Re: Lockscreen multiscreen behavior

2015-06-17 Thread David Kahles
On 06/17/2015 05:30 AM, Martin Gräßlin wrote: Am 2015-06-16 16:58, schrieb David Kahles: Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen is displayed on all connected monitors. I would prefer if the lockscreen is displayed only

Lockscreen multiscreen behavior

2015-06-16 Thread David Kahles
Hello, I want to hear some opinions about the multiscreen behavior of the lockscreen. Currently the lockscreen is displayed on all connected monitors. I would prefer if the lockscreen is displayed only on the primary monitor, as it's done at the loginscreen, because there is no need for mult

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-15 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 044f1bcce8bb769a41d3aa4f38aee9b64e608d30 by David Kahles to branch master. Repository: plasma-workspace Description --- This selects the (wrong) password at the lockscreen not before the grace lock

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-04 Thread David Kahles
> On June 3, 2015, 5:58 p.m., Martin Klapetek wrote: > > Can you please explain once again what the problem is and why this solves > > it? > > David Kahles wrote: > I forgot to mention that this refers to the lockscreen, sorry. > > If the user types

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-03 Thread David Kahles
ard.kde.org/r/123991/#review81129 --- On June 3, 2015, 7:26 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-03 Thread David Kahles
Diff: https://git.reviewboard.kde.org/r/123991/diff/ Testing --- Works fine for me, tested on two archlinux machines. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123991: Select lockscreenpassword not until user can type

2015-06-03 Thread David Kahles
sting --- Works fine for me, tested on two archlinux machines. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123688: Improve sddm login experience

2015-05-26 Thread David Kahles
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 0eb746cc8c357a626f8d3a80e336a8a48d1654fe by David Edmundson on behalf of David Kahles to branch master. Repository: plasma-workspace Description --- Disables the button and the passwordfield while the

Re: Review Request 123688: Improve sddm login experience

2015-05-21 Thread David Kahles
> On May 8, 2015, 9:14 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/loginmanager/Main.qml, line 97 > > <https://git.reviewboard.kde.org/r/123688/diff/1/?file=367729#file367729line97> > > > > Why would you put that into a property? Just tive the Ti

Re: Review Request 123688: Improve sddm login experience

2015-05-17 Thread David Kahles
8/#review80518 --- On May 9, 2015, 2:46 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123688/ >

Re: Review Request 123688: Improve sddm login experience

2015-05-09 Thread David Kahles
iff: https://git.reviewboard.kde.org/r/123688/diff/ Testing --- Login and failed login are working as expected. Tested in qmlscene and on two computers running Archlinux. Thanks, David Kahles ___ Plasma-devel mailing list Plasma-devel@kde

Re: Review Request 123688: Improve sddm login experience

2015-05-09 Thread David Kahles
he other timer too. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/#review80102 --- On May 8, 2015, 6:48 p.m

Re: Review Request 123688: Improve sddm login experience

2015-05-09 Thread David Kahles
y, visit: https://git.reviewboard.kde.org/r/123688/#review80101 ------- On May 8, 2015, 6:48 p.m., David Kahles wrote: > > --- > This is an automatically generated e-mail. To repl

  1   2   >