D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. When I was updating this client's UI, I was pretty conflicted about using group boxes, many of the other VPN clients were using group boxes for their main window and at one stage I was thinking of introducing group boxes for the main window of this client. It was de

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic updated this revision to Diff 76933. dkosovic added a comment. updates based on review comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27764?vs=76731&id=76933 REVISION DETAIL https://phabricator.kde.org/D27764 AFFECTED FILES vpn/l2tp/CMakeLists.txt vpn/l2tp/l

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. I'm of mixed minds on the group boxes. With L2TP/IPsec connection setup instructions for macOS and iOS, they typically have screenshots of the "User Authentication" and "Machine Authentication" settings. Many Linux users try to match what they see for other pla

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. In D27764#621173 , @jgrulich wrote: > @dkosovic will you update the review to address my comments? I agree with all your comments and they are great nitpicks and suggestions. Sorry I didn't have time tonight

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. This patch is depends on D27763 being applied first. Old l2tp: F8144374: old-l2tp.png Old l2tp IPsec Settings : F8144378: old-l2tp-ipsec.png

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. dkosovic requested review of this revision. REVISION SUMMARY - Update to NetworkManager-l2tp 1.8.0 features which include: - NetworkManager-l2tp 1.8.0 u

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

dkosovic created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. dkosovic requested review of this revision. REVISION SUMMARY Calling the IPsec dialog Advanced is confusing, so rename it to IPsec. Also in a subsequent p

D6111: UI updates for NetworkManager-l2tp 1.2.6

dkosovic added a comment. I'm not aware of being given any privileges to push it. If I was to push it, I'm guessing I need to use Arcanist and git? But I'm happy for you to push it. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D6111 T

D6111: UI updates for NetworkManager-l2tp 1.2.6

dkosovic created this revision. dkosovic added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Could the plasma-nm/vpn/l2tp/ source be updated to support IPsec changes introduced with NetworkManager-l2tp version 1.2.6. A screen shot of the curre