Re: QML: a packagers nightmare. Assistance please.

2023-11-08 Thread Heiko Becker
On Wednesday, 8 November 2023 12:48:32 CET, David Redondo wrote: So the situation right now is that plasma-workspace build depends on KWin and KWin has a runtime dependency on plasma-workspace. I think it's not a full cycle since installing plasma-workspace does not need anything from KWin

The unfortunate state of Plasma's stable branch CI coverage

2021-06-26 Thread Heiko Becker
Hello all, after cherry-picking somthing to Plasma/5.22 branch I wanted to make sure it builds fine on build.kde.org. Turns out that it still builds Plasma/5.21. Apparently the branch metadata was updated, but some jobs on Jenkinks still need starting (documented here [1]). When I asked in

D28662: KCM LookAndFeel check widgetStyle availability before applying it

2020-05-05 Thread Heiko Becker
heikobecker added a comment. This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.: 14:11:19 FAIL! : KcmTest::testKCMSave() Compared values are not the same 14:11:19 Actual (cg.readEntry("widgetStyle", QString())):

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-04-09 Thread Heiko Becker
heikobecker abandoned this revision. heikobecker added a comment. Already done in 3fb633159ca4a1db166d5c54bbc025f71aba1652 . REPOSITORY R1028 Plasma Pass REVISION DETAIL https://phabricator.kde.org/D28398 To:

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-03-29 Thread Heiko Becker
heikobecker added a comment. In D28398#637401 , @apol wrote: > If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19. It

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

2020-03-29 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The former was introduced with Qt 5.14 while the latter was deprecated with 5.15

D27304: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f7a878e6d73: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27308: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R161:1076889d06f5: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D27307: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R845:d6062a6a0273: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D27306: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2b9a7a71b8b3: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27305: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R119:537729cbed02: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27308: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore. REPOSITORY R161 KActivity Manager Service

D27307: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail.

D27306: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes check-appstream-compliance to

D27305: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail.

D27304: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail.

D27281: Fix chrome bookmarks test

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b88cdbcfe156: Fix chrome bookmarks test (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27281?vs=75349=75351 REVISION DETAIL

D27281: Fix chrome bookmarks test

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, yurchor. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The urls were changed from http to https in the test's source files with

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:76ccc090: sddm-theme: Use non-deprecated KDEInstallDirs variable (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27241: sddm-theme: Use non-deprecated KDEInstallDirs variable

2020-02-08 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an absolute path

D24098: Remove unnecessary KF5People dependency

2019-09-19 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a27e8ceb53e: Remove unnecessary KF5People dependency (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24098?vs=66501=66514

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

2019-09-19 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists (authored by heikobecker). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D24098: Remove unnecessary KF5People dependency

2019-09-19 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Not longer needed after 84c8dade3ce0c9cad9da26b083c954655266c639

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

2019-09-19 Thread Heiko Becker
heikobecker updated this revision to Diff 66496. heikobecker added a comment. Used the ReadWrite flag to simplify REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24087?vs=66473=66496 BRANCH Plasma/5.17 REVISION DETAIL

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

2019-09-19 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY After a9f3a3d saveSettingsPrivate() errors out

D21524: Keep existing configurations' strings               

2019-09-19 Thread Heiko Becker
heikobecker added a comment. This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console Start

D23910: startplasma: Respect KDEWM again

2019-09-15 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fcd29399b9d: startplasma: Respect KDEWM again (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23910?vs=65932=66181 REVISION

D23910: startplasma: Respect KDEWM again

2019-09-12 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY It got lost during the porting to native executables TEST PLAN

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. In D23883#529898 , @davidedmundson wrote: > Happy to help, but I don't understand yet. > > kde-cli-tools doesn't use sessionmanagementbackend.h? > > The only user is inside plasma-workspace source. I

D23878: Use QTEST_GUILESS_MAIN for systeminformationtest

2019-09-12 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R871:0f346886dc48: Use QTEST_GUILESS_MAIN for systeminformationtest (authored by heikobecker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23878?vs=65853=65897

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-11 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN header gets installed, plasma-workspace builds fine against a previously and separately built libkworkspace REPOSITORY R120

D23877: Remove unneeded dependencies on X11 and QtX11Extras

2019-09-11 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R123:b6d6897bad6f: Remove unneeded dependencies on X11 and QtX11Extras (authored by heikobecker). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D23878: Use QTEST_GUILESS_MAIN for systeminformationtest

2019-09-11 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The test still works fine with it, allowing it to run without a display

D23877: Remove unneeded dependencies on X11 and QtX11Extras

2019-09-11 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY No longer needed after 34fc153b25935b693ece5048523c702246c6a0a8

D21129: Require KF5 5.58.0 like the rest of Plasma

2019-05-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2a2e73781481: Require KF5 5.58.0 like the rest of Plasma (authored by heikobecker). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21129?vs=57866=57867

D21129: Require KF5 5.58.0 like the rest of Plasma

2019-05-10 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21129 AFFECTED FILES CMakeLists.txt To:

D18983: Use the python version found by cmake in build_theme.sh

2019-02-13 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Build System. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Helpful if one has multiple python3 versions around. TEST PLAN builds fine

D18363: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R115:89992d14d696: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D18362: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:129dfcfd69d6: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18360: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R119:779854fa6431: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18364: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R116:7793c31e0132: [build] Search for kirigami as a runtime dependency (authored by heikobecker). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18364: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R116 Plasma Network Management

D18363: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.15 REVISION DETAIL

D18362: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.15 REVISION DETAIL

D18361: libkworkspace: Allow standalone build

2019-01-18 Thread Heiko Becker
heikobecker abandoned this revision. heikobecker added a comment. Sorry, accidentally uploaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18361 To: heikobecker Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18361: libkworkspace: Allow standalone build

2019-01-18 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY [build] Search for kirigami as a runtime dependency REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.15 REVISION

D18360: [build] Search for kirigami as a runtime dependency

2019-01-18 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN cmake lists kirigami as a found dependency REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.15 REVISION DETAIL

D18310: Require breeze >= 5.14.90

2019-01-17 Thread Heiko Becker
heikobecker abandoned this revision. heikobecker added a comment. Superseded by 843bc1cc087451d6debd86fb9f21004c4ad1fbc7 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18310 To:

D18310: Require breeze >= 5.14.90

2019-01-16 Thread Heiko Becker
heikobecker added a comment. Should probably wait until the version in breeze is actually increased to 5.14.90. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18310 To: heikobecker, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18310: Require breeze >= 5.14.90

2019-01-16 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY 622db3767ea7b6584800a9d140396a6855b2efba

D18309: don't set python exe to undefined

2019-01-16 Thread Heiko Becker
heikobecker added a comment. +1 I have no cmake < 3.12.0 to test, but the changes are reasonable. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18309 To: sitter, davidedmundson Cc: heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D12976: Check cmake _FOUND variables for existance

2018-05-21 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R838:659ae5f5981c: Check cmake foo_FOUND variables for existance (authored by heikobecker). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. In D12118#262926 , @ltoscano wrote: > I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install. Seems every other ki18n_install

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. In D12118#262921 , @ltoscano wrote: > This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue? Yeah, it tries to install an empty dir:

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. Ping? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12118 To: heikobecker, #plasma, graesslin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12118: Only install translations if they are available

2018-04-11 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise an empty directory might get

D11498: Install firefox's native messaging host to LIBDIR

2018-03-20 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R856:5846f3bfed56: Install firefoxs native messaging host to LIBDIR (authored by heikobecker). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D11498: Install firefox's native messaging host to LIBDIR

2018-03-19 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, bshah, broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R878:cf64323795b9: Search runtime dependencies on QML modules (authored by heikobecker). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10579?vs=27351=27352

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
heikobecker updated this revision to Diff 27351. heikobecker added a comment. Also updated README REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10579?vs=27338=27351 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10579 AFFECTED FILES

D10580: Add .arcconfig

2018-02-16 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R878:15dc67016117: Add .arcconfig (authored by heikobecker). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10580?vs=27339=27350 REVISION DETAIL

D10580: Add .arcconfig

2018-02-16 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Raises the required version of

Re: Plasma and Frameworks Release issue

2017-12-27 Thread Heiko Becker
On 12/26/17 17:57, David Edmundson wrote: > We have a frameworks and Plasma release schedule issue again. > > We have new API (Package::fileUrl literally everwhere and I have > something minor in kwin) that requires frameworks 5.42 > > This frameworks release comes out on the 6th of Jan. > The

D9385: Fix build without X11/XCB

2017-12-17 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R113:c10574bfcc4c: Fix build without X11/XCB (authored by heikobecker). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9385?vs=24042=24052 REVISION DETAIL

D9385: Fix build without X11/XCB

2017-12-17 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's missing the include for QQuickWindow in that case because of the incorrect nesting and fails

D7784: CMake 3.1 is the actually required version

2017-09-12 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R108:10381b10f899: CMake 3.1 is the actually required version (authored by heikobecker). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7784?vs=19453=19454 REVISION

D7784: CMake 3.1 is the actually required version

2017-09-12 Thread Heiko Becker
heikobecker edited the summary of this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7784 To: heikobecker, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7784: CMake 3.1 is the actually required version

2017-09-12 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY CXX_STANDARD is only available since 3.1. $ git show 913394af2: cmTarget: Add CXX_STANDARD and CXX_EXTENSION... $ git tag

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Heiko Becker
heikobecker added a comment. > But you can clear klipper's history. As you point out yourself "klipper provides that in the UI." From our POV what does it matter if that's exposed via a button here, or elsewhere. The fact that you could have malware doesn't remove the legit reasons to talk

D7536: Register klipper DBus interface when in non-standalone mode

2017-08-26 Thread Heiko Becker
heikobecker added a comment. FWIW, judging from a quick test the patch works and the applets history can be cleared via sweeper. In the case this causes problems, would there be another solution to clear the history? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D7526: Only run the integration tests if the requirements are met

2017-08-25 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R871:00b058db78b2: Only run the integration tests if the requirements are met (authored by heikobecker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D7525: Use QTEST_GUILESS_MAIN

2017-08-24 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R871:9cd2cf7adc46: Use QTEST_GUILESS_MAIN (authored by heikobecker). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7525?vs=18714=18716 REVISION DETAIL

D7526: Only run the integration tests if the requirements are met

2017-08-24 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise they fail quite miserably. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D7526

D7525: Use QTEST_GUILESS_MAIN

2017-08-24 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Allowing the test to pass without a running X server. TEST PLAN Test still passes. REPOSITORY R871 DrKonqi BRANCH master

D7506: Drop unnecessary dependency on KF5XmlRpcClient

2017-08-24 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d545538e5a9d: Drop unnecessary dependency on KF5XmlRpcClient (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7506?vs=18661=18667

D7506: Drop unnecessary dependency on KF5XmlRpcClient

2017-08-24 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It was required by drkonqi, but that was split out from plasma-workspace. REPOSITORY R120 Plasma Workspace BRANCH master REVISION

D7488: Fix deprecated usage of ecm_install_icons

2017-08-24 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R104:46ab5b1bbe62: Fix deprecated usage of ecm_install_icons (authored by heikobecker). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7488?vs=18607=18662 REVISION

D7488: Fix deprecated usage of ecm_install_icons

2017-08-23 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes a cmake warning. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D7488 AFFECTED FILES

D5699: Remove obsolete add_dependencies

2017-08-22 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R103:dab2e843793d: Remove obsolete add_dependencies (authored by heikobecker). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5699?vs=14110=18533 REVISION DETAIL

D7239: Drop unused dependency

2017-08-22 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R169:478b31fd1b92: Drop unused dependency (authored by heikobecker). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7239?vs=17984=18528 REVISION DETAIL

D7239: Drop unused dependency

2017-08-15 Thread Heiko Becker
heikobecker added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5699: Remove obsolete add_dependencies

2017-08-15 Thread Heiko Becker
heikobecker added a comment. Ping? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D5699 To: heikobecker, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7239: Drop unused dependency

2017-08-10 Thread Heiko Becker
heikobecker created this revision. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It was introduced with https://phabricator.kde.org/R169:c99775ef3cfe7c9c5718d73a1dc2fef8cde69a34 but I couldn't find why or

D6792: Make sure the dbus xml interface file exists before it's used

2017-07-22 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R101:db3a04289d0f: Make sure the dbus xml interface file exists before it's used (authored by heikobecker). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE

D6792: Make sure the dbus xml interface file exists before it's used

2017-07-20 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This started to happen with cmake 3.9, producing this erorr: - No rule to make target 'app/org.kde.khotkeys.xml', needed by

D6718: Fix occasional abort in the krunner plugin

2017-07-20 Thread Heiko Becker
heikobecker added a comment. Can't really say if there's something wrong elsewhere, but FWIW this patch indeed fixes crashing krunner, see https://bugs.kde.org/show_bug.cgi?id=382521 for the backtrace. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D5807: Update required KF5 and Kirigami dependencies

2017-05-13 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R134:f8f4741f57e0: Update required KF5 and Kirigami dependencies (authored by heikobecker). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D5807: Update required KF5 and Kirigami dependencies

2017-05-11 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Unfortunately Kirigami has an unchanged internal version of 5.22.0, thus cmake can't possibly detect it. But as it doesn't affect the

D5699: Remove obsolete add_dependencies

2017-05-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY History suggests this originated in the kde-workspace repo. Now that khotkeys and kmenuedit are split, kmenuedit doesn't know any

D5599: Remove no longer needed config-workspace header

2017-04-26 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R122:543e6c4235d7: Remove no longer needed config-workspace header (authored by heikobecker). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5599?vs=13831=13841

D5599: Remove no longer needed config-workspace header

2017-04-26 Thread Heiko Becker
heikobecker updated this revision to Diff 13831. heikobecker added a comment. Changed test plan description REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5599?vs=13830=13831 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5599

D5599: Remove no longer needed config-workspace header

2017-04-26 Thread Heiko Becker
heikobecker created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Most of these defines seem to originate from the old kde-workspace; DPMS is a hard dependency since

[Differential] [Closed] D4568: cmake: Use ${KF5_MIN_VERSION} to search for prison

2017-02-17 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab9c3bc68edf: cmake: Use ${KF5_MIN_VERSION} to search for prison (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4636: cmake: Actually search for KF >= 5.17.0

2017-02-17 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R845:4030ba24a69a: cmake: Actually search for KF >= 5.17.0 (authored by heikobecker). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4636?vs=11415=11437 REVISION

[Differential] [Request, 7 lines] D4636: cmake: Actually search for KF >= 5.17.0

2017-02-16 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Furthermore handle differently KF5SysGuard differently because, despite its misleading

[Differential] [Request, 4 lines] D4568: cmake: Use ${KF5_MIN_VERSION} to search for prison

2017-02-11 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ...for more consistency and also drop the comment, which has become obsolete. Prison has been

[Differential] [Closed] D3991: kstart: Port away from K4AboutData

2017-01-06 Thread heikobecker (Heiko Becker)
This revision was automatically updated to reflect the committed changes. Closed by commit R126:da328d6cada1: kstart: Port away from K4AboutData (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3991?vs=9796=9805#toc REPOSITORY R126 KDE CLI Utilities CHANGES

[Differential] [Request, 157 lines] D3991: kstart: Port away from K4AboutData

2017-01-06 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kstart: Port away from K4AboutData kstart: Remove remaining bits of KDELibs4Support REPOSITORY

  1   2   >