Re: Smart d-ptr in Plasma

2013-08-22 Thread Ivan Čukić
Well, I can add one more. They use variadic templates which are not in the list of C++11 features which can be used unconditionally in plasma-framework. Can be spared if you loose the forwarded constructor arguments though. The older MSVC (which I guess is the problem for including

Re: Smart d-ptr in Plasma

2013-08-22 Thread Ivan Čukić
If you're interested please bring it up on k-f-d and we'll see where it goes. Posted on kfd. Cheers -- So remember when you're feeling very small and insecure How amazingly unlikely is your birth And pray that there's intelligent life somewhere up in space Because there's bugger all down

Re: Mondaily meeting on Tuesday, 12:00

2013-08-19 Thread Ivan Čukić
Can we move it for Wednesday? I have a meeting tomorrow. Cheers, Ivan On 19 August 2013 22:13, Sebastian Kügler se...@kde.org wrote: Hey, Due to a party-induced incapacitation this Monday, our weekly meeting is scheduled for Tuesday, 12:00 Europe/Amsterdam. See you! -- sebas

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Ivan Čukić
(activity manager) in some applications? - Ivan Čukić On Aug. 12, 2013, 5:34 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Ivan Čukić
On Aug. 12, 2013, 5:50 p.m., Ivan Čukić wrote: Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications? Martin Gräßlin wrote: well it got introduced for KWin: commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0 Author: Martin

Re: Branch review request

2013-08-09 Thread Ivan Čukić
- A custom d-pointer implementation? This seems like overkill and To quote Aaron: would love to see all the dptrs move to your spiffy d_ptr smart pointer as well. after this blog post of mine: http://ivan.fomentgroup.org/blog/2013/06/22/d-ptr-the-modern-way/ *(2) The other thing I wanted to

Re: Branch review request

2013-08-09 Thread Ivan Čukić
It doesn't belong into plasma-framework, The original mail *was* about plasma-framework - the thread was started when Kevin removed the add_definitions(-std=c++0x) from the repo's top CMakeLists.txt http://mail.kde.org/pipermail/plasma-devel/2013-June/025747.html and you didn't answer my why

Re: Branch review request

2013-08-09 Thread Ivan Čukić
p.s. I'm a bit of a safe-coding buff lately - if something removes potential stupid bugs and doesn't introduce a performance overhead - I'm all into it (like for vs foreach and similar). ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Branch review request

2013-08-04 Thread Ivan Čukić
A small addendum - the ivan/shell-switching branch is sufficient - no need for the scratch repos. The loaders are quite simplified. The blank shell behaves like failsafe - it loads xterm application when shown - don't know how it behaves when xterm is not installed. -- Cheerio, Ivan -- While

Branch review request

2013-08-03 Thread Ivan Čukić
Hi all, I've realized that it will be painful if I wait until everything is finished to merge into master, and that there is not much reason for it to be so since the master is in a playground mode anyway. One of the reasons for the request is that I'd like to do a few things in parallel to

Re: Mondaily pow-wow at 12

2013-07-29 Thread Ivan Čukić
On Monday 29 July 2013 10:14:32 Marco Martin wrote: still traveling, next time for me I'll be there today. Cheerio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Monday Plasma Hangout at 12:00

2013-07-22 Thread Ivan Čukić
Let's do our Mondayly Plasma Catch-up hangout at 12:00 Amsterdam timezone. Antonis and Giorgos, you are excused in case you're still at OSC13. :) I will not be able to make it today. I'm currently playing around with shell loading/destroying. If everything goes as planned, I'll have it finished

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-30 Thread Ivan Čukić
+1 ABI should be the same in both versions (unlike gcc's std::list iirc) Just wondering, was this email as OK, I see where you come from, or was it I think we should discuss this at Akademy (with Aaron, Martin and Marco as a minimal WG). I'd separate the discussion in three parts that

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-29 Thread Ivan Čukić
I don't agree that these /additional/ features are about the api. algorithm is an (IMO) immensely useful, especially with lambdas and std::bind for actual non exposed parts. Well, yes that's all useful. That's the type of things I'd like to use everywhere too. I badly worded that above

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-28 Thread Ivan Čukić
On Friday 28 June 2013 08:13:32 Kevin Ottens wrote: Git commit 597397b41f5450f24ddc784e0faa13133fed6bd5 by Kevin Ottens. Committed on 28/06/2013 at 08:07. Pushed by ervin into branch 'master'. Revert Enabling C++11 flags for clang and gcc This request [1] got a green light by Aaron [2] and

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-28 Thread Ivan Čukić
Isn't the point of a dependency (on C++11) to make it required? Well, we have required and optional dependencies. C++11 is not special in that regard, we can make it either required or optional. So, essentially, the issue is that Plasma keeps both the framework and the shells in the same

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-28 Thread Ivan Čukić
such a premise VS2012 has a very partial C++11 support, Android NDK uses gcc 4.6 by default (apparently you can upgrade that to 4.7 but we can't expect third parties to do it by default, means partial support in both cases), BB10 cross- compiler doesn't properly support C++11. We're not The

Re: [plasma-framework] /: Revert Enabling C++11 flags for clang and gcc

2013-06-28 Thread Ivan Čukić
OK, then we got a misunderstanding somewhere... Using those Q_* macros is perfectly fine (and even encouraged, we already use Q_DECL_OVERRIDE and I'd like to see more Q_NULLPTR for instance). They enable exactly what I was describing earlier: works without C++11 support, you get extras

plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
Hi all, Following the previous discussions on k-c-d where it was concluded that the workspace-related code (as opposed to the libs) can use more modern c++ features as long as those are not introduced after gcc 4.5, I'd like to ask whether there are objections to add the -std=c++0x flag to the

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
obvious +1 (will do the same for KWin once 4.11 is branched). What about clang? Does it need an additional parameter? Yes, it (fortunately) uses the same one. -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight

Re: plasma-shell and -std=c++0x flag

2013-06-22 Thread Ivan Čukić
Martin ovious +1 Heh, I can always count on you when I mention c++11 :D Aaron yes, realy good idea. Cool, I promise I will not go overboard like with some kactivities parts :) Cheerio, Ivan -- Acting is merely the art of keeping a large group of people from coughing. -- Sir Ralph

Re: Keyboard detection and a test request

2013-06-21 Thread Ivan Čukić
What I did was: -Detect if any keyboard was present -Detect Mouse/touchpad you have a Qt wrapper of udev in kdelibs/solid. Great to know, will try it out later. Though I'm wondering whether this could lead to recognizing the devices that don't work with X. Anyhow, Aaron's

Re: Keyboard detection and a test request

2013-06-21 Thread Ivan Čukić
and when using udev you don't have to care about Wayland I don't care about it as it is :P (just joking) I'll probably end up with an udev backend. Which will be a great way to see how much I abstracted it all :) Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying

Shell and components dependencies definition

2013-06-12 Thread Ivan Čukić
Hi all, I've been investigating a few approaches regarding the way we could define the rules for when a component should be loaded (for example: virtual keyboard - no real keyboard, desktop shell - mouse and keyboard and a nice screen, netbook shell - mk and a small screen etc.*) At first, I

Re: Shell and components dependencies definition

2013-06-12 Thread Ivan Čukić
The shell is the only thing that will actually require this complexity, yes? If so, we can put this into the plasma-device shell itself; it does not need to be re-usable outside of plasma-device (until such time as we find other use cases for it). Aren't we supposed to have only plasma-shell

Re: module not found with qtextracomponents

2013-06-04 Thread Ivan Čukić
On Tuesday, 4. June 2013. 23.35.42 Heena Mahour wrote: Hi, using plasmoidviewer on using import org.kde.qextracomponents 0.1 I am getting error .:module org.kde.qextracomponents is not found Isn't it missing a 't' - org.kde.qtextracomponents Cheerio, Ivan -- Progress isn't made by early

Re: Device capabilities / platform status service

2013-06-02 Thread Ivan Čukić
.. or it could be a library rather than a service? Honestly, a library (khm khm solid) would be imo the right target. First, we can make it as a separate one, and then merge into solid when we are satisfied by it, and when kf5/solid is deemed stable. screen resolution is already handled by

Device capabilities / platform status service

2013-06-01 Thread Ivan Čukić
Hi all, For the shell switching / capabilities-based component loading, we'll need to have the system to get the capabilities of UI devices (obviously :) ). The service (guessing org.kde.platformstatus will fit this purpose) will need to be able to: - get the keyboard, attached/detached

Re: Review Request 110684: Do not show the File to activity linking plugin in context menus by default

2013-05-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110684/#review33267 --- Ship it! Ship It! - Ivan Čukić On May 28, 2013, 3:51 a.m

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-28 Thread Ivan Čukić
I'm obviously still in favour of scrapping the code or at least disabling it for 4.11 I'm leaning towards that decision as well - disabling until we start really using it somewhere. One thing I wanted to ask you - did you do some benchmarks about how much virtuoso slows down when the

Re: Reshuffling startup to start activity manager after ksmserver

2013-05-26 Thread Ivan Čukić
I would say that the right thing (what I as a user would expect to happen) is that clicking save session in the kickoff menu would save which I might be missing the point - kamd loads the last used activity on login (if it doesn't, it is a bug). What would change if we saved at 'save

Re: Reshuffling startup to start activity manager after ksmserver

2013-05-26 Thread Ivan Čukić
overriding the implementation of QApplication::saveState() or by using KSessionManager) Ah, ok then. You have the green light for the change, as long as it doesn't changes the workflow for the non-manually-saved-session-restoration mode. Cheerio, Ivan -- A program that has not been tested

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Ivan Čukić
Is there any code actually using it right now? Yes, plasma active is using it. Cheerio, Ivan -- A program that has not been tested does not work. -- Bjarne Stroustrup ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Ivan Čukić
Could you please point me to the relevant code? Quick grep (don't know the code, it is Marco's) plasma-mobile/components/metadatamodel/metadatamodel.cpp:411 Also, why duplicate the data in both the sqlite and nepomuk database? For the speed issues.* Storing and querying the desktop events

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Ivan Čukić
p.s. And it is used in libkactivities-models, but again, I don't know whether that library is used somewhere. (had a few inquiries about it since its inception) ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Ivan Čukić
If it has been removed then can we maybe stop storing the info in Nepomuk? It increases the size of the database, and as you know virtuoso is just one huge table and therefore all queries will be affected. For 4.11, we should have the feature of showing most used documents in the tasks

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-22 Thread Ivan Čukić
On Wednesday, 22. May 2013. 20.38.58 Marco Martin wrote: On Wednesday 22 May 2013, Vishesh Handa wrote: On Wed, May 22, 2013 at 5:11 PM, Ivan Čukić ivan.cu...@kde.org wrote: Could you please point me to the relevant code? Quick grep (don't know the code, it is Marco's

Re: Activities - Storing ResourceScoreCache in Nepomuk

2013-05-20 Thread Ivan Čukić
Hi, Not for activity ranking, but for resource ranking. (activity ranking is more complex). In the desktop world, we can use it for ranking the resources - right-click an application on the panel, get the list of the top documents for it, etc. The original resource score (exists in some

Re: Default activity naming issues

2013-05-18 Thread Ivan Čukić
Maybe there could even be a feature to make a snapshot of the current activity state and then another feature to restore that snapshot. that is (essentially) what stop/start does. I guess Djuro thought about creating multiple snapshots - to restore them later. The only thing I'd like

Re: Default activity naming issues

2013-05-18 Thread Ivan Čukić
On Saturday, 18. May 2013. 11.25.50 Djuro Drljaca wrote: Hello, @Ivan: no, you are wrong :P Well, not by far :) Another use case for what I suggested is this: 1) you create an activity and configure it to what you want its default state (or lets call it snapshot) to look like 2) you make

Default activity naming issues

2013-05-15 Thread Ivan Čukić
Hi all, I know everybody is busy with plasma2 (even I manage to find some time to play around with it, unfortunately not more than that), but there is one issue that I'd like to raise regarding the current release. The default name for the default activity 'Desktop' is causing a few problems.

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
glad these are the kinds of problems we face these days :) +10 Main Activity Thinking this would be better than the rest. (link to home could also be expected to create a symlink) Ch! ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
Welcome is nice, but again, not a real activity (link to Welcome and similar). Cheerio On 15 May 2013 11:49, Kevin Ottens er...@kde.org wrote: On Wednesday 15 May 2013 10:54:15 Aaron J. Seigo wrote: On Wednesday, May 15, 2013 09:59:40 Ivan Čukić wrote: The default name for the default

Re: Default activity naming issues

2013-05-15 Thread Ivan Čukić
Kevin Ahem... Sorry for the ramblings. :-) No need to apologize, sidetracking this theme to discuss nice things is not a crime :) I totally agree with the workflow you'd like to have (I'd like it as well :) ) Aaron If we want a meangingful default name At this time, until somebody brave

Re: Review Request 109164: set disable black listed applications

2013-02-26 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109164/#review28106 --- Ship it! Ship It! - Ivan Čukić On Feb. 26, 2013, 1:29 a.m

Re: [RFC] Invite Razor-Qt to next Workspaces Sprint

2013-02-17 Thread Ivan Čukić
Nepomuk in 4.10 being too slow. Whichever bottlenecks they may be, are most probably in our code. Not theirs. There are bottlenecks in nepomuk, but there are in V as well. Once upon a time, I did some benchmarks with sql (sqlite) and sparql (virtuoso/soprano) queries for the things that are

Re: Review Request 104417: Copy files instead of moving if parent dir is not writable

2013-02-09 Thread Ivan Čukić
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated Feb. 8, 2013, 10:59 p.m.) Review request for KDE Runtime, Plasma and Ivan Čukić. Description --- When adding an application

Re: Screen Edge handling in 4.11

2013-01-21 Thread Ivan Čukić
this looks certainly like an improvement, but maybe not in a specific case.. what about there is a fullscreen window (regardless it registered for an There are times when I desire my panel even if I have a fullscreen window (movie player or something). At the same time, IIRC some games use

Re: KActivities::Info::linkedResources

2013-01-15 Thread Ivan Čukić
great; we can use this in SLC in future releases... glad to see more async and less pause-inducing paths :) If the api freeze exception is not granted, we can call directly the service method from slc. The first idea is to make the method return nothing (and note that in the apidox).

Re: KActivities::Info::linkedResources

2013-01-15 Thread Ivan Čukić
yes, i understand the problem. the question is whether it is worthwhile to break code that uses it. once we have a release that contains both SLC and libkactivities that includes this fix, then the problem goes away. so it's about the short term, really. So, you're for the current version of

Re: KActivities::Info::linkedResources

2013-01-15 Thread Ivan Čukić
So, you're for the current version of SLC with the current kactivities for the reason of not breaking anything? yes, and i appreciate your understanding here. No problem, I'm anyhow always more for working on the future versions than fixing the previous ones :) usually we ship a

KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
Hi all, KActivities::Info::linkedResources() is an evil method that needs to go away - it retrieves a list of linked resources synchronously. Currently, it is used only in Share-Like-Connect, in a funny way - to check whether a specific resource is linked to the activity like this:

Re: KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
the method is indeed evil, not sure about breaking the released api tough That is why I'm asking - we have two evils - bad method vs semantic api change i think it should stay just a deprecated, or at most be a noop (modulo some kWarning) I'd like to go for a noop. now a thing i wonder,

Re: KActivities::Info::linkedResources

2013-01-14 Thread Ivan Čukić
if is an addition rather than changing something already there i think so, because in this case if the old method is nooped now, it would avoid potential new users for it (and potential performance drains) that could happen during 4.10. Monday, December 17, 2012: KDE SC 4.10 Hard API Freeze

Re: C++11 for kde-workspaces

2013-01-09 Thread Ivan Čukić
Mind that the 'CMake stuff' will need magic hands of our resident CMake experts before it goes anywhere near kdelibs. Ch! On 9 January 2013 17:17, Martin Gräßlin mgraess...@kde.org wrote: any further comments? If not I would like to see the CMake stuff go in very soon :-) If anyone wonders

Re: [KDE 4.10] Handling of Windows in Activities

2012-12-29 Thread Ivan Čukić
It is most probably an installation issue - that behaviour shouldn't have changed. You can file it on bugs.kde.org. Cheers On 29 December 2012 11:02, Sascha Manns sascha.ma...@open-slx.de wrote: Hello Listmates. just a question. Should i open a Bugreport for that? Or is that a feature?

Re: C++11 for kde-workspaces

2012-12-28 Thread Ivan Čukić
did you get any feedback that a distribution is unable to package? No. As mentioned on k-c-d before, gcc 4.5 is omnipresent in Linux distros, and clang 3.1 is the compiler of the next freebsd release. Cheerio, Ivan -- I don't really trust a sane person. -- Lyle Alzado

Re: C++11 for kde-workspaces

2012-12-27 Thread Ivan Čukić
On Thursday, 27. December 2012. 17.11.42 Martin Gräßlin wrote: Hi all, I want to suggest that we allow projects in kde-workspace to make use of C++11 as of the feature set already used in kactivities. Fully support the idea, with one small note. With kactivities already using C++11 we have

Re: [RFC] New (QML) Desktop Containment

2012-11-21 Thread Ivan Čukić
So, what do you think? :) I've never said it before (not that there was no reason for it :) ) but you're my hero now :) Guessing the visuals will need some fixing, but it is my future containment of choice! Ch! -- You know, there are many people in the country today who, through no fault

Re: Homerun sources and Plasma runners

2012-11-16 Thread Ivan Čukić
ehm.. it is So, it's in libplasma, I assume. Yes, though IMO it is generic enough to warrant breaking out of plasma into a separate library. (though, again, I'm a bit overzealous when library modularization is concerned :) ) Cheerio, Ivan -- So much complexity in software comes from

Re: Homerun sources and Plasma runners

2012-11-16 Thread Ivan Čukić
- can update matches - standardized favoriteIds what would have more than mimedata? (would still not require all runners to be bookmarkable, don't really want to have a bookmark of the result of the query 1+1=) Ths idea of mimedata support was made exactly for this, and for the ability

Re: QML style guide

2012-10-30 Thread Ivan Čukić
Personally I'm even against allowing it go in at all. It just clutters the code. It's not our task to cover up bugs in editors. If vim doesn't handle it, vim should be fixed. Also given that I'm not a vim user I would not know how many }} I have to place at a position or whether I have to

Re: QML style guide

2012-10-29 Thread Ivan Čukić
+1 I've been using a template found somewhere on the Qt-tubes, which goes like this property declarations signal declarations JavaScript functions object properties child objects states transitions I'd argue that property and signal declarations should be moved to the top - it is kinda a

Re: QML style guide

2012-10-29 Thread Ivan Čukić
other than object properties following functions, this looks nice. the example on that wiki page does not have signals, states or transitions which do indeed all need to be added. I agree. It might be nice to have the sections also with comment headers. Currently, my template has them like

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Ivan Čukić
word would be sufficient :) - Ivan Čukić On Oct. 22, 2012, 11:01 p.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-22 Thread Ivan Čukić
? (notably those from kdeartwork) - Ivan Čukić On Oct. 22, 2012, 10:26 p.m., Diego Casella wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999

Re: SLC and remote URLs

2012-10-19 Thread Ivan Čukić
then when we have the complete thing, it can be replaced by something that can do it by itself +1 I'd even like to have a 'send by e-mail dialogue' inside the popup as well, but, again, it would be silly to have that before the web account thingie. :) (essentially, what I'm thinking of is

SLC and remote URLs

2012-10-17 Thread Ivan Čukić
Hi, Currently, for http://something links, SLC doesn't enable the /share/ icon. For me, it should, and it should share the URL itself. Thoughts? -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the

Re: Top-rated documents for the task manager applet

2012-10-16 Thread Ivan Čukić
sounds for me like waiting for 4.11 and integrate it directly into it is the proper approach. Honestly, I don't see a reason for it to wait - the questions regarding QML Tasks are mostly: - will it be ready for 4.10? - if yes, is it in a public branch so that I can patch it instead of the

Re: Review Request: Activities support for Gwenview

2012-10-04 Thread Ivan Čukić
? Unless I am missing something (which is highly possible!) you should be able to implement the focus notification in DocumentView::setCurrent(bool). Ivan Čukić wrote: If it is in DocView, it will end up in the KPart as well, right? That would work for Gwenview, but would fail

Re: Review Request: Activities support for Okular

2012-10-04 Thread Ivan Čukić
- support for Share-Like-Connect applet. (and some trailing spaces auto-removal) Diffs (updated) - shell/CMakeLists.txt 1bf0b4f shell/shell.h 393d6c6 shell/shell.cpp 70e2e99 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić

Re: Review Request: Activities support for Okular

2012-10-04 Thread Ivan Čukić
shell/shell.h 393d6c6 shell/shell.cpp 70e2e99 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities support for Okular

2012-10-03 Thread Ivan Čukić
On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: Any reason this is at the Document level and not at the Part level? Feels to me it belongs more into the part than the document. Ivan Čukić wrote: This is really meant to be a document-link (Resource == Document most

Re: Review Request: Activities support for Gwenview

2012-10-03 Thread Ivan Čukić
://git.reviewboard.kde.org/r/106687/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities support for Calligra Suite

2012-10-03 Thread Ivan Čukić
/CMakeLists.txt 3653de2 libs/main/KoMainWindow.cpp 8eb8dff Diff: http://git.reviewboard.kde.org/r/106714/diff/ Testing --- Tested with flow, words and krita. Screenshots --- SLC http://git.reviewboard.kde.org/r/106714/s/753/ Thanks, Ivan Čukić

Re: Review Request: Activities support for Calligra Suite

2012-10-03 Thread Ivan Čukić
-mail. To reply, visit: http://git.reviewboard.kde.org/r/106714/#review19841 --- On Oct. 3, 2012, 5:12 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Activities support for Okular

2012-10-03 Thread Ivan Čukić
shell/CMakeLists.txt 1bf0b4f shell/shell.h 393d6c6 shell/shell.cpp 70e2e99 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
a057e82 core/document.cpp 143d598 core/document_p.h 91a5577 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request: Activities support for Gwenview

2012-10-02 Thread Ivan Čukić
://git.reviewboard.kde.org/r/106687/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities support for Gwenview

2012-10-02 Thread Ivan Čukić
13e41b0 lib/documentview/documentview.cpp 5451062 lib/documentview/documentviewcontainer.cpp ca86cb5 Diff: http://git.reviewboard.kde.org/r/106687/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel

Re: Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
-effect - support for Share-Like-Connect applet. (and some trailing spaces auto-removal) Diffs (updated) - CMakeLists.txt a057e82 core/document.cpp 143d598 core/document_p.h 91a5577 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić

Re: Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: Any reason this is at the Document level and not at the Part level? Feels to me it belongs more into the part than the document. Ivan Čukić wrote: This is really meant to be a document-link (Resource == Document most

Re: Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
On Oct. 2, 2012, 6:13 p.m., Albert Astals Cid wrote: Any reason this is at the Document level and not at the Part level? Feels to me it belongs more into the part than the document. Ivan Čukić wrote: This is really meant to be a document-link (Resource == Document most

Re: Review Request: Activities support for Gwenview

2012-10-02 Thread Ivan Čukić
for Share-Like-Connect applet. Diffs (updated) - CMakeLists.txt a73e4d3 app/CMakeLists.txt e039198 app/viewmainpage.cpp 055cd2a Diff: http://git.reviewboard.kde.org/r/106687/diff/ Testing --- Yes Thanks, Ivan Čukić ___ Plasma

Re: Review Request: Activities support for Okular

2012-10-02 Thread Ivan Čukić
/shell.cpp 70e2e99 CMakeLists.txt a057e82 shell/shell.h 393d6c6 Diff: http://git.reviewboard.kde.org/r/106685/diff/ Testing --- yes Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Behavior on systray icon clicking

2012-09-25 Thread Ivan Čukić
for closing windows, not clicking systray icons. While I agree in principle, pretty much none of the apps behave this way - Amarok, Clementine, Quassel... - if you click its systray icon, it opens, clicking it again it closes. Even Klipper, which opens just a QMenu though, behaves I'd go for

Re: IRC meeting summary

2012-09-13 Thread Ivan Čukić
This reminds me of something I forgot to mention in the IRC meeting. The D-BUS bindings in kwin and plasma effectively provide a way to circumvent the security features in wayland. This is something that we need to think about going forward. We need this information in kwin (active window

Re: IRC meeting summary

2012-09-12 Thread Ivan Čukić
Damn... I missed it. A.S. We still have two mailing lists that we use for the same thing? qml desktop containment would be great too The first thing I'd like (with my designer hat on) is to be able to, when snapping applets to one another (sebas mentioned it), the snapped applets would get a

Re: IRC meeting summary

2012-09-12 Thread Ivan Čukić
idea not bad, it can be a bit tricky (what if the applets have a different size? how the handles would work? when to split again?) That would need to be well-thought in advance. I'd still see them as separate applets, so separate handles, but only to merge the edges. what was mentioned is

Re: KActivities library optimizations

2012-09-06 Thread Ivan Čukić
more libraries means harder to use (have to know the more about the design to know which library to use and when). i think a dep on nepomuk is just fine as long as nepomuk's depencies are limited .. if they aren't, then it can be an issue. The reason why I disagree are the apps that just

Re: [kactivities] src/lib: docs say it is deprecated, mark it as such

2012-09-05 Thread Ivan Čukić
On Wednesday, 5. September 2012. 16.46.42 Aaron Seigo wrote: Git commit 464f13b72949d4dc547e88144a4b089c6939f01e by Aaron Seigo. Committed on 05/09/2012 at 16:46. Pushed by aseigo into branch 'master'. docs say it is deprecated, mark it as such M +1-1src/lib/info.h

Re: KActivities library optimizations

2012-09-05 Thread Ivan Čukić
Without the blocking. the hell would break loose - it wouldn't be backwards compatible and every kactivities client would need to be patched. according to lxr, that is: * plasma-desktop shell * activities DataEngine * activities Runner * powerdevil * plasma-mobile shell * active

Re: KActivities library optimizations

2012-09-05 Thread Ivan Čukić
We need data models for it sounds good ... Now, since the models library (in order to skip data retrieval from kamd via d-bus*) will need to be linked to nepomuk (linked resources) and qtsql (for detailed even logs), what do you think to make it a separate library -

Re: KActivities library optimizations

2012-09-04 Thread Ivan Čukić
sounds a lot less maintainable and in the long run less re-usable. i also I agree, after some investigation, shared memory is a bit tedious to work with. wonder if using shared memory wouldn't simply move, rather than remove, lock contention for data population, etc. There /would/ be less

Re: KActivities library optimizations

2012-09-04 Thread Ivan Čukić
one thing i'm not a fan of with the new Consumer approach is that it is impossible to know whether the code will block or not. it does a pre-fetch and then cleverly blocks only if it hasn't received a reply yet. which means there is no way to guarantee async behaviour when desired. as long as

KActivities library optimizations

2012-09-03 Thread Ivan Čukić
Hi, The latest master of libkactivities caches and pre-fetches some stuff like the currentActivity, list of activities, list of running activities, activity names and icons, to minimise the amount of d-bus related locks*. What do you think of the idea to go one step further, and instead of

Re: Review Request: Config cleanup on removeActivity

2012-08-27 Thread Ivan Čukić
On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: Ship It! Which branch is this, since it is not master as specified? - Ivan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Config cleanup on removeActivity

2012-08-27 Thread Ivan Čukić
On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: Ship It! Ivan Čukić wrote: Which branch is this, since it is not master as specified? (in master, VD switcher is moved into a separate plugin) - Ivan

Re: Activities KCM

2012-08-23 Thread Ivan Čukić
Thanks for the suggestions. First, lets start with the feature requests. 1. Which applications start automatically with a given activity. As Marco said (and I agree), this shouldn't be for per-activity settings. But I do think we should have this feature. 2. Which activities are started

<    3   4   5   6   7   8   9   10   11   12   >