D29226: [ksmserver] Use CommandLauncherJob for restoring applications

jbbgameich added a comment. Did you possibly forget to commit the changes to the header file? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29209: PlaceholderMessage: Remove Plasma units usage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8473aad62ed4: PlaceholderMessage: Remove Plasma units usage (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29209?vs=81263=81274

D29209: PlaceholderMessage: Remove Plasma units usage

jbbgameich created this revision. jbbgameich added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Probably this was forgotten when importing the new component into Kirigami

D28468: Add property initializer support to PagePool

This revision was automatically updated to reflect the committed changes. Closed by commit R169:bb5a6c13ec0b: Add property initializer support to PagePool (authored by masonm, committed by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D26956: Remove export header from static install

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:0aa162f2e838: Remove export header from static install (authored by masonm, committed by jbbgameich). REPOSITORY

D27837: Fix about page with Qt 5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6223aa661c61: Fix about page with Qt 5.15 (authored by jbbgameich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27837?vs=78200=78201#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST

D27837: Fix about page with Qt 5.15

jbbgameich updated this revision to Diff 78200. jbbgameich added a comment. rebase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27837?vs=76948=78200 BRANCH about-page-qt-515 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27837

D26956: Remove export header from static install

jbbgameich added a comment. @apol is your question answered now / can I land this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart, apol Cc: jbbgameich, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D28148: Fix broken paths in kirigami.qrc.in

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9949457f31ba: Fix broken paths in kirigami.qrc.in (authored by masonm, committed by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27843: Port to new QML Connections syntax

jbbgameich created this revision. jbbgameich added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Can be landed once Frameworks can depend on Qt 5.14 TEST PLAN Everything still

D27838: Port to new QML Connections syntax

jbbgameich updated this revision to Diff 76950. jbbgameich added a comment. Fix syntax error REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27838?vs=76949=76950 BRANCH 5.15-connections-syntax (branched from master) REVISION

D27838: Port to new QML Connections syntax

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes deprecation warnings with Qt 5.15 TEST PLAN No deprecations warnings, everything still works REPOSITORY R858 Qt

D27837: Fix about page with Qt 5.15

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY UrlButton exists since since org.kde.kirigami 2.6, before the file was resolved from the current directory but doesn't

D25989: Don't build and install app templates on android

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3bc41934f9d6: Dont build and install app templates on android (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25989?vs=71517=71518

D25989: Don't build and install app templates on android

jbbgameich updated this revision to Diff 71517. jbbgameich added a comment. Follow suggestion REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25989?vs=71516=71517 BRANCH android-no-app-templates (branched from master) REVISION DETAIL

D25989: Don't build and install app templates on android

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY They increase apk sizes and are really not required in an apk. REPOSITORY R169 Kirigami BRANCH

D25175: FormLayout: Fix label height if wide mode is false

This revision was automatically updated to reflect the committed changes. Closed by commit R169:839983aa3604: FormLayout: Fix label height if wide mode is false (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69355=69356

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich updated this revision to Diff 69355. jbbgameich edited the test plan for this revision. jbbgameich added a comment. Use implicit height instead of font metrics REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69353=69355 BRANCH

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich added inline comments. INLINE COMMENTS > mart wrote in FormLayout.qml:277 > fontmetrics is the default font height, and this being an heading may be more > (when is heading) > does it work if instead you do here > return implicitHeight ? It works but produces a slightly smaller

D25109: Make it impossible to open the progress view sheet multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R134:762a36fcd96b: Make it impossible to open the progress view sheet multiple times (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D25175: FormLayout: Fix label height if wide mode is false

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY previously the height of the label was based on the content's height. However this doesn't work in non wide mode. With

D25109: Make it impossible to open the progress view sheet multiple times

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY It used to be possible after resizing the window so narrowly that the drawer switched into modal mode and back to its

D24451: metadata: Add form factors to make kcm appear on mobile again

jbbgameich added a comment. Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 branch back into master? REPOSITORY R115 Plasma Audio Volume Applet BRANCH mobile (branched from master) REVISION DETAIL https://phabricator.kde.org/D24451 To: jbbgameich,

D24451: metadata: Add form factors to make kcm appear on mobile again

This revision was automatically updated to reflect the committed changes. Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm appear on mobile again (authored by jbbgameich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24451?vs=67400=67403#toc REPOSITORY R115

D24451: metadata: Add form factors to make kcm appear on mobile again

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Seems to be required to make the kcm visible in plasma-settings REPOSITORY R115 Plasma Audio Volume Applet BRANCH

D23897: Port mobile_wifi kcm to newer APIs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs (authored by jbbgameich). REPOSITORY R116 Plasma Network

D23897: Port mobile_wifi kcm to newer APIs

jbbgameich added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23897 To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23941: Compensate smaller icon sizes on mobile in the ActionButton

This revision was automatically updated to reflect the committed changes. Closed by commit R169:eb364c963630: Compensate smaller icon sizes on mobile in the ActionButton (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23941: Compensate smaller icon sizes on mobile in the ActionButton

jbbgameich added a comment. I believe the new icon sizes were intentional for the drawer and own uses of Kirigami.Icon, but they influence the size of the whole ActionButton as well making it rather hard to click on a touch screen. Probably Camilo tested his changes only with mauikit which

D23941: Compensate smaller icon sizes on mobile in the ActionButton

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY They became smaller since D22572 . This should restore the intended state. REPOSITORY

D23897: Port mobile_wifi kcm to newer APIs

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. jbbgameich requested review of this revision. REVISION SUMMARY - Controls.Button can display icons on its own now - Use kcm.push() and kcm.pop() -

D18860: Add comment / description to the translations kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R120:59b1f923be29: Add comment / description to the translations kcm (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22654: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit R169:00ccd9019816: Fix typo (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22654?vs=62328=62334 REVISION DETAIL

D22654: Fix typo

jbbgameich updated this revision to Diff 62328. jbbgameich added a comment. Fix another occurence REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22654?vs=62324=62328 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22654 AFFECTED FILES

D22654: Fix typo

jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY leftLargin -> leftMargin REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22654

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 61958. jbbgameich added a comment. Update comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=61930=61958 BRANCH arcpatch-D18860 REVISION DETAIL https://phabricator.kde.org/D18860

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08a802656df5: kcms: translations: use availableDomainTranslations from plasmashell instead of… (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 61930. jbbgameich added a comment. Update description once again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=51321=61930 BRANCH arcpatch-D18860 REVISION DETAIL

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY The kcm might be used with different settings apps like plasma-settings, in that case systemsettings is not installed.

D18860: Add comment / description to the translations kcm

jbbgameich added a comment. ping REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21029: UpdatesPage: Don't try to translate version numbers

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes a I18N_ARGUMENT_MISSING warning in the ui that appears sometimes while discover is looking for updates. TEST PLAN

D20675: LoadingPage: Use Kirigami.Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f061345ad6fe: LoadingPage: Use Kirigami.Heading (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20675?vs=56565=56568

D20674: Word wrap "No backends found" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:4d644303be08: Word wrap No backends found error message (authored by jbbgameich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D20675: LoadingPage: Use Kirigami.Heading

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Unifies the look of the loading message with the other messages in discover. TEST PLAN Font size is correct when

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to convert this revision into a proper arc diff I can land failed, since this was initially created by pasting `git diff` output. If possible, can you land the patch? REPOSITORY R134 Discover

D18971: UpdatesPage: Fix icon sizing on small screens

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. Thanks, done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. Yes, this looks like the same problem. Since the UpdatesPage width is being decreased when opening the "More information", it's the same effect as on a phone screen where the width is always that small. Can / should I somehow tag this patch so it marks the bug

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich created this revision. jbbgameich added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY On Small screens (e.g phones), not all list items have the same height,

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 51321. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=51210=51321 REVISION DETAIL https://phabricator.kde.org/D18860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma Cc: apol, plasma-devel,

D18860: Add comment / description to the translations kcm

jbbgameich created this revision. jbbgameich added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY Fixes inconsistency with other kcms TEST PLAN comment is displayed in