D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R31:0eaf762705d8: Drop QWindow and explicit devicePixelRatio usage for ComboBox (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28725?vs=79773=80071

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80070. broulik added a comment. - Remove unrelated changes REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80011=80070 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28706: Restore old Audio prototype after exportFunction

This revision was automatically updated to reflect the committed changes. Closed by commit R856:08468773f1fe: Restore old Audio prototype after exportFunction (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28706: Restore old Audio prototype after exportFunction

broulik reclaimed this revision. broulik added a comment. This revision is now accepted and ready to land. Apparently there's no good alternative. In the future might make sense to refactor this to use a `moz-extensions`

D28744: Rewrite of the global shortcuts kcm

broulik added a comment. Very nice! I really like the default shortcuts with checkboxes with additional ones to the right. INLINE COMMENTS > filteredmodel.cpp:40 > +const QModelIndex index = sourceModel()->index(source_row, 0, > source_parent); > +bool displayMatches = >

D28806: Provide light icon for dark mode via theme_icons

This revision was automatically updated to reflect the committed changes. Closed by commit R856:269da15cf9b4: Provide light icon for dark mode via theme_icons (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28806: Provide light icon for dark mode via theme_icons

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I recall we originally didn't do it when Noah added these icons as

D28791: Manually merge stored and default settings

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f4aa77a29780: Manually merge stored and default settings (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28791?vs=80006=80018#toc REPOSITORY R856 Plasma Browser

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80011. broulik added a comment. - Closes after click REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80010=80011 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80010. broulik added a comment. - Also remove when closed REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80009=80010 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When we get a URL back from the share provider, let clicking the notification open it.

D28791: Manually merge stored and default settings

broulik updated this revision to Diff 80006. broulik added a comment. - if/else REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28791?vs=8=80006 REVISION DETAIL https://phabricator.kde.org/D28791 AFFECTED FILES

D28791: Manually merge stored and default settings

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One can pass a default Object to `storage.get()` which will be used for keys that don't

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik updated this revision to Diff 79818. broulik added a comment. - Also change tooltip Note to future me: put this logic in a shared location REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28740?vs=79816=79818 REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. That is exactly what it should do and it did originally but I just noticed it still showed a date, presumable for leap year reasons. With this patch no date is shown again when "until turned off" is chosen. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When setting "until turned off" it effectively sets it to today in a year. Now with leap year

D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

broulik created this revision. broulik added reviewers: Plasma, davidre, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's not done anywhere and breaks rendering the `ComboBox` on high dpi.

D28705: Don't consider player gone when it only got temporarily added by us

This revision was automatically updated to reflect the committed changes. Closed by commit R856:f48989b7936f: Dont consider player gone when it only got temporarily added by us (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

This revision was automatically updated to reflect the committed changes. Closed by commit R856:5a5369a0cb40: [Purpose Plugin] Detect cancelling the prompt more reliably (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28709: Implement executeScript for Firefox

broulik added a comment. So, back to my export function patch? :/ REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28709: Implement executeScript for Firefox

broulik added a comment. I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the style sheet... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

broulik updated this revision to Diff 79754. broulik added a comment. - Use `QMetaObject::invokeMethod` with lambda. It's older than I thought it was :) REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28719?vs=79753=79754 REVISION

D28719: [Purpose Plugin] Detect cancelling the prompt more reliable

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `aboutToHide` is emitted before an action is triggered and `activeAction()` is the action

D28709: Implement executeScript for Firefox

broulik added a comment. Try https://open.spotify.com/browse/featured but I believe you can't play anything without an account. Maybe you could upload an ogg file to KDE nextcloud and try with that. REPOSITORY R856 Plasma Browser Integration BRANCH ffeval REVISION DETAIL

D28705: Don't consider player gone when it only got temporarily added by us

broulik added a comment. Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not working since when the player is gone we clear media session actions (not sure if that is someting we should do though) REPOSITORY R856 Plasma Browser

D28706: Restore old Audio prototype after exportFunction

broulik abandoned this revision. broulik added a comment. Superseded by D28709 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28706 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, Orage, LeGast00n,

D28709: Implement executeScript for Firefox

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thank you so much! I tested with all the players from D24870 and it works really well. REPOSITORY R856 Plasma Browser Integration BRANCH

D28709: Implement executeScript for Firefox

broulik added a comment. At a glance this seems to be working marvellously. Even media session API works in Spotify now REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n,

D28709: Implement executeScript for Firefox

broulik added a comment. Try whether it works on Spotify web player and nextcloud - they have a content security policy which prevents adding custom script tags REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc:

D28705: Don't consider player gone when it only got temporarily added by us

broulik added a comment. It worked on Chrome, and the properties can be accessed from the same context. It's just that the mutation.removedNodes loop above which is in content script cannot access those JS properties, so I had to change it, so it can. REPOSITORY R856 Plasma Browser

D28707: Show purpose context menu only when enabled

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Check whether the extension is supported and enabled. Unfortunately, I removed

D28706: Restore old Audio prototype after exportFunction

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `exportFunction` doesn't carry over a prototype, nor can I assign a non-function

D28705: Don't consider player gone when it only got temporarily added by us

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We temporarily add players created by JS to the DOM so we can access them from the

D25569: Also overwrite document.createElement using exportFunction

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c2fba76125f4: Also overwrite document.createElement using exportFunction (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25569?vs=70439=79717#toc REPOSITORY R856

D28703: Make KAccess a regular startup application

broulik created this revision. broulik added reviewers: Plasma, Plasma Accessibility. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also ports it away from `KToolInvocation`. I don't really see why it would

D28616: Split KWin startup out of KSMServer

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f6e34fe0d652: Merge branch broulik/ksmserver_no_wm (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28616?vs=79558=79705#toc REPOSITORY R120 Plasma Workspace CHANGES

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a2ebeeb65717: Port Konsole and Kate runners and dataengine away from KToolInvocation (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D28698: Save unneeded DBus roundtrip

broulik added a comment. Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik,

D28684: Kate Runner: Implement drag and drop for sessions

broulik added a comment. What's your usecase for this? Not sure I like making assumptions on how and where those sessions are stored. I'd rather have a way to tell Kate to create a desktop file for them, or a button in its UI or something. REPOSITORY R114 Plasma Addons REVISION DETAIL

D28686: [Battery Monitor] Choose better wording

broulik added a comment. "Life remaining" sounds as if it blows up any minute. Perhaps "Remaining time"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28688: Document Kirigami::Icon

broulik added a comment. Generally +1 on better docs INLINE COMMENTS > icon.h:53 > +/** > + * The name of a fallback icon to load from the icon theme when the > `source` > + * cannot be found. Mention `Default is "unknown"` > icon.h:58 > + * > + * @note This will only

D28693: Replace old notification when new notification for connection appears

broulik added a comment. +1 I've been wanting to do exactly this forever INLINE COMMENTS > notification.cpp:431 > + > +if (m_notifications.contains(connectionId)) { > +notify = m_notifications[connectionId]; Avoid double look-up. `QHash` gives you a null value when not existing,

D28666: Refactor for loops

broulik added a comment. +1 for the `.some()` use -1 on the convoluted `Array.prototype` things, especially when chained. INLINE COMMENTS > Action.qml:156 > readonly property var visibleChildren: { > -var visible = []; > -var child; > -for (var i in children) {

D28646: [Notifications] Sort popups ascending

This revision was automatically updated to reflect the committed changes. Closed by commit R120:55400729c478: [Notifications] Sort popups ascending (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28646?vs=79554=79604 REVISION

D28614: Add better player tab crash handling

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b50818455f89: Add better player tab crash handling (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28614?vs=79454=79602

D28657: [Notifications] Report roleNames in the relevant places

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY QML needs it on the model it uses (`Notifications`) where they used to be but GammaRay seems to

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik planned changes to this revision. broulik added a comment. Apparently this causes all kinds of breakages :0 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28649 To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28650: [Notifications] Don't reverse() Array

broulik created this revision. broulik added reviewers: Plasma, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This mutates the source array. In practice actions don't really change in existing

D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Now that we can depend on Qt 5.14 TEST PLAN Still get both jobs and notifications. Can still

D28616: Split KWin startup out of KSMServer

broulik updated this revision to Diff 79558. broulik added a comment. - Implement saveCurrentSession - Clean up states and some comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28616?vs=79461=79558 REVISION DETAIL

D28646: [Notifications] Sort popups ascending

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ensures that newer notification popups don't push old ones out. Some applications are

D28614: Add better player tab crash handling

broulik added a comment. Waiting for @cblack since they were who mentioned this issue REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

Re: Looking for GSoC 2020 mentor

Am 06.04.20 um 11:34 schrieb Marco Martin: in general the idea is nice.. tough a concern is that the theme switching is a quite expensive operation and quite abrupt and not gradual.. it may interrupt the work of the user in an unexpected way when the switch is done Yeah, I would like to

D28616: Split KWin startup out of KSMServer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This patch removes startup of window manager out of KSMServer. It also removes the usage of SM

D28286: [Task Manager] Port backend to ApplicationLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fa8e49b3be08: [Task Manager] Port backend to ApplicationLauncherJob (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28347: Port services and shell runner away from KRun

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6e660cf92d7c: Port services and shell runner away from KRun (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28347?vs=78840=79455

D28614: Add better player tab crash handling

broulik added a comment. > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? I believe whenever a player starts playing again, it is propagated through MPRIS again. The `playerGone` handling is no different

D28517: Send notification when screencasting fails

broulik added inline comments. INLINE COMMENTS > jgrulich wrote in screencaststream.cpp:376 > Does it need to be specified if you have Urgency=Normal set in the notifyrc > file? I believe if you don't specify it, it will use the default urgency, > which will be taken from the notifyrc file.

D28614: Add better player tab crash handling

broulik created this revision. broulik added reviewers: Plasma, fvogt, cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There is unfortunately no dedicated signal for this (the process API is for dev

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. > Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :) You can't move KRunner around, though, either, and the number of results shown is based on screen size and easily overflows the screen when it is free

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. This breaks KRunner's shadow against a top panel: F8219543: Screenshot_20200406_093346.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #plasma, apol Cc:

D28526: [notifications] Hide close/configure buttons on mobile

broulik added a comment. I think we also want to stop the animation/circle thing, too? Maybe shove all of it in a loader? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28526 To: nicolasfella, #plasma, #plasma:_mobile Cc: broulik, plasma-devel, Orage,

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > user.cpp:179 > +{ > +QtConcurrent::run([=]() { > +m_dbusIface->SetUserName(mName).waitForFinished(); No, just no. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg,

D28517: Send notification when screencasting fails

broulik added inline comments. INLINE COMMENTS > screencaststream.cpp:372 > +const auto emitFailureNotification = [](const QString ) { > +KNotification *notification = new > KNotification(QStringLiteral("notification"), KNotification::CloseOnTimeout | >

D28154: Add users KCM

broulik added a comment. That gallery comes from user manager right now, doesnt it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella,

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

broulik updated this revision to Diff 79137. broulik edited the test plan for this revision. broulik added a comment. - Use new constructor introduced in D28515 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead use `CommandLauncherJob`. Also set `desktopFileName` for nicer startup feedback

D28509: RFC: [libnotificationmanager] introduce the notification watcher

broulik added inline comments. INLINE COMMENTS > org.freedesktop.Notifications.xml:55 > > + > + Please don't put that on the fdo service > notificationwatcher.cpp:45 > +); > +QDBusConnection::sessionBus().call(msg, QDBus::NoBlock); > +} Do we not want to check if that

D28485: Move QMimeData registration back to where it belongs

This revision was automatically updated to reflect the committed changes. Closed by commit R112:92ecad19708d: Move QMimeData registration back to where it belongs (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28485?vs=79056=79100

D28485: Move QMimeData registration back to where it belongs

broulik updated this revision to Diff 79056. broulik added a comment. - use same 0 major as everything else Apparently doesn't matter REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28485?vs=79055=79056 REVISION DETAIL

D28485: Move QMimeData registration back to where it belongs

broulik updated this revision to Diff 79055. broulik retitled this revision from "Register QMimeData" to "Move QMimeData registration back to where it belongs". broulik edited the summary of this revision. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE

D28485: Register QMimeData

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures drag and drop of results works again. BUG: 418109 FIXED-IN: 5.18.5 TEST PLAN

D28481: Revert "Fix build with Qt 5.15"

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R122 Powerdevil BRANCH arcpatch-D28481 REVISION DETAIL https://phabricator.kde.org/D28481 To: apol, broulik Cc: broulik, plasma-devel, Orage, LeGast00n,

D28481: Revert "Fix build with Qt 5.15"

broulik added a comment. Why? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28481 To: apol Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D28473: BookmarksRunner: Early return and formatting

broulik added a comment. > Should compile and work exactly as before. Please always test `QRegularExpression` migration, I've seen just too many regressions when this wasn't done carefully INLINE COMMENTS > firefox.cpp:171 > +/* This allows the user to specify a profile database */

D28465: [Categories Page] Use BasicListItem

broulik added a comment. > Tablet mode spacing should just be added into BasicListItem itself Agreed. I was surprised it didn't actually come from it but was done here explicitly REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28465 To: broulik,

D28465: [Categories Page] Use BasicListItem

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The delegate doesn't have its own appearance anymore, so just use the default one. TEST PLAN

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

This revision was automatically updated to reflect the committed changes. Closed by commit R120:492301406a46: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28462: [KCM] Add color state probe to allow system settings to display current default state

broulik added a comment. You reckon we should do a simple base class that just does `settings->isDefaults()` since that will be quite a common thing? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28462 To: bport, #plasma, ervin, meven, crossi, hchain Cc:

D28461: In sidebar mode show if a module is in default state or not

broulik added a comment. Please include screenshots when you do UI changes. INLINE COMMENTS > CategoriesPage.qml:207 > + > +width: 16 > +height: 16 `Kirigami.Units.iconSizes.small` and elsewhere Why do you need this wrapper `Item`, though?

D28458: Bugfix ConverterRunner

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R114 Plasma Addons BRANCH converter_fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D28458 To: alex, broulik Cc: plasma-devel, Orage,

D27166: Refactor converter runner

broulik added a comment. I'm seeing another issue: everything with a slash is now interpreted as unit of volume, even just calculations: F8207700: Screenshot_20200331_091752.png REPOSITORY R114 Plasma Addons REVISION DETAIL

D28435: [System Tray] Update effective status on model insertion

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d3b6e8f0a18: [System Tray] Update effective status on model insertion (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28354: [applets/digital-clock] Fix calendar events not being shown at first

broulik added inline comments. INLINE COMMENTS > CalendarView.qml:154 > > +function dateEquals(date1, date2) { > +var values1 = [ Can't you do `date1.getTime() == date2.getTime()` (`time` returns the msecs since epoch) REPOSITORY R120 Plasma Workspace

D27701: [ComboBox] Use transparent dimmer

broulik added a comment. Affects any `ComboBox` in a KCM for me, that isn't in a `Popup`: Fonts KCM, GTK config on Styles KCM (not the one in the fine tuning popup), the filter in colors KCM, ... REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D28435: [System Tray] Update effective status on model insertion

broulik created this revision. broulik added reviewers: Plasma, kmaterka, davidre, ahmadsamir. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Started Konversation, has proper effective status of passive again.

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

broulik updated this revision to Diff 78891. broulik retitled this revision from "[Colors KCM] Use Kirigami.SearchField" to "[Colors / Desktop Theme KCM] Use Kirigami.SearchField". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a

D28314: Allow setting separate corner radii for ShadowedRectangle

broulik added a comment. Cool INLINE COMMENTS > shadowedrectangle.h:157 > +private: > +float m_topLeft = -1.0; > +float m_topRight = -1.0; How about using NaN to define "not set"? though you can't have negative radius, so probably fine REPOSITORY R169 Kirigami REVISION DETAIL

Monday Meeting Notes Week 14 (2020-03-30)

Week 14 of 2020 Plasma meeting notes from 2020-03-30: Hope you're all doing well and staying at home. DavidRedondo * I am continuing work for coloring icons in the correct colors * Patch for breeze kdecoration now up on phab: https://phabricator.kde.org/D28330 * IconItem

D26934: KCM/Autostart Add a model to separate logic from UI

broulik added inline comments. INLINE COMMENTS > meven wrote in autostart.cpp:210 > ? rows inserted gives you a range of [first,last] which was added > meven wrote in autostart.cpp:182 > You mean I should use open/finished right ? Yes. It then also needs to set a transient parent and window

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:43 > +if (CMAKE_SYSTEM_NAME STREQUAL "Linux") > +install(TARGETS kde-systemd-start-condition DESTINATION > ${KDE_INSTALL_BINDIR}) > +endif () Do we rather want it in libexec since it's not meant to be run by the user?

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

broulik created this revision. broulik added reviewers: Plasma, leinir, davidre. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY GHNS Quick Button signals `changedEntriesChanged` initially even if nothing

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik updated this revision to Diff 78842. broulik added a comment. This revision is now accepted and ready to land. - Adjust to API change in `KServiceAction` - Drop linkage of `KIOWidgets` in favor of `KIOGui` (though `KIOFileWidgets` probably implies it anyway) REPOSITORY R119

D28347: Port services and shell runner away from KRun

broulik updated this revision to Diff 78840. broulik added a comment. - Adjust to API change in `KServiceAction` - Also don't use now deprecated `QUrl::queryItemValue` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28347?vs=78651=78840 REVISION

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik planned changes to this revision. broulik added a comment. Will rebase on pending API change in D28268 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni,

D28347: Port services and shell runner away from KRun

broulik planned changes to this revision. broulik added a comment. Will rebase on pending API change in D28268 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28347 To: broulik, #plasma, dfaure Cc: plasma-devel, Orage,

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson,

D26934: KCM/Autostart Add a model to separate logic from UI

broulik added inline comments. INLINE COMMENTS > autostart.cpp:182 > +AddScriptDialog addDialog(this); > +if (addDialog.exec() != QDialog::Accepted) { > +return; In preparation for a move to QML, can we please not `exec()` > autostart.cpp:192 > +QTreeWidgetItem* widgetItem

D28347: Port services and shell runner away from KRun

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Use `ApplicationLauncherJob` and `CommandLauncherJob`. Also, for services runner pass a

D28338: [PowerDevil Runner] Remove unused KRun include

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62a7e1c464e4: [PowerDevil Runner] Remove unused KRun include (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28338?vs=78638=78642

<    1   2   3   4   5   6   7   8   9   10   >