Re: Move Plasma Dialer and Spacebar to Plasma release

On 22.08.24 13:29, Jonathan Riddell wrote: Plasma Dialer depends on KWin and Plasma Wayland Protocols, Spacebar (SMS messaging app) similarly depends on libplasma, so it would seem sensible to have these as part of Plasma releases. Where does Spacebar depend on libplasma? Repo freeze is in

Re: QtWayland 6.7.2 packaging recommendation

On 09.07.24 11:14, Vlad Zahorodnii wrote: Hello, QtWayland 6.7.2 contains a regression with regards to initializing the popup parent, which can result in the plasmashell process getting killed in some circumstances (e.g. https://bugs.kde.org/show_bug.cgi?id=489259). The regression has been fixed

Plasm 6.1 Kickoff Meeting notes

# Plasma 6.1 kickoff meeting notes ## 6.0 retrospective Generally well received# Plasma 6.1 kickoff meeting notes ## 6.0 retrospective Generally well received Problems: - Neon's rollout was/still is bumpy. Needs retrospective from Neon developers on what happend - Nvidia:     - Missing config

Monday meeting notes for 15/01/2024

Marco: fixed wheel to switch desktop action in folderview looking at why long touchscreen tap on the desktop crashes plasma, still no clue made an upstream merge request for layer shell to reserve edges also for corner-aligned panels refactored kirigami.Page to have global toolbars outside of it

Re: more betas / shorter windows?

On 12/18/23 18:42, Harald Sitter wrote: With the second p6 beta sneaking up on us I've been pondering the beta experience... I can't help but think that the windows we've chosen were too long. At least from a crash tracking POV most of the crash reports we get from !neon are either of unreasonab

Re: QML: a packagers nightmare. Assistance please.

On 11/8/23 17:11, Scarlett Moore wrote: While I have everyone's attention. The part that is getting me ( and our linters ) is qml installation paths seem all over the place For example plasma-framework we have org.kde.plasma.plasmoids which I read in the docs is "identified" qml which states it

Re: plasma-framework

On 11/7/23 12:22, Jonathan Esk-Riddell wrote: On Sun, Nov 05, 2023 at 12:59:28PM +0100, Friedrich W. H. Kossebau wrote: kactivities and kactivities-stats: please consider proper de-KF-ication now Hi, with plasma-framework, kactivities and kactivities entering the Plasma product bundle, I assum

Applet config dialog changes

Hi, I have an open MR that changes how applet's config UI integrates with the container UI: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1675 See https://invent.kde.org/plasma/plasma-desktop/-/issues/99 for some context. The benefits would not only be somewhat cleaner internals

Re: print-manager and wacomtablet to Plasma

On 11/1/23 00:28, Nicolas Fella wrote: On 10/31/23 23:23, Albert Astals Cid wrote: El dimarts, 31 d’octubre de 2023, a les 20:43:47 (CET), Jonathan Riddell va escriure: As discuccsed in Plasma meeting and just now with KDE gear release spods, Plasma would like to take over releases of print

Re: print-manager and wacomtablet to Plasma

On 10/31/23 23:23, Albert Astals Cid wrote: El dimarts, 31 d’octubre de 2023, a les 20:43:47 (CET), Jonathan Riddell va escriure: As discuccsed in Plasma meeting and just now with KDE gear release spods, Plasma would like to take over releases of print-manager and wacomtablet. This means renumbe

Re: Plasma 6 alpha modules list

In https://mail.kde.org/pipermail/release-team/2023-June/013081.html I proposed to move print-manager and wacomtablet from Gear to Plasma. Nobody objected so I guess we can move forward with this? On 10/27/23 17:39, Jonathan Riddell wrote: 12 days to go until the first alpha release, it's time t

[Powerdevil] [Bug 365100] Pressing the physical power button is ignored with certain hardware

https://bugs.kde.org/show_bug.cgi?id=365100 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de --- Comment #12 from

Renaming Plasma's applications.menu file

Hi, In KF5 KService ships /etc/xdg/menus/applications.menu, our menu definition according to https://specifications.freedesktop.org/menu-spec/menu-spec-1.0.html Since this will cause a conflict between KF5 and KF6 (and potentially other desktop environments) for Plasma 6 I'm planning to: - Move

Monday meeting notes for 09/10/2023

Meven: I am written the kcm wallpaper, it is progressing, it updates the any screen wallpaper and display the screen layout A bunch of things are left to do, hopefully will have a draft later this week And I will be merging the dbus backend redstrate: not much, just a leftover from last week: h

Monday meeting notes for 25/09/2023

redstrate: I did some accessibility-related work, some of which is already merged: I fixed a kaccess bug causing some options to become out of sync (https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1736). Redone the appearance of the accessibility KCM, so it looks a bit nicer. (http

KF6/Plasma 6 packaging notes

Hi, I'm happy that more and more distros are looking into packaging an experimental KF6/Plasma 6 session. Since there are some non-obvious things to keep in mind while doing that I started collecting some packaging notes/information in https://community.kde.org/Plasma/Plasma_6#Packaging_notes. I

Porting aid place for Plasma stuff?

Hi, on several occasions we found API in Frameworks that we would like to remove, but is still used in more than one place in Plasma and it may not be feasible to port all of these usages in time for (Frameworks) 6.0. There's a few things that fall in this category that come to my mind: - KWayl

Re: Remaining plasma-framework KF6 tasks

Am 09.07.23 um 12:56 schrieb Nicolas Fella: Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them

Remaining plasma-framework KF6 tasks

Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them, i.e. determine whether we consider them done, whether

Moving print-manager and wacomtablet to Plasma

Hi, print-manager and wacomtablet are in a somewhat odd place currently. They provide integration of (printers|tablets) into Plasma via KCMs, kded modules, plasmoids etc, to the point where they are not that useful outside of Plasma (technically they should mostly work outside of Plasma, but it d

Plasma Sprint Topics

Hi, with the sprint all in order it's time to collect some topics. Of course we don't want to pre-plan the whole week, and there will be lots of time for free-form discussion and hacking, but having some topics known from the start could help structure the whole thing a bit. This is particularl

Re: Plasma Sprint 2023

Am 02.04.23 um 17:09 schrieb Nicolas Fella: Am 29.03.23 um 15:15 schrieb Nicolas Fella: Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their offi

Re: Plasma Sprint 2023

Am 29.03.23 um 15:15 schrieb Nicolas Fella: Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date

Re: Plasma Sprint 2023

Am 16.03.23 um 17:38 schrieb Nicolas Fella: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to

Re: kpipewire and sddm theme in plasma6

Am 25.03.23 um 19:47 schrieb Harald Sitter: and breeze widget style that will need to be available for qt5 :( On Fri, Mar 24, 2023 at 10:29 AM Harald Sitter wrote: Ciao It occurred to me that we have some compatibility problems coming up. Notably the sddm login theme (which is used by sddm -

Ping: Plasma Sprint 2023

On 3/16/23 17:38, Nicolas Fella wrote: Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to

Re: Plasma repositories sprint cleaning

Hi, ksysguard, kwayland-server, plasma-active-window-control, plasma-redshift-control, and plasma-tests are now archived. On Fri, Mar 3, 2023 at 1:45 PM Nicolas Fella wrote: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy: https

Plasma Sprint 2023

Hi, I guess we can all agree that it's high time for another Plasma Sprint. We are in contact with Tuxedo, who kindly agreed to host us in their office in Augsburg, Germany. To find a suitable date I've created a poll, ranging from May to early June. Please add yourself there so we can plan acc

Re: Plasma repositories spring cleaning

Am 03.03.23 um 13:45 schrieb Nicolas Fella: Hi, while porting Plasma repos to Qt6 I've come across several repos in the plasma/ namespace on invent that I found questionable: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy:

Plasma repositories sprint cleaning

Hi, while porting Plasma repos to Qt6 I've come across several repos in the plasma/ namespace on invent that I found questionable: - khotkeys: consensus seems to be to abandon it, because maintaining two global shortcut systems is no joy: https://phabricator.kde.org/T2050. It's still released wi

Plasma master switches to Qt6

Hi, The master branch for Plasma repos will be made Qt6-only tomorrow, 28.02.2023. There will be disruption because of this. While we aim for getting a basic workspace running as soon as possible non-essential functionality might be broken for a while. Existing kdesrc-build setups will be switc

Splitting KGlobalAccel interface and runtime

Hi, the kglobalaccel framework currently contains two pieces: kglobalacceld, the runtime component that manages global shortcuts, and an application-side library to interact with it. The two communicate with each other via DBus. On X11 there is a standalone kglobalacceld5 process providing the i

Monday meeting notes for 07/11/2022

David E: nothing Arjen: so I'm looking into some kwin performance related things, currently focusing on activation lag when activating the window view effect from the taskbar which has lead me to a deep dive into framesvg and related things in plasma as qml profiling showed that creating PC3 butt

New bugfix release for plasma-workspace

Hi, Plasma 5.25 has no planned releases any more, but the Plasma/5.25 branch in plasma-workspace has accumulated two fixes for somewhat important bugs (https://bugs.kde.org/show_bug.cgi?id=458829 and https://bugs.kde.org/show_bug.cgi?id=458865). The former is a regression introduced in 5.25.5. In

Re: testing UIs and improving a11y all at once!

Am 10.08.22 um 12:29 schrieb Harald Sitter: Servus, A while ago I prototyped a "new" approach to UI testing and I'm wondering if there's general interest in doing more Plasma testing using it. I'm able to invest time in polishing the experience for us. Very rough prototype: https://invent.kde.o

Re: Latte Dock Farewell

On 7/27/22 13:14, Aleix Pol wrote: On Wed, Jul 27, 2022 at 12:15 PM Jonathan Riddell wrote: Michail has announced he's not going to be developing Latte Dock in future https://psifidotos.blogspot.com/2022/07/latte-dock-farewell.html Thanks for all your work Michail! As far as we can tell Latte

Re: C++/library requirements for Plasma 5.26

On 07/07/2022 14:08, Nicolas Fella wrote: Hi, for Plasma 5.26 I would like to make use of some C++20 features, in particular coroutines. In terms of compiler requirements this should translate to requiring GCC 10 or Clang 11. In addition we would like to require the qcoro library (https

Re: C++/library requirements for Plasma 5.26

On 07/07/2022 19:24, Ivan Čukić wrote: You might very well not be reading this correctly, as it's phrased very ambiguously: Very likely. It is just that the ambiguous wording with the conclusion didn't give me the confidence of the quality of implementation. However, C++20 also brought dozens

C++/library requirements for Plasma 5.26

Hi, for Plasma 5.26 I would like to make use of some C++20 features, in particular coroutines. In terms of compiler requirements this should translate to requiring GCC 10 or Clang 11. In addition we would like to require the qcoro library (https://github.com/danvratil/qcoro). As per https://git

Re: Parent windows for system dialogs

On 6/29/22 09:10, Vlad Zahorodnii wrote: On 6/29/22 01:35, Nicolas Fella wrote: Hi, we have several places where we have "system" dialogs that don't have a "real" parent window. Examples would be stuff like KWallet, network management, or anything spawned by kded where

Parent windows for system dialogs

Hi, we have several places where we have "system" dialogs that don't have a "real" parent window. Examples would be stuff like KWallet, network management, or anything spawned by kded where there's no corresponding app window. Currently, at least on Wayland, they are placed semi-randomly on the s

Re: [GSoC Draft proposal] Redesign system settings modules by porting them to QtQuick

Hi, On 3/31/22 19:04, Smit Patil wrote: Hello all, I'm looking for potentials mentors for GSoC 2022 to review/comment my draft proposal for this task:- https://community.kde.org/GSoC/2022/Ideas#Plasma_modernise_system_settings_modules I think for the Font Management KCM there was a conclusion

Monday Meeting Notes for 28/3/2022

Marco: Wayland: Merged realtime screen edges support touch friendly changes for Overview Breeze: More tablet mode friendlyness for breeze qstyle, change on the fly and enlarge many controls https://invent.kde.org/plasma/kwin/-/merge_requests/2168 https://invent.kde.org/plasma/breeze/-/merge_req

[Powerdevil] [Bug 359142] powerdevil ignores "even when external monitor connected" option

https://bugs.kde.org/show_bug.cgi?id=359142 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de Resolution

Plasma 6 Kickoff sprint

Hi, recently there was some discussion on Plasma 6 branching/timeline. At the KF6 meeting we figured it would help finding a timeline if we had some discussion on what kind of (architectural) changes we want to make. I know that Marco has some ideas in particular around plasma-framework and appl

Re: Next Plasma LTS?

On 1/10/22 12:51, David Edmundson wrote: The last 5.X release definitely needs to be an LTS. That's unmovable. We can't have two active LTSs, it'd be a backporting nightmare and at best it would be a lie to claim we're actively supporting both. An LTS now effectively means we can't start Plasm

[plasmashell] [Bug 447389] Notifications widget in the system tray shows items that are not clickable

https://bugs.kde.org/show_bug.cgi?id=447389 Nicolas Fella changed: What|Removed |Added Component|general |Notifications Product|kwrited

Re: Gitlab CI - Inbound

On 05.09.21 08:13, Ben Cooksley wrote: Hi all, This morning after much work i'm happy to announce that the new generation CI scripts intended for use with Gitlab CI successfully completed their first build (of ECM, and then subsequently of KCoreAddons). This begins our first steps towards trans

Re: polkit-kde-agent-1 build failure

Hi, Should be fixed with https://invent.kde.org/libraries/polkit-qt-1/-/merge_requests/18 On 26/08/2021 13:19, Jonathan Riddell wrote: I wonder if anyone has ideas on a build failure I'm getting in polkit-kde-agent-1 https://build.neon.kde.org/job/focal_stable_kde_polkit-kde-agent-1_bin_amd64

Re: KDE CI: Plasma » breeze » kf5-qt5 SUSEQt5.15 - Build # 267 - Still Failing!

Should be fixed with https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/30 On 10.08.21 20:36, CI System wrote: *BUILD FAILURE* Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20SUSEQt5.15/267/

Using C++20 in Plasma

Hi, I would like to explore whether it would be feasible from a distribution POV to use C++20 in Plasma (and other non-Frameworks projects). In practical terms this would mean something like requiring gcc 10 or clang 10 (the exact version that supports a given standard is hard to define precisel

Re: plasma_install_package vs plasma_install_bundled_package

initial patch description it was stated that it is experimental :) Regards Alex On Thursday, July 29, 2021 2:29:01 PM CEST Nicolas Fella wrote: > Hi, > > in > https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa > cros.cmake#L12 we recommen

plasma_install_package vs plasma_install_bundled_package

Hi, in https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMacros.cmake#L12 we recommend using plasma_install_bundled_package over plasma_install_package. However in practice we always use the latter, except for plasma-pa and plasma-nm. I stumbled across this because the b

Re: Maliit as Plasma's on-screen keyboard

Hi, On 28.06.21 09:12, Tobias C. Berner wrote: Moin moin I'm a bit concerned about it seeming to be built on a stack of abandonware -- qtfeedback (no release), and presage (2015). mfg Tobias On Fri, 25 Jun 2021 at 16:38, Aleix Pol wrote: Dear distros, It's been pointed out to me that we ne

Re: Maliit Keyboard and Plasma

Hi, On 24/06/2021 20:17, Jonathan Riddell wrote: It's unclear to me if Plasma expects or needs Maliit to be installed. Technically speaking it does not expect Maliit, any keyboard implementing the required Wayland protocol will do. Maliit happens to be the one we tend to test and it's what we

Re: Akademy Plasma Bof

On 07/06/2021 10:42, Marco Martin wrote: Hi all, Do we want a plasma bof at akademy? often we do a full day one, which may or may not be useful, depending on what topic we do have. Personally i would like to make one about plasma 6 Any day/time preference? other topics? Hi, in terms of topics

Re: Re-purposing KWaylandServer

Hi, I noticed that the current split makes it very hard to perform git bisect on kwin given its close relation to kwayland-server. Therefore big +1 from me to incorporating kwaylandserver into the kwin repo. Cheers Nico On 4/29/21 3:14 PM, Vlad Zahorodnii wrote: On 4/28/21 4:27 PM, Aleix Pol

Re: KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.15 - Build # 93 - Failure!

See https://invent.kde.org/plasma/kinfocenter/-/merge_requests/24 On 3/4/21 12:25 PM, CI System wrote: *BUILD FAILURE* Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.15/93/

Re: Consistent CMake requirements in Plasma

Hi, I have now bumped the requirement for all Plasma repos. There was one resulting build failure in kinfocenter that has been corrected. Let me know if you notice any other unusual behavior. Cheers Nico On 3/1/21 12:30 PM, Nicolas Fella wrote: Hi, so far I haven't received any neg

Re: Consistent CMake requirements in Plasma

Hi, so far I haven't received any negative feedback on this and got acknowledgements from Debian, Fedora and OpenSUSE. Unless someone objects within the next 24 hours I suggest that we proceed with this. Cheers Nico On 2/9/21 7:32 PM, Nicolas Fella wrote: Hi, while I was doing some

Fwd: Consistent CMake requirements in Plasma

any distro that does not ship at least CMake 3.16 interested in shipping future Plasma releases? Cheers Nico Forwarded Message Subject:Consistent CMake requirements in Plasma Date: Tue, 9 Feb 2021 19:32:36 +0100 From: Nicolas Fella Reply-To: plasma-devel

Consistent CMake requirements in Plasma

Hi, while I was doing some cmake cleanup in Plasma I noticed that our stated minimum cmake versions are both somewhat inconsistent and super old. Most Plasma projects state that either 2.8 (released in 2009) or 3.0 (released in 2014) are the minimum. That's obviously unrealistic. Newer cmake ver

Re: theming questions

On 23.12.20 20:05, Dirk Hohndel wrote: Hi there and happy holidays I'm trying to improve the theming of my Kirigami-based app. We started using Kirigami about 5 years ago (before the current Theme code was there) and have done a lot of rather brute force things along the way (mostly out of in

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

nicolasfella added a comment. @leinir it seems like this was merged so I guess this should be closed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25961 To: leinir Cc: nicolasfella, apol, zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jr

[kwrited] [Bug 429652] [Feature Request] Notification applet should also save images

https://bugs.kde.org/show_bug.cgi?id=429652 Nicolas Fella changed: What|Removed |Added Resolution|WAITINGFORINFO |NOT A BUG CC

D28194: Fix loading button icons from qrc

nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/35 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #pl

D21049: [wizard] Enable 1-finger touch scrolling

nicolasfella closed this revision. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D21049 To: nicolasfella, #plasma, drosca, bshah Cc: bshah, ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himce

C++17 in Plasma

Hi, do we have any rules on the C++ standard used in Plasma? Most Plasma repos don't specify a CMAKE_CXX_STANDARD , defaulting to 11 through ECM. Some, such as kwin set it to 14. I found myself a few times in the situation where a C++17 feature would have been useful, but it always felt like req

D29268: [WIP] Add Date/Time dialog

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in androidutils.h:29 > `const QDate &` Actually clazy disagrees, QDate and QTime should be passed by value REPOSITORY R1047 Kirigami Addons REVISION DETAIL https://phabricator.kde.org/D29268 To: nicolasfella, davidedmunds

D29268: [WIP] Add Date/Time dialog

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in TimeDialog.qml:15 > Generally conversions between C++ timedate and JavaScript `Date` is bad. > There's no way to represent just a time with no date and timezone associated > wit

D29268: [WIP] Add Date/Time dialog

nicolasfella updated this revision to Diff 83053. nicolasfella marked 10 inline comments as done. nicolasfella added a comment. - fix - Address some comments REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29268?vs=81471&id=83053 BRANCH work R

D29268: [WIP] Add Date/Time dialog

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:69 > Why this only on Android? or is that used for that dummy library? It's for the dummy library only > broulik wrote in FindGradle.cmake:2 > Feels like this should go into ECM? Yep > broulik wrote in DateD

D22702: [fileitemaction] Clean up includes

nicolasfella closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D22702 To: nicolasfella, ivan Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D22868: Revamp Kirigami.AboutPage

nicolasfella added a comment. can this be closed? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ah

D22702: [fileitemaction] Clean up includes

nicolasfella updated this revision to Diff 83047. nicolasfella added a comment. Update REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22702?vs=62441&id=83047 BRANCH foo REVISION DETAIL https://phabricator.kde.org/D22702 AFFECTED FILES fileitem

D28154: Add users KCM

nicolasfella added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:97 > OH! > > Initial-ise > > not initialise as in "to prepare" > > Makes sense :) Then it should have a different name, like "getInitials", else the next person will be just as confused REPOSITORY R119 P

D29466: [applets/appmenu] Add search to global application menu

nicolasfella added inline comments. INLINE COMMENTS > appmenumodel.cpp:193 > +removeSearchActionsFromMenu(); > +if (filter == QString()) { > +return; .isEmpty() > appmenumodel.cpp:196 > +} > +auto actions = flatActionList(); > +for (const auto &action: actions) { co

D29466: [applets/appmenu] Add search to global application menu

nicolasfella added inline comments. INLINE COMMENTS > appmenumodel.cpp:246 > +} > +for (auto &action: m_menu->findChildren()) { > +if (action->menu() == nullptr) { Extract the list into a variable before iterating, else this might blow up See https://github.com/KDE/clazy/blob/m

D28194: [WIP] Fix loading button icons from qrc

nicolasfella updated this revision to Diff 82149. nicolasfella added a comment. - Also handle ':/' prefix REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28194?vs=78197&id=82149 BRANCH qrcicons REVISION DETAIL https://phabric

D29476: WIP: Port klipper to use wayland clipboard

nicolasfella added a comment. Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc: nico

D29435: Fix typo in examples

This revision was automatically updated to reflect the committed changes. Closed by commit R169:35f055a25e73: Fix typo in examples (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29435?vs=81954&id=82023 REVISION DETAIL https://ph

D29435: Fix typo in examples

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, cblack. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH typo REVISION DETAIL https://phabricator.kde.org/D2

D29312: Change microphoneindicator for reporting audio monitors

nicolasfella added a comment. In D29312#660702 , @kurmikon wrote: > In D29312#660670 , @nicolasfella wrote: > > > > but due to a lack in qt libraries > > > > Can you elaborate on this? What is Qt

D29308: Fix excessive right padding in scrollable page

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e97ffaa7a6b3: Fix excessive right padding in scrollable page (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29308?vs=81611&id=81626 RE

D29312: Change microphoneindicator for reporting audio monitors

nicolasfella added a comment. > but due to a lack in qt libraries Can you elaborate on this? What is Qt lacking? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29312 To: kurmikon, #vdg, #plasma, drosca, broulik Cc: nicolasfella, ngraham, plas

D29308: Fix excessive right padding in scrollable page

nicolasfella added a comment. Mobile before: F8274015: Screenshot_20200430_195955.png Mobile after: F8274019: Screenshot_20200430_200111.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

D29308: Fix excessive right padding in scrollable page

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY In this example import QtQuick 2.5 import QtQuick.Layouts 1.1

D29293: Add rules about import naming and platform specialization

This revision was automatically updated to reflect the committed changes. Closed by commit R1047:a445f089cbec: Add rules about import naming and platform specialization (authored by nicolasfella). REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29293?v

D29293: Add rules about import naming and platform specialization

nicolasfella updated this revision to Diff 81559. nicolasfella added a comment. - Expand notes on specific platforms REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29293?vs=81558&id=81559 BRANCH rules REVISION DETAIL https://phabricator.kde.o

D29293: Add rules about import naming and platform specialization

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, davidedmundson, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY As discussed in chat REPOSITORY R1047 Kirigami Addons

D29268: [WIP] Add Date/Time dialog

nicolasfella added a comment. In D29268#659586 , @vkrause wrote: > There might be ways around the native function registration issue from the QML thread, e.g. by using the alternative approach of exported (mangled) symbols instead: https://docs

D29279: Don't play volume feedback if max volume is reached

nicolasfella added a comment. To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfella, #plasma, drosca, ngraham Cc: cblack, ng

D29279: Don't play volume feedback if max volume is reached

nicolasfella added a comment. The lack of sound is feedback that you are at maximum volume Before it was hard to hear the difference between 90% and 100% REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfella, #pl

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81525. nicolasfella added a comment. - Fix comment REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81524&id=81525 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 AFFE

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81524. nicolasfella added a comment. - Whitespace REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81523&id=81524 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 AFFEC

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81523. nicolasfella added a comment. - Clarify comment REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81522&id=81523 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279

D29279: Don't play volume feedback if max volume is reached

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY I often smash my volume up key until the volume is max. I usually smash it

D29276: Bundle icons for inline messages

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a65fcefe42d: Bundle icons for inline messages (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29276?vs=81513&id=81516 REVISION DETAIL

D29276: Bundle icons for inline messages

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those are used in InlineMessage for the standard message types. We need to bun

D29268: [WIP] Add Date/Time dialog

nicolasfella updated this revision to Diff 81471. nicolasfella added a comment. - fix REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29268?vs=81470&id=81471 BRANCH work REVISION DETAIL https://phabricator.kde.org/D29268 AFFECTED FILES CMak

  1   2   3   4   5   6   >