D29019: Create a hotspot KCM for Plasma Mobile

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project (kcm_mobile_hotspot) > + remove > CMakeLists.txt:11 > +KF5::I18n > +KF5::Plasma > +KF5::QuickAddons KF5::Plasma shouldn't be needed > hotspotsettings.cpp:30 > +{ > +KAboutData* about = new

D27786: [notifications] Read appname from desktop file if no appname set

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fd67206ce554: [notifications] Read appname from desktop file if no appname set (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28034: [Applet] Port to ExpandableListItem

nicolasfella added a comment. This breaks entering a WiFi password for me. Pressing enter just closes the password field with no other reaction. Pressing the Connect button does nothing REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034

D20132: Actually make the network list view show up

nicolasfella added a comment. Is this still relevant? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc: nicolasfella, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28822: Create StreamRestore channel if none exists

This revision was automatically updated to reflect the committed changes. Closed by commit R115:5bdd13689579: Create StreamRestore channel if none exists (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D28833: [kcm/touchpad] Simplify directory structure

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9f34469d04e3: [kcm/touchpad] Simplify directory structure (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28833?vs=80134=80185#toc REPOSITORY R119 Plasma Desktop

D28837: Add device icons to KDE Connect context menu

nicolasfella added a comment. Cool, +1 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28837 To: broulik, #plasma, #kde_connect, fvogt, ndavis Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28799: Refactor and fix the mobile wifi kcm

nicolasfella added inline comments. INLINE COMMENTS > NetworkSettings.qml:27 > SimpleKCM { > +id: networkSettings > property var path not needed > wifisettings.cpp:65 > > +if(type == "secrets") > +return >

D28833: [kcm/toucpad] Simplify directory structure

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY There's no need for yet another directory in between. Also removes some redundant

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella marked an inline comment as done. nicolasfella added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfella, #plasma, broulik Cc: crossi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28714: Refactor enableBluetooth function

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c13704192284: Refactor enableBluetooth function (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28822: Create StreamRestore channel if none exists

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY We need one channel to be able to control the volume. This

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. When I open the KCM and type 'Krun' + Enter I find KRunner as expected, but I still need to click on the KRunner item to actually see the shortcuts. When I then type 'Yaku' + Enter Yakuake is shown correctly in the results, but clicking on the entry does not

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. I always get two horizontal scrollbars, no matter the window size: F8234349: Screenshot_20200413_212457.png The first Choqok shortcut is missing a name, not sure if that's an issue here or in Choqok F8234357:

D28744: Rewrite of the global shortcuts kcm

nicolasfella added a comment. Cool stuff! INLINE COMMENTS > kcm_keys.cpp:110 > +{ > +auto includedComponents = > m_shortcutsModel->match(m_shortcutsModel->index(0, 0), > ShortcutsModel::CheckedRole, true, -1); > +qCDebug(KCMKEYS) << "Exporting to " << url.toLocalFile(); const >

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +auto outputs = m_data->outputs(); > +return std::all_of(outputs.cbegin(), outputs.cend(), const auto REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28773 To: z3ntu, #plasma, bshah,

D28650: [Notifications] Don't reverse() Array

nicolasfella added a comment. Related to the KDE Connect issue: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/238 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28650 To: broulik, #plasma, nicolasfella Cc: plasma-devel, Orage, LeGast00n,

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +return std::all_of(m_data->outputs().cbegin(), m_data->outputs().cend(), > +[this](KScreen::OutputPtr output) { extract m_data->outputs() into a variable. See

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

nicolasfella added inline comments. INLINE COMMENTS > config.cpp:99 > +{ > +bool ret = true; > +for (KScreen::OutputPtr : m_data->outputs()) { That sounds like a job for std::all_of > config.h:50 > void setDeviceOrientation(QOrientationReading::Orientation orientation); > +

D28714: Refactor enableBluetooth function

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The code has quite some boilerplate and high

D28698: Save unneeded DBus roundtrip

This revision was automatically updated to reflect the committed changes. Closed by commit R116:eec18ad4f337: Save unneeded DBus roundtrip (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28698?vs=79689=79711

D28696: Use std::any_of

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b9d6a4009345: Use std::any_of (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28696?vs=79687=79710#toc REPOSITORY R116 Plasma Network Management Applet CHANGES

D28693: Replace old notification when new notification for connection appears

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9e032bf51078: Replace old notification when new notification for connection appears (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28693: Replace old notification when new notification for connection appears

nicolasfella updated this revision to Diff 79697. nicolasfella added a comment. fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28693?vs=79696=79697 BRANCH reuse REVISION DETAIL https://phabricator.kde.org/D28693 AFFECTED

D28693: Replace old notification when new notification for connection appears

nicolasfella updated this revision to Diff 79696. nicolasfella added a comment. - update REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28693?vs=79678=79696 BRANCH reuse REVISION DETAIL https://phabricator.kde.org/D28693

D28691: [kded] Clean up notification handling

This revision was automatically updated to reflect the committed changes. Closed by commit R116:0eeb2605df8e: [kded] Clean up notification handling (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. I see, that makes sense REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. Yes, but I don't see this being a problem REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28698: Save unneeded DBus roundtrip

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY When the module is loaded the handler is

D28696: Use std::any_of

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Makes for more idiomatic code. Bumps the

D28693: Replace old notification when new notification for connection appears

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY When a second notification appears

D28691: [kded] Clean up notification handling

nicolasfella updated this revision to Diff 79676. nicolasfella edited the summary of this revision. nicolasfella added a comment. - Fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28691?vs=79673=79676 BRANCH cleanup REVISION

D28691: [kded] Clean up notification handling

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH cleanup REVISION DETAIL

D28688: Document Kirigami::Icon

nicolasfella added a comment. +1 documentation improvements are always very welcome INLINE COMMENTS > icon.h:37 > + * @include icon/FilesystemSource.qml > + * * The Internet: > + * @include icon/InternetSource.qml Maybe instead of internet something like "a remote url" since

D28685: Use ListSectionHeader in ListView example

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:ae736f9febcd: Use ListSectionHeader in ListView example (authored by nicolasfella). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28685?vs=79661=79668

D28685: Use ListSectionHeader in ListView example

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R1014 Kirigami Gallery BRANCH sectionheader REVISION DETAIL

Virtual Plasma Mobile mini-sprint

Hi, in our latest blog post[0] we announced a virtual Plasma Mobile mini-sprint. The purpose of this is multifold: - Discussions to drive Plasma Mobile forward - Help onboard new contributors that were not able to attend the physical sprint - Explore this kind of interaction as a

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

nicolasfella added a comment. This fixes https://bugs.kde.org/show_bug.cgi?id=415526 REPOSITORY R169 Kirigami BRANCH card_shadowrect REVISION DETAIL https://phabricator.kde.org/D28625 To: ahiemstra, #kirigami, #vdg, cblack Cc: nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2,

D28526: [notifications] Hide close/configure buttons on mobile

nicolasfella added a comment. In D28526#640431 , @broulik wrote: > I think we also want to stop the animation/circle thing, too? Maybe shove all of it in a loader? Isn't that done automatically since the circle thing is a child of the

D28526: [notifications] Hide close/configure buttons on mobile

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The close button is not really needed since the notification can just be swiped

D25549: [kcms/keyboard] Port away from KToolInvokation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:13358835296e: [kcms/keyboard] Port away from KToolInvokation (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25549?vs=70360=79139

D28427: [libnotificationmanager] forward notifications to lockscreen

nicolasfella added a comment. So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more

D28428: [screenlocker] listen to notifications from the notification server

nicolasfella added inline comments. INLINE COMMENTS > interface.cpp:213 > > +void Interface::Notify(const QString& app_name, uint replaces_id, const > QString& app_icon, > + const QString& summary, const QString& body, const > QStringList& actions, conding style: &

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28311?vs=78561=78563#toc

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will

D28194: [WIP] Fix loading button icons from qrc

nicolasfella added a comment. For more context see https://github.com/nextcloud/desktop/issues/1746 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28194: [WIP] Fix loading button icons from qrc

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Allow to use `icon.source: "qrc:/testicon.png"` in buttons. WIP as there

D28154: Add users KCM

nicolasfella added a comment. Couple of nitpicks, mostly coding style and most of that probably comes from me. Can't say much otherwise since I wrote quite a bit of it INLINE COMMENTS > main.qml:100 > +Component.onCompleted: () => { > +print("compl") >

D28154: Add users KCM

nicolasfella added a comment. > I seem to recall seeing that on a rough early version of @nicolasfella's version. That's the most urgently needed feature. I'm pretty sure I did no such thing and I also think it's not super important REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28077: [applet] Add tooltip to enable bluetooth checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R97:a0bc4ed75f46: [applet] Add tooltip to enable bluetooth checkbox (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28077?vs=77735=77736

D28077: [applet] Add tooltip to enable bluetooth checkbox

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Thoroughly inspired by what plasma-nm does REPOSITORY R97 Bluedevil

D28068: Cleanup file resolving

nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The current code is ... a mess. resolveFileUrl and resolveFilePath do very similar things, except that one returns a

D28065: Add missing types to qrc

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1ac443fefff: Add missing types to qrc (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28065?vs=77690=77707 REVISION DETAIL

D28065: Add missing types to qrc

nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH types REVISION DETAIL https://phabricator.kde.org/D28065 AFFECTED FILES kirigami.qrc

D27996: Fix undefined check in global drawer menu mode

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4d84d3f1d93f: Fix undefined check in global drawer menu mode (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77465=77630

D27572: [kcm] Drop 'Enable bluetooth integration' setting

This revision was automatically updated to reflect the committed changes. Closed by commit R97:2d92acae05f4: [kcm] Drop Enable bluetooth integration setting (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27572?vs=76167=77629

D27572: [kcm] Drop 'Enable bluetooth integration' setting

nicolasfella added a comment. In D27572#626285 , @drosca wrote: > What happens if someone have it disabled and updates Plasma with this change? Nothing immediately happens, but the module can be reenabled via the KDED KCM REPOSITORY

D27574: Remove bold formatting of device name

This revision was automatically updated to reflect the committed changes. Closed by commit R97:c190802e1e0a: Remove bold formatting of device name (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27574?vs=76178=77527 REVISION

D27996: Fix undefined check in global drawer menu mode

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in PageRowGlobalToolBarUI.qml:49 > Wouldn't it be easier to do: > > visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && >

D27996: Fix undefined check in global drawer menu mode

nicolasfella updated this revision to Diff 77465. nicolasfella added a comment. - use 'in' REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77458=77465 BRANCH fixkamoso REVISION DETAIL https://phabricator.kde.org/D27996 AFFECTED FILES

D27996: Fix undefined check in global drawer menu mode

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Kamoso uses Overlaydrawer instead of GlobalDrawer, which has no isMenu

D27563: [mobile/wifi] Use ScrollViewKCM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:83ce03a41117: [mobile/wifi] Use ScrollViewKCM (authored by nicolasfella). REPOSITORY R116 Plasma Network Management

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella marked 2 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in notification.cpp:333 > That codepath assumes we have a notifyrc nvm REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To:

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella updated this revision to Diff 76783. nicolasfella added a comment. - Combine codepaths REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27786?vs=76780=76783 BRANCH notiappname REVISION DETAIL https://phabricator.kde.org/D27786

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in notification.cpp:333 > How about adjusting this condition instead? That codepath assumes we have a notifyrc REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfella,

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Some applications, e.g. pamac, don't send an app_name, which is legal

D27781: [Language KCM] Wrap the label text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2df03a51f97: [Language KCM] Wrap the label text (authored by PureTryOut, committed by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

nicolasfella added inline comments. INLINE COMMENTS > kdeplatformdependent.cpp:165 > +// directly requests the accounts kcm to start adding a new account if > it's not there, maybe even pre-fills the fields...) > +KService::List services = >

D27581: Use K_PLUGIN_CLASS_WITH_JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R133:6d551e4754f3: Use K_PLUGIN_CLASS_WITH_JSON (authored by nicolasfella). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27581?vs=76186=76307 REVISION DETAIL

D27581: Use K_PLUGIN_CLASS_WITH_JSON

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's a bit niver than the factory thing TEST PLAN builds, kcm opens REPOSITORY

D27570: [applets/systemtray] Clip ListView in config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:193c89a4a0cf: [applets/systemtray] Clip ListView in config (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27570?vs=76165=76180#toc REPOSITORY R120 Plasma

D27574: Remove bold formatting of device name

nicolasfella updated this revision to Diff 76178. nicolasfella added a comment. - Simplify REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27574?vs=76169=76178 BRANCH nobold REVISION DETAIL https://phabricator.kde.org/D27574 AFFECTED FILES

D27574: Remove bold formatting of device name

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY D27543 set the label

D27572: [kcm] Drop 'Enable bluetooth integration' setting

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It controls whether the bluedevil kded module is loaded. I don't see any

D27570: [applets/systemtray] Clip ListView in config

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content will overflow the frame when scrolling REPOSITORY R120 Plasma

D27561: [kcm/activities] Clip ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dba3d5670275: [kcm/activities] Clip ListView (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27561?vs=76134=76163 REVISION

D27559: [kcm/baloo] Clip ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0ec354f7d269: [kcm/baloo] Clip ListView (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27559?vs=76132=76164 REVISION DETAIL

D27563: [mobile/wifi] Use ScrollViewKCM

nicolasfella added a comment. In D27563#615561 , @ngraham wrote: > What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of

D27555: Add a category for kde-only and gnome-only apps

nicolasfella added a comment. In D27555#615587 , @ngraham wrote: > I used to think this was really important but am less sure now. I don't feel the need to push for it, but nonetheless Aleix is right that it's pretty common user request--not

D27563: [mobile/wifi] Use ScrollViewKCM

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY This gives the KCM a proper frame/scrollbar

D27561: [kcm/activities] Clip ListView

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content overflows the frame when scrolling. Same finding/fix as in

D27559: [kcm/baloo] Clip ListView

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the content overflows the frame when scrolling REPOSITORY R119 Plasma

D27555: Add a category for kde-only and gnome-only apps

nicolasfella added a comment. -1 This "Only KDE apps on KDE, only GNOME apps on Gnome" is an attitude we need to leave behind, not reinforce by introducing such filters. The original bug report is only about mobile, which is an entirely different story REPOSITORY R134 Discover

D26871: [examples/simplechatapp] Always set isMenu to true

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2d5674da7b60: [examples/simplechatapp] Always set isMenu to true (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26871?vs=74239=75778

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4b93444e2915: Make the api docs reflect that Kirigami is not only a mobile toolkit (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27093: Provide better name for GTK Settings Sync service

nicolasfella added a comment. +1 (speaking as the one who introduced the name IIRC) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27093 To: gikari, #vdg Cc: nicolasfella, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

nicolasfella updated this revision to Diff 74825. nicolasfella added a comment. - Update wording REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27047?vs=74726=74825 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D27047 AFFECTED FILES

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH docs REVISION DETAIL https://phabricator.kde.org/D27047

D27011: Update plasma startup sequence README

nicolasfella added inline comments. INLINE COMMENTS > README:37 > > The server is usually started from the 'startkde' script. It supports the > following options: > Isn't this startplasma now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27011 To:

D26935: context: add function to allow loading and unloading modules

nicolasfella added a comment. I was about to say something similar. Where would one get the index from? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D26935 To: bshah, sitter, nicolasfella Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26530: ScrollView: Do not overlay scrollbars over contents

nicolasfella added a comment. This has caused a regression in the plasma-pa KCM. The scrollview content is now a bit larger than the scrollview itself which results in a horizontal scrollbar appearing F7965068: Screenshot_20200126_181545.PNG

D26871: [examples/simplechatapp] Always set isMenu to true

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It does the right thing on mobile automatically REPOSITORY R169 Kirigami

D26586: [SystemTray] Rework system tray settings

nicolasfella added a comment. There's a minor problem (that I've seen in other place as well). When scrolling the content overflows the frame on the top a bit: See how the top frame is white while the side is blue F7883066: Screenshot_20200114_170622.png

D26598: Drop unused method

This revision was automatically updated to reflect the committed changes. Closed by commit R122:c3b253f49468: Drop unused method (authored by nicolasfella). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26598?vs=73321=73371 REVISION DETAIL

D26598: Drop unused method

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's not used anywhere TEST PLAN builds REPOSITORY R122 Powerdevil

D26586: [SystemTray] Rework system tray settings

nicolasfella added a comment. I'm not against keeping the separators, but the button to en/disable the whole section seems overkill to me. Chances are that the set of entries you want to have does not exactly align with the categories anyway REPOSITORY R120 Plasma Workspace REVISION

D26586: [SystemTray] Rework system tray settings

nicolasfella added a comment. Also German locale strikes again: The shortcut label (Tastatur-Kurzbefehle) is too long here F7877547: Screenshot_20200111_182731.PNG REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

nicolasfella added a comment. I would just kill the per-section control. There's no point to that IMHO REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: nicolasfella,

D22176: Rework system tray settings

nicolasfella added a comment. yes, feel free to take it over :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26409: [kicker] Use arrow functions in signal handlers

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4b20f3a91006: [kicker] Use arrow functions in signal handlers (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

<    1   2   3   4   5   6   >