---
Path was wrong. Could not compile.
Diffs
-
kcms/cursortheme/CMakeLists.txt e7613c0
Diff: https://git.reviewboard.kde.org/r/125050/diff/
Testing
---
It compiled.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125050/#review84845
-----------
On Sept. 4, 2015, 9:42 p.m., Ovidiu-Florin BOGDAN wrote:
>
> ---
> This is a
> On Sept. 4, 2015, 9:44 p.m., David Edmundson wrote:
> > patch looks good, but why are you in the else branch of
> > if(X11_Xcursor_FOUND)
> >
> > ?
> >
> > You want to fix that on the packaging side rather than having this patch
>
> Ovidiu-Florin
-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
b44d111
kcms/baloo/kcm.h 6ff5813
kcms/baloo/kcm.cpp 27d93e2
Diff: https://git.reviewboard.kde.org/r/125058/diff/
Testing
---
Tested add, remove include and exclude directories.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
. To reply, visit:
https://git.reviewboard.kde.org/r/125058/#review84861
-----------
On Sept. 5, 2015, 2:33 p.m., Ovidiu-Florin BOGDAN wrote:
>
> ---
> This is an automatica
.ui, line 43
> > <https://git.reviewboard.kde.org/r/125058/diff/1/?file=400370#file400370line43>
> >
> > Moving the checkBox from the top to bottom? Why? Also, if we want this
> > it goes in a seperate patch.
>
> Ovidiu-Florin BOGDAN wrote:
> I moved
n a separate
> > patch. This patch is large and should be split.
>
> Ovidiu-Florin BOGDAN wrote:
> It is simpler to get the desired information with QStorageInfo, and it is
> less error prone. The risk for errors is smaller.
>
> Also Solid is another dependency. Qt
StringLiteral instead of QLatin1String?
- Ovidiu-Florin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125058/#review84876
---
On Sept. 5,
-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
directories.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
Added .gitignore to ignore KDevelop projects.
Diffs
-
kcms/baloo/.gitignore PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125060/diff/
Testing
---
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel
Description
---
IMHO this way it is more logical.
Diffs
-
kcms/baloo/configwidget.ui 512e4a5
Diff: https://git.reviewboard.kde.org/r/125061/diff/
Testing
---
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma
---
This way the name of the variable is more descriptive with it's purpose.
Diffs
-
kcms/baloo/folderselectionwidget.cpp b44d111
Diff: https://git.reviewboard.kde.org/r/125062/diff/
Testing
---
Thanks,
Ovidiu-Florin BOGDAN
___
P
/125058/diff/
Testing
---
Tested add, remove include and exclude directories.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
s an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125058/#review84886
-----------
On Sept. 5, 2015, 11:11 p.m., Ovidiu-Florin BOGDAN wrote:
>
> ---
>
---------
On Sept. 5, 2015, 11:05 p.m., Ovidiu-Florin BOGDAN wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125062/
>
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125061/#review84901
-----------
On Sept. 5, 2015, 11:03 p.m., Ovidiu-Florin BOGDAN wrote:
>
> ---
> This is an automat
discarded.
Review request for Plasma and KDE Usability.
Repository: plasma-desktop
Description
---
IMHO this way it is more logical.
Diffs
-
kcms/baloo/configwidget.ui 512e4a5
Diff: https://git.reviewboard.kde.org/r/125061/diff/
Testing
---
Thanks,
Ovidiu-Florin BOGDAN
-Florin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125061/#review84897
-----------
On Sept. 5, 2015, 11:03 p.m., Ovidiu-Florin BOGDAN wrot
27d93e2
Diff: https://git.reviewboard.kde.org/r/125107/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
Tested add, remove include and exclude directories.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
sting
---
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
discarded.
Review request for Plasma.
Repository: plasma-desktop
Description
---
Added .gitignore to ignore KDevelop projects.
Diffs
-
kcms/baloo/.gitignore PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125060/diff/
Testing
---
Thanks,
Ovidiu-Florin BOGDAN
marked as submitted.
Review request for Baloo, Plasma and Vishesh Handa.
Changes
---
Submitted with commit a80d1931d878ddf024975bbeeb869c2f731db194 by Ovidiu-Florin
BOGDAN to branch master.
Repository: plasma-desktop
Description
---
Also added some Doxygen comments to better
/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
lly for new readers).
Also the compiler optimises that.
- Ovidiu-Florin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85057
---
Diff: https://git.reviewboard.kde.org/r/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Diff: https://git.reviewboard.kde.org/r/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
> On Sept. 9, 2015, 9:11 p.m., Martin Klapetek wrote:
> > kcms/baloo/kcm.cpp, line 167
> > <https://git.reviewboard.kde.org/r/125117/diff/1/?file=402363#file402363line167>
> >
> > const QStorageInfo &si
>
> Ovidiu-Florin BOGDAN wrote:
>
Diff: https://git.reviewboard.kde.org/r/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
return excluded.toSet() == mountPoints.toSet();
> >
> > ...it will return the result of that comparison.
> >
> > Or even
> >
> > return m_excludeFolders_FSW->excludeFolders().toSet() ==
> > mountPoints.toSet();
> >
>
this result. I don't know on Windows though. Nor on
>Mac.
- Ovidiu-Florin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125117/#review85465
-------------
3ad1764
kcms/baloo/kcm.h 6878e89
kcms/baloo/kcm.cpp d85f615
Diff: https://git.reviewboard.kde.org/r/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
t; > that is compared with the mountPoint?
> >
> > The display name isn't always equal to the mount path or is it?
> >
> > http://doc.qt.io/qt-5/qstorageinfo.html#displayName
>
> Ovidiu-Florin BOGDAN wrote:
> From my tests I always g
/baloo/kcm.h 6878e89
kcms/baloo/kcm.cpp d85f615
Diff: https://git.reviewboard.kde.org/r/125117/diff/
Testing
---
Compiled and used.
Thanks,
Ovidiu-Florin BOGDAN
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
r.
The changelog has the changes from the current latest release of Kubuntu.
If you guys have any ideas on how to make it better, or a different aproach to
this problem, please let me know.
Regards,--
*Ovidiu-Florin BOGDAN*
GeekAliens.com[2]
Kubuntu Romania Representative[3]
_Kubuntu Cou
Hello,
A Merge Request in GitLab does not necessarily imply the need for a review by e
person. It can just run a pipeline to validate that the code isn't broken. If
the pipeline fails, the merge button is not available.
We use GitLab at work and we have it set up like this:
* Main branches (de
lease let me know if these are known issues, or should I report bugs for them?
What other info can I provide to identify the cause of these issues?
Best wishes,
Ovidiu-Florin Bogdan
(Crazy person on the Mureș)
help.
În ziua de luni, 27 februarie 2017, la 13:51:02 EET, Ovidiu-Florin Bogdan a
scris:
> Hello awesome plasma devs!
>
> I've just upgraded to Kubuntu 17.04 Beta 1, with Plasma 5.9.2, and many of my
> scaling and multiple monitor issues havebeen solved. So, Thank you for th
help.
În ziua de luni, 27 februarie 2017, la 13:51:02 EET, Ovidiu-Florin Bogdan a
scris:
> Hello awesome plasma devs!
>
> I've just upgraded to Kubuntu 17.04 Beta 1, with Plasma 5.9.2, and many of my
> scaling and multiple monitor issues havebeen solved. So, Thank you for th
41 matches
Mail list logo
