[Differential] [Closed] D1831: Add rule for chromium to taskmanagerrulesrc for proper grouping.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE110f58471510: Add rule for chromium to taskmanagerrulesrc for proper grouping.` (authored by pinakahuja). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 6 lines] D1831: Add rule for chromium to taskmanagerrulesrc for proper grouping.

pinakahuja created this revision. pinakahuja added a reviewer: Plasma. pinakahuja set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

marked as submitted. Review request for Plasma and Vishesh Handa. Changes --- Submitted with commit 93e437c684ed57fefcf2f5821edd52008e60c2a2 by Pinak Ahuja to branch master. Repository: plasma-desktop Description --- Also use the new Baloo::IndexerConfig::refresh() Diffs

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

Handa. Repository: plasma-desktop Description (updated) --- Also use the new Baloo::IndexerConfig::refresh() Diffs (updated) - kcms/baloo/kcm.cpp 8012a3b Diff: https://git.reviewboard.kde.org/r/125129/diff/ Testing --- Thanks, Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interf

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interf

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

oard.kde.org/r/125129/#review85462 --- On Sept. 10, 2015, 5:56 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 125129: Update baloo's D-Bus interface name in KCM

Description --- Also generate interface from XML Diffs - kcms/baloo/CMakeLists.txt 7415289 kcms/baloo/kcm.cpp d85f615 Diff: https://git.reviewboard.kde.org/r/125129/diff/ Testing --- Thanks, Pinak Ahuja ___ Plasma-devel

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

marked as submitted. Review request for Plasma and Martin Klapetek. Changes --- Submitted with commit 105cd18dbfe644e510e772a7e8226d8e965477f9 by Pinak Ahuja to branch master. Repository: kwallet-pam Description --- pam_kwallet5.so was being installed to /lib(64) irrespective

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

--- On Aug. 28, 2015, 7:39 a.m., Pinak Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124962

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

outside of the default dir (I have no clue)? Pinak Ahuja wrote: According to this: http://www.cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html the syntax I've used is correct. I don't know if the pam modules are supported outside the default dir either. My kdesrc build

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

--- pam_kwallet5.so seems to install under the directory set as CMAKE_INSTALL_PREFIX Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123088: Adding libkactivities-stats to the build

On 21-Mar-2015 2:38 am, Ivan Čukić ivan.cu...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123088/ Review request for Plasma, Eike Hein and Marco Martin. By Ivan Čukić. Repository: plasma-desktop Description The experimental

Re: Review Request 123040: Make selection in krunner wrapping

to bottom. M +1-1lib/qml/ResultsView.qml http://commits.kde.org/milou/05570618369027c8636db9abbe3726ece6fe8e72 - Pinak Ahuja On March 20, 2015, 4:14 p.m., Pinak Ahuja wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 123040: Make selection in krunner wrapping

- lib/qml/ResultsView.qml 0eac7b8 Diff: https://git.reviewboard.kde.org/r/123040/diff/ Testing --- Compiled and tested on my pc, works as described. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request 123040: Make selection in krunner wrapping

/ Testing --- Compiled and tested on my pc, works as described. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123040: Make selection in krunner wrapping

: https://git.reviewboard.kde.org/r/123040/diff/ Testing --- Compiled and tested on my pc, works as described. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122328: Fix apply button in breeze window decoration config

/breezeconfigwidget.cpp e160c57 Diff: https://git.reviewboard.kde.org/r/122328/diff/ Testing --- Compiled and installed, apply button works as expected. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122328: Fix apply button in breeze window decoration config

I might be wrong, but shouldn't the changed signal have a bool parameter? The changed() without a parameter refers to a slot(can we emit a slot? I'm new to this). I didn't compile and check if the behaviour was fixed in the master branch without this patch, I have the problem with the plasma 5.2

Review Request 122328: Fix apply button in breeze window decoration config

--- Compiled and installed, apply button works as expected. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2 beta

It would be better, if you could verify these things in 5.2 stable. If you are able to reproduce them, file a bug report at https://bugs.kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Idea for plasma media center

haven't really thought of how I would implement this. Thanks, Pinak Ahuja ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel