[Differential] [Updated, 416 lines] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
sebas updated this revision to Diff 5538. sebas marked 2 inline comments as done. sebas added a comment. - Address comments from David's review REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2295?vs=5514&id=5538 BRANCH sebas/log REVISION

[Differential] [Commented On] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in log.cpp:30 > why have it separate instead of a member of log? I just tried making it a member, but running into problems. QtMessageHandler is a typedef'ed function pointer, not a class. If I add a static member in my Log c

[Differential] [Commented On] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in log.cpp:46 > It doesn't matter if there are threads *in* kscreen. > > The question is: Can a kscreen class be used *in* another thread by $app. That's what I meant, it's not designed to be thread-safe at all. The backends h

Re: Is it possible to know when a PlasmaCore IconItem is ready?

2016-07-28 Thread Sebastian Kügler
On donderdag 28 juli 2016 14:03:24 CEST Michail Vourlakos wrote: > is it possible to know when a PlasmaCore IconItem in QML is ready? > I am trying to use the grabToImage for that element and the only way > to achieve this until now, is after Component.OnCompleted to use a > timer element. > > I u

[Differential] [Commented On] D2295: improve logging for kscreen

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > bshah wrote in testlog.cpp:88 > nitpick - cAPs. ;-) It's a test, this way it covers strange capitalization. :) > davidedmundson wrote in log.cpp:46 > Question: > What's the threading policy on libkscreen? > > This isn't reentrant (which might be f

[Differential] [Commented On] D2219: Add option to enable volume feedback

2016-07-28 Thread Sebastian Kügler
sebas added a comment. Can we expect canberra to be available everywhere PA is? It seems that it's just playing a short ticking sound, perhaps we can avoid the dependency easily? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2219 EMAIL

[Differential] [Changed Subscribers] D2296: RFC: "Add Widget" runner

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > addwidgetsrunner.cpp:126 > + > +const QPoint cursorPos = QCursor::pos(); > +const QString script = scriptTemplate.arg(QString::number(cursorPos.x()), Have you tested if this works on Wayland? (It probably won't, which means the widget ends

[Differential] [Commented On] D2294: categorized logging for kscreen kcm

2016-07-28 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > davidedmundson wrote in debug.h:25 > There's a CMake macro for all this file. That's how it's done for the other components in this repo as well, so I went for that same solution here as well. REPOSITORY rKSCREEN KScreen REVISION DETAIL https

Re: multiscreen logging

2016-07-28 Thread Sebastian Kügler
On donderdag 28 juli 2016 01:18:00 CEST David Kahles wrote: > I think the problem with this approach is, that most (or even all?) of > these processes aren't units but simple processes. > A better approach using the power of journald would be something like: > > journalctl -b --user _COMM=plasmash

Re: multiscreen logging

2016-07-28 Thread Sebastian Kügler
On woensdag 27 juli 2016 13:45:14 CEST Martin Klapetek wrote: > On Wed, Jul 27, 2016 at 7:35 AM, Sebastian Kügler wrote: > > On dinsdag 26 juli 2016 19:44:11 CEST Martin Klapetek wrote: > > On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler wrote: > > > > What do you

[Differential] [Accepted] D2301: [Kicker] Add missing config-workspace.h include to appentry.cpp

2016-07-27 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2301 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: abond

[Differential] [Accepted] D2300: always load about-distro in ctor

2016-07-27 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH load-through-ctor REVISION DETAIL https://phabricator.kde.org/D2300 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D2300: Update version number for 5.7.0 GIT_SILENT

2016-07-27 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH load-through-ctor REVISION DETAIL https://phabricator.kde.org/D2300 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Planned Changes To] D2155: kded: fix up invalid current mode before saving

2016-07-27 Thread Sebastian Kügler
sebas planned changes to this revision. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2155 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graesslin Cc: plasma-devel, jensreuterberg, abetts, sebas ___

Re: multiscreen logging

2016-07-27 Thread Sebastian Kügler
On woensdag 27 juli 2016 17:14:21 CEST Bhushan Shah wrote: > I wonder if code is failsafe in case of such clash while opening > logfile? Because for sure, we don't want another crashes.. I don't see how it would crash. -- sebas http://www.kde.org | http://vizZzion.org ___

Re: [Kde-hardware-devel] multiscreen logging

2016-07-27 Thread Sebastian Kügler
On dinsdag 26 juli 2016 14:03:50 CEST Sebastian Kügler wrote: > What do you think? If you like the idea, I'll polish up my branch and will > post it for review, so we can discuss the actual implementation. https://phabricator.kde.org/D2295 works well for my purposes. --

Re: multiscreen logging

2016-07-27 Thread Sebastian Kügler
On dinsdag 26 juli 2016 19:44:11 CEST Martin Klapetek wrote: > On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler wrote: > Hey, > > [Please keep both lists addressed.] > > Debugging multiscreen issues is a nightmare: > > - there are at least 4 different processes

[Differential] [Updated, 417 lines] D2295: improve logging for kscreen

2016-07-26 Thread Sebastian Kügler
sebas updated this revision to Diff 5514. sebas added a comment. - Fix copyright REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2295?vs=5513&id=5514 BRANCH sebas/log REVISION DETAIL https://phabricator.kde.org/D2295 AFFECTED FILES au

[Differential] [Request, 417 lines] D2295: improve logging for kscreen

2016-07-26 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Debugging kscreen is generally really hard since it's spread across different processes, not all of which are

[Differential] [Request, 68 lines] D2294: categorized logging for kscreen kcm

2016-07-26 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - add category kscreen.kcm - switch all debug statements in kcm to categorized logging TEST PLAN tested manu

Re: Selecting a Plasma logo

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 2:54:26 PM CEST Thomas Pfeiffer wrote: > On 26.07.2016 14:03, Marco Martin wrote: > > On Tuesday 26 July 2016 12:57:04 kainz.a wrote: > >> I'm a fan of anditosan circle logo, > >> > >> cause it fit's in small size as an icon the breeze icon theme (thin 1px > >> elements)

[Differential] [Accepted] D2242: [ksplash] Better support for Wayland with multiple screens

2016-07-26 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. The wayland portions look good, so as soon as you guys are happy, I am. I guess the platform name stuff can happen async? REPOSITORY rPLASMAWORKSPACE Plas

multiscreen logging

2016-07-26 Thread Sebastian Kügler
Hey, [Please keep both lists addressed.] Debugging multiscreen issues is a nightmare: - there are at least 4 different processes involved (kded, kcmshell / systemsettings, kscreen_backend_launcher and plasmashell) - some are critical during log in - they IPC with each other - especially the b

Re: "Software not found" Runner

2016-07-26 Thread Sebastian Kügler
On Tuesday, July 26, 2016 1:16:41 PM CEST Harald Sitter wrote: > On Tue, Jul 26, 2016 at 1:10 PM, Marco Martin wrote: > > On Tuesday 26 July 2016 13:01:10 Aleix Pol wrote: > >> Hi, > >> Last week I put together this runner, thought it might be useful, so > >> if you type in krunner an application

[Differential] [Accepted] D2239: Workaround searching lockup

2016-07-25 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2239 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Requested Changes To] D2240: Anchors in a layout item is always wrong

2016-07-25 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a reviewer: sebas. This revision now requires changes to proceed. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2240 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D2248: [kcm] Show output name in output preview

2016-07-25 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENe6b052db712f: [kcm] Show output name in output preview (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2248?vs=5390&id=5484 REVISION DET

[Differential] [Commented On] D2248: [kcm] Show output name in output preview

2016-07-21 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in Output.qml:254 > this one looks confusing to my: why is the vendor compared to output.name? > Just from reading it, one doesn't assume that root.output.name is also the > vendor. This label may show the output name, if it does,

[Differential] [Updated] D2248: [kcm] Show output name in output preview

2016-07-21 Thread Sebastian Kügler
sebas updated the summary for this revision. sebas removed a subscriber: graesslin. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2248 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: plasma-devel, jensreuterb

[Differential] [Request, 28 lines] D2248: [kcm] Show output name in output preview

2016-07-21 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When identical displays are connected, the identify overlay would display the output name, while the preview in

[Differential] [Closed] D2156: improve output identification

2016-07-20 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN1bd8dc46e4cd: improve output identification (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2156?vs=5300&id=5361 REVISION DETAIL https

[Differential] [Commented On] D2164: Allow struts on panels between screen edges if WM is KWin

2016-07-20 Thread Sebastian Kügler
sebas added a comment. If @luebking is otherwise fine with it, why not merge it? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2164 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc: seb

[Differential] [Accepted] D2185: Handle restart of Compositor Scene correctly for Wayland client

2016-07-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > scene_qpainter_test.cpp:214 > + > +// now lets try to reinitialize the compositing scene > +auto oldScene = KWin::Compositor::self()

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @ochurlaud You're sure? The QGuiApplication::font() is the base for all sizing. Did you change the font, or the font size? (It could be that the fonts you've tried have similar metrics.) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabrica

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @drosca Which patch are you using? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma:_design, #plasma, davidedmunds

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. Well, it depends on font size plus whitespace. All the screens I've used are fine, btw, but for smaller screens, it may look a bit larger. Once it carries events, it will make better use of that space, anyway. REPOSITORY rPLASMAWORKSPACE Plasma Workspace RE

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread Sebastian Kügler
sebas added a comment. -1, the calendar is only going to look more cramped like this. Whitespace is useful and part of the visual language, don't just remove it. Also, the size of the calendar is oriented with the size of the systray popup, this change will make it inconsistent, and

[Differential] [Accepted] D2233: Announce output changes to Wayland for platforms not handling outputs

2016-07-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH announce-output-changes-to-wayland REVISION DETAIL https://phabricator.kde.org/D2233 EMAIL PREFERENCES

[Differential] [Commented On] D2156: improve output identification

2016-07-20 Thread Sebastian Kügler
sebas added a comment. @davidedmundson Did you also get to try it? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc: davidedmundson, graesslin, lbeltrame,

[Differential] [Accepted] D2201: [platforms/wayland] Use XdgShell if available and prefer it

2016-07-19 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH xdg-shell-platform REVISION DETAIL https://phabricator.kde.org/D2201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D2154: kscreen kcm: block changed signal after save

2016-07-19 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN4b69f8708e63: kscreen kcm: block changed signal after save (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5309&id=5310 REVISION

[Differential] [Updated, 22 lines] D2154: kscreen kcm: block changed signal after save

2016-07-19 Thread Sebastian Kügler
sebas updated this revision to Diff 5309. sebas added a comment. - Add comment explaining the hack REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5139&id=5309 BRANCH blockkcmchanges REVISION DETAIL https://phabricator.kde.org/D2154 AFFECT

[Differential] [Reopened] D2156: improve output identification

2016-07-19 Thread Sebastian Kügler
sebas reopened this revision. sebas added a comment. (Pushed a branch for testing which closed this request. This patch is not merged, yet.) REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Closed] D2156: improve output identification

2016-07-19 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN1b1c51cddda7: improve output identification (authored by sebas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2156?vs=5194&id=5300#toc REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UP

[Differential] [Accepted] D2204: [Service Runner] Search through "Comment" as well

2016-07-18 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2204 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: b

Minutes Monday Plasma Meeting

2016-07-18 Thread Sebastian Kügler
Minutes Plasma 'hangout', 18-7-2016, 12:00 CET Present: mgraesslin, bshah, Sho, kbroulik, notmart, sebas bshah: - Not much update last week, just new phone image with sound working - I also submitted initial patches for nexus 5 mainline support that supports volume up and down button and serial

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread Sebastian Kügler
sebas added a comment. @davidedmundson Good point, I'll revert that one and will give it another good round of testing. It'd be nice if you could test once you're back next week (same for @lbeltrame, of course.) REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D21

[Differential] [Commented On] D2156: improve output identification

2016-07-15 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in outputgrid_2x3.json:129 > nitpick What's the issue? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas,

[Differential] [Commented On] D2156: improve output identification

2016-07-14 Thread Sebastian Kügler
sebas added a comment. @lbeltrame Does it work for you? If you can try this patch, that'd be awesome (also if it already works for you, to check if the patch breaks anything). REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://

[Differential] [Commented On] D2156: improve output identification

2016-07-14 Thread Sebastian Kügler
sebas added a comment. @davidedmundson Sure. With this patch - we detect the case when multiple identical outputs are connected (same hash) - each of the duplicate outputs also gets matched against the output name The problem I'm fixing is that currently (without my patch) the

[Differential] [Updated, 269 lines] D2156: improve output identification

2016-07-14 Thread Sebastian Kügler
sebas updated this revision to Diff 5194. sebas added a comment. fix checks and add autotests - autotest for videowall bug - improve and fix checks - randomize order in autotest REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2156?vs=5140&id=519

Re: Review Request 128434: rename some kcm desktop files

2016-07-14 Thread Sebastian Kügler
! - Sebastian Kügler On July 14, 2016, 12:25 p.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: [RFC] WindowMetadata framework fundamentals

2016-07-14 Thread Sebastian Kügler
On Thursday, July 14, 2016 6:46:36 PM CEST Eike Hein wrote: > > looking at the code i see it's still based on window ids, any idea how to > > solve that/how to identify windows? [...] > That means no more global ids - the object name itself becomes the > handle. Right. Will need a bit more code,

Re: [RFC] WindowMetadata framework fundamentals

2016-07-14 Thread Sebastian Kügler
On Wednesday, July 13, 2016 5:10:25 PM CEST Thomas Pfeiffer wrote: > The caveat that writing text into the thumbnail is problematic is a pretty > big problem > from my perspective. For example in a text editor, I don't see how relevant > information > can be represented by a "pretty picture". I'd

Re: Review Request 128434: rename some kcm desktop files

2016-07-14 Thread Sebastian Kügler
> On July 14, 2016, 11:41 a.m., Sebastian Kügler wrote: > > Looks good to me. > > > > Have you checked if any documentation needs updating? (I.e. are any of the > > names referred to in docbooks?) > > Andreas Kainz wrote: > where are the docbooks? unde

[Differential] [Accepted] D2159: [src/server] Verify that surface has a resource before sending pointer enter

2016-07-14 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-check-surface-resource-on-enter REVISION DETAIL https://phabricator.kde.org/D2159 EMAIL PREFERENCES https://phabricator.kde.org/setti

Re: [RFC] WindowMetadata framework fundamentals

2016-07-14 Thread Sebastian Kügler
On Thursday, July 14, 2016 1:41:54 PM CEST Martin Graesslin wrote: > > > - currently open document > > > > Don't most applications expose that in their window title, anyway? > > Some do, some don't. Some put it at the start of their title, some at the > end. Some add some character that the data

Re: Review Request 128434: rename some kcm desktop files

2016-07-14 Thread Sebastian Kügler
needs updating? (I.e. are any of the names referred to in docbooks?) - Sebastian Kügler On July 14, 2016, 10:15 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

[Differential] [Commented On] D2156: improve output identification

2016-07-13 Thread Sebastian Kügler
sebas added a comment. I'd like to get some feedback on the approach, however. I think this is actually a nice minimal fix, as we can't really change how the id is generated. I may be missing something here. This obviously needs some testing. It shouldn't break existing setups, but I c

[Differential] [Request, 21 lines] D2156: improve output identification

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When identical outputs (i.e. outputs with the same edid) are connected, the serializer can't match the outputs

[Differential] [Updated, 20 lines] D2154: kscreen kcm: block changed signal after save

2016-07-13 Thread Sebastian Kügler
sebas updated this revision to Diff 5139. sebas added a comment. - use compile-time connection REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5137&id=5139 BRANCH blockkcmchanges REVISION DETAIL https://phabricator.kde.org/D2154 AFFECTED F

[Differential] [Request, 10 lines] D2155: kded: fix up invalid current mode before saving

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When resizing a virtual machine, the current mode may become invalid. In this case, we set the current mode

[Differential] [Request, 16 lines] D2154: kscreen kcm: block changed signal after save

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When changing position (and potentially other properties) of the screen setup, we receive delayed signals way a

[Differential] [Commented On] D2112: Add a shortcut for Meta+P

2016-07-13 Thread Sebastian Kügler
sebas added a comment. For the record, this change has been backported to Plasma 5.7, shipped with 5.7.1. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2112 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, d

Re: Review Request 128434: rename some kcm desktop files

2016-07-12 Thread Sebastian Kügler
e of that. The patch should only change the first line, without the []. The translations will then be automatically updated a few hours later by the "scripty" daemon, once translators have picked up the string changes. - Sebastian Kügler On July 12, 2016,

[RFC] WindowMetadata framework fundamentals

2016-07-12 Thread Sebastian Kügler
ound in the kde:scratch/sebas/windowmetadata repository. Feedback is most welcome. -- sebas Sebastian Kügler•http://vizZzion.org•http://www.kde.org# WindowMetadata WindowMetadata is a task-based IPC framework for communication between applications and the windowing system WindowMetad

[Differential] [Accepted] D2033: Clear idle timeouts when session becomes inactive

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Good observation. Switching to a session is user interaction, so the idle timers should be reset here. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL ht

[Differential] [Requested Changes To] D1976: Image of the Day wallpaper plugin

2016-07-12 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. This review is still pending with a bunch of changes requested. Still, it would be nice to get this into 5.8? REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://

[Differential] [Accepted] D2135: [platforms/drm] Properly handle case that mapping the blank buffer fails

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH drm-failed-blank-5.7 REVISION DETAIL https://phabricator.kde.org/D2135 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Accepted] D2108: Add support for xdg-shell version 5 interface

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH xdg-shell REVISION DETAIL https://phabricator.kde.org/D2108 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: grae

[Differential] [Accepted] D2134: [platforms/fbdev] Properly detect a BGR image format

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fbdev-bgr-5.7 REVISION DETAIL https://phabricator.kde.org/D2134 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D2102: Add support for xdg-shell

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Some suggestions inline, but nothing major. INLINE COMMENTS > registry.h:818 > +/** > + * Creates a XdgShell and sets it up to manage the interface iden

[Differential] [Accepted] D2091: [server] Properly send a selection clear prior to keyboard focus enter

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH selection-clear-on-focus REVISION DETAIL https://phabricator.kde.org/D2091 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > slidingpopups.cpp:200 > animating = true; > -} else if (mDisappearingWindows.contains(w) && w->isDeleted()) { > +} else if

[Differential] [Accepted] D2084: [libkwineffects] Add signals windowShown and windowHidden to EffectsHandler

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH window-shown-hidden-effectshandler REVISION DETAIL https://phabricator.kde.org/D2084 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Accepted] D2083: Use hiddenInternal() for a ShellClient which got unmapped

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shell-client-window-hidden REVISION DETAIL https://phabricator.kde.org/D2083 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2078: Handle situation of no XDG_RUNTIME_DIR gracefully

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-xdg-runtime-dir REVISION DETAIL https://phabricator.kde.org/D2078 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2077: [server] Handle no XDG_RUNTIME_DIR situation more gracefully

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH no-xdg-runtime-dir REVISION DETAIL https://phabricator.kde.org/D2077 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D2059: Merge signal connections for AbstractClient in Workspace

2016-07-12 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. LGTM :) REPOSITORY rKWIN KWin BRANCH client-signals-workspace REVISION DETAIL https://phabricator.kde.org/D2059 EMAIL PREFERENCES https://phabricator.

[Differential] [Closed] D2112: Add a shortcut for Meta+P

2016-07-11 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENdbdca5335413: Add a shortcut for Meta+P (authored by l10n daemon script , committed by sebas). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2112?vs=5006&id=5089#toc REPOSITORY rKSCREEN

Minutes Monday Plasma Meeting

2016-07-11 Thread Sebastian Kügler
Minutes Plasma 'hangout', 4-7-2016, 12:00 CET Present: mgraesslin, bshah, Sho, kbroulik, notmart, Riddell, sebas mgraesslin: * work on support for windowShow/windowHide in kwineffects - makes sliding popus work * sliding popup still doesn't work for closing OpenGL windows - the buffer is lost,

[Differential] [Commented On] D2112: Add a shortcut for Meta+P

2016-07-07 Thread Sebastian Kügler
sebas added a comment. Forgot to add: the alternate doesn't show up in my Global Shortcuts / KDE Daemon list of shortcuts this way. Not sure why ... ? REPOSITORY rKSCREEN KScreen BRANCH sebas/365147 REVISION DETAIL https://phabricator.kde.org/D2112 EMAIL PREFERENCES https://phabric

[Differential] [Request, 4 lines] D2112: Add a shortcut for Meta+P

2016-07-07 Thread Sebastian Kügler
sebas created this revision. sebas added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also relevant: http://mjg59.livejournal.com/121851.html BUG:365147 REPOSITORY rKSCREEN KScreen

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-07 Thread Sebastian Kügler
On donderdag 7 juli 2016 11:29:15 CEST Ivan Čukić wrote: > As for the browser, while I do agree with Martin regarding the slow Qt > security updates, I do not think we should actively discourage their > use. Agree. Let's keep the recommendations positive. -- sebas http://www.kde.org | http://viz

Re: Plasma 5.7.0 tars

2016-07-04 Thread Sebastian Kügler
On Monday, July 4, 2016 1:59:41 PM CEST David Edmundson wrote: > I meant "if we accidentally released libkscreen 5.6" as "libkscreen 5.7 > beta", please tell me. > > We didn't. Ok, good. Thanks for checking! -- sebas http://www.kde.org | http://vizZzion.org _

Re: Which applications does the Plasma team recommend to use with Plasma?

2016-07-04 Thread Sebastian Kügler
On Monday, July 4, 2016 2:43:07 PM CEST Thomas Pfeiffer wrote: > every now and then, distributions approach us asking which applications > they should ship by default with Plasma, or they complain about us not > providing such information. > Although the Plasma team of course does not have to prov

Re: Plasma 5.7.0 tars

2016-07-04 Thread Sebastian Kügler
On Monday, July 4, 2016 1:29:55 PM CEST David Edmundson wrote: > ... and if not, I need to know, because that means that > > - nobody tested the changes in libkscreen's master in the beta > - the test reports that I did get from the beta are meaningless (which could > be a good thing ;)) > > Coul

Re: Plasma 5.7.0 tars

2016-07-04 Thread Sebastian Kügler
On Thursday, June 30, 2016 11:06:46 PM CEST Harald Sitter wrote: > On Thu, Jun 30, 2016 at 4:45 PM, David Edmundson > > wrote: > > *sigh* seems so. Yet plasma-workspace is from the right branch and it's > > done by an automated script(!) > > Haven't we fixed that for beta already? ... and if no

[Differential] [Accepted] D2081: handle DVI

2016-07-04 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY rKSCREEN KScreen BRANCH Plasma/5.7-handle-dvi REVISION DETAIL https://phabricator.kde.org/D2081 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D2080: do not 'default' handle switch-cases

2016-07-04 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Nice improvement! REPOSITORY rKSCREEN KScreen BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2080 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

Minutes Monday Plasma Hangout

2016-07-04 Thread Sebastian Kügler
Minutes Plasma 'hangout', 4-7-2016, 12:00 CET Present: mgraesslin, bshah, Sho, kbroulik, d_ed, notmart, Riddell, sebas mgraesslin: * Improved internal Test library in KWin * New test case which verifies rendering is correct in QPainter compositor * rendering fixes in QPainter compositor * Fixes f

Re: Is it able to make kservice's weightedOffers public access?

2016-07-01 Thread Sebastian Kügler
On dinsdag 28 juni 2016 08:56:31 CEST Leslie Zhai wrote: > I am so sorry for my mistake, it will not happen again! Don't worry, I was not trying to correct you, but help you get a good answer. Cheers, -- sebas http://www.kde.org | http://vizZzion.org

[Differential] [Accepted] D2037: Properly handle destroying a Pointer resource

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH pointer-unbound REVISION DETAIL https://phabricator.kde.org/D2037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

Re: Review Request 128311: standardize kcm layout - autostart

2016-06-28 Thread Sebastian Kügler
hand, without compiling, it's also not possible to show it in a meaningful fashion. This needs someone to apply and test. - Sebastian Kügler On June 28, 2016, 9:45 p.m., Andreas Kainz wrote: > > --- > This is an automatical

[Differential] [Accepted] D2032: Add support for ToolTip Role on PlasmaSurface

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH plasma-surface-tooltip REVISION DETAIL https://phabricator.kde.org/D2032 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D2031: [kwindowsystem] Add support for NET::Tooltip

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH tooltip REVISION DETAIL https://phabricator.kde.org/D2031 EMAIL PREFERENCES https://phabricat

[Differential] [Accepted] D2030: Add a ToolTip role to PlasmaShellSurface

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-surface-tooltip REVISION DETAIL https://phabricator.kde.org/D2030 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D2028: Paint the software cursor directly in SceneQPainter

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpainter-paint-cursor-5.7 REVISION DETAIL https://phabricator.kde.org/D2028 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Accepted] D2027: Render cursor in multi-screen setup in QPainter Compositor

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpainter-render-cursor-multi-screen-5.7 REVISION DETAIL https://phabricator.kde.org/D2027 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Accepted] D2026: [platforms/drm] If mapping a DrmBuffer for a cursor fails, fallback to software cursor

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH drm-software-cursor-5.7 REVISION DETAIL https://phabricator.kde.org/D2026 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

<    1   2   3   4   5   6   7   8   9   10   >