Re: Review Request 115162: Launch single instance of plasma-mediacenter

2016-09-22 Thread Sujith Haridasan
using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith

Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit

2014-07-02 Thread Sujith Haridasan
/ Testing --- Done testing with fullscreen enabled and exit fullscreen disabled and exit. Both results were as expected. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

2014-05-17 Thread Sujith Haridasan
arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 118092: Left and right movement in All music

2014-05-16 Thread Sujith Haridasan
) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma

Re: Review Request 118092: Left and right movement in All music

2014-05-15 Thread Sujith Haridasan
/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan

Re: Review Request 118092: Left and right movement in All music

2014-05-15 Thread Sujith Haridasan
left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 118092: Left and right movement in All music

2014-05-11 Thread Sujith Haridasan
if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sujith Haridasan
On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: Seems to be an ulra-hack, but if it works, i guess you should commit it if it really helps your users to be able to use your product. Maybe adding a big TODO somewhere to recheck if this is needed later on or something.

Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

2014-03-19 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review53430 --- Ship it! Looks good to me :) - Sujith Haridasan On March

Re: Review Request 116907: Implemented Player MPRIS spec adaptor

2014-03-19 Thread Sujith Haridasan
single adaptor? Just wanted to know what advantage would that make? - Sujith Haridasan On March 19, 2014, 5:22 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-05 Thread Sujith Haridasan
On March 3, 2014, 6:01 a.m., Sujith Haridasan wrote: Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

2014-03-02 Thread Sujith Haridasan
effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. - Sujith Haridasan On March 2, 2014, 10:53 p.m

Re: Review Request 115764: Make playlist model aware of currently playing media

2014-02-16 Thread Sujith Haridasan
break. Hence I am ok with this change. - Sujith Haridasan On Feb. 15, 2014, 5:24 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764

Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

2014-02-05 Thread Sujith Haridasan
://git.reviewboard.kde.org/r/115447/#review49053 --- On Feb. 3, 2014, 3:53 p.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

2014-02-05 Thread Sujith Haridasan
--- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan

Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

2014-02-03 Thread Sujith Haridasan
in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

2014-02-03 Thread Sujith Haridasan
/ Testing --- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/#review47915 --- On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Sujith Haridasan
of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 115162: Launch single instance of plams-mediacenter

2014-01-20 Thread Sujith Haridasan
) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-20 Thread Sujith Haridasan
using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-09 Thread Sujith Haridasan
/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-08 Thread Sujith Haridasan
://git.reviewboard.kde.org/r/114892/diff/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan

Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-07 Thread Sujith Haridasan
one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-07 Thread Sujith Haridasan
from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing

Re: Review Request 114741: Add time duration to media item for youtube videos.

2013-12-30 Thread Sujith Haridasan
job. I tested the basic functionality like viewing the thumbnail and playing the video in openSUSE 13.1. It works like charm. So according to me this should go in. I give final say to Sinny and Shantanu. - Sujith Haridasan On Dec. 31, 2013, 6:46 a.m., Sudhendu Kumar wrote

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-16 Thread Sujith Haridasan
--- Tested with 3 playlists and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-16 Thread Sujith Haridasan
and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-15 Thread Sujith Haridasan
the playlist b opened in the view. Diffs - mediaelements/playlist/MultiplePlaylists.qml 42877f0 Diff: http://git.reviewboard.kde.org/r/114482/diff/ Testing --- Tested with 3 playlists and it worked properly. Thanks, Sujith Haridasan

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2013-12-12 Thread Sujith Haridasan
://git.reviewboard.kde.org/r/114428/#comment32577 The PMC time doesn't get synced with desktop time. Can you tune this further to get it synced? mediaelements/mediawelcome/HomeScreenFooter.qml http://git.reviewboard.kde.org/r/114428/#comment32576 Remove the white space - Sujith Haridasan

Re: Review Request 114318: Adding keyboard navigation support for popupmenu.

2013-12-05 Thread Sujith Haridasan
/newshell/package/contents/ui/mediacenter.qml 78d24c6 mediaelements/popupmenu/PopupMenu.qml 3ef66bb Diff: http://git.reviewboard.kde.org/r/114318/diff/ Testing --- Done testing both with mouse and keyboard. It worked fine. Thanks, Sujith Haridasan

Re: Review Request 114318: Adding keyboard navigation support for popupmenu.

2013-12-05 Thread Sujith Haridasan
, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114223: Moving popupmenu to mediacenter and making it more generic

2013-11-30 Thread Sujith Haridasan
, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic

2013-11-30 Thread Sujith Haridasan
--- Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic

2013-11-30 Thread Sujith Haridasan
menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
found major issues. - Sujith Haridasan On June 23, 2013, 6:16 a.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 9:06 a.m.) Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan. Description --- Using a PageStack for navigation

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sujith Haridasan
/ --- (Updated June 23, 2013, 2:26 p.m.) Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan. Description --- Using a PageStack for navigation in PMC has lots of benefits, the most important

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-15 Thread Sujith Haridasan
and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-15 Thread Sujith Haridasan
/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-14 Thread Sujith Haridasan
the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-13 Thread Sujith Haridasan
., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 12, 2011, 3:40 p.m.) Review

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-13 Thread Sujith Haridasan
/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

2011-12-12 Thread Sujith Haridasan
Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https

KDE/kdeplasma-addons/applets/bball

2009-07-19 Thread Sujith Haridasan
SVN commit 999070 by sujithh: Fixing the Bball getting stuck at the bottom right/left corner. Added a feature for making the ball bounce even if the ball is released from the top right/left corner. CCMAIL: plasma-devel@kde.org M +24 -4 bball.cpp M +1 -1 bball.h ---

branches/KDE/4.3/kdeplasma-addons/applets/bball

2009-07-19 Thread Sujith Haridasan
SVN commit 999083 by sujithh: Backporting r999070 from trunk. CCMAIL: plasma-devel@kde.org M +24 -4 bball.cpp M +1 -1 bball.h --- branches/KDE/4.3/kdeplasma-addons/applets/bball/bball.cpp #999082:999083 @@ -55,7 +55,10 @@ m_x_vel(0.0), m_y_vel(0.0),