Re: GTK apps integration in Plasma Wayland and Distribution Packaging

Hello, On 9/30/24 4:01 PM, Nate Graham wrote: FWIW, my understanding is that the font rendering issue requiring the GTK portal to fix it should be resolved as of https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7748. It appears that the GTK portal is needed for more than that. Without the

GTK apps integration in Plasma Wayland and Distribution Packaging

Hi, A common pitfall with packaging the Plasma Wayland session is omitting important dependencies that are a cornerstone for proper integration of GTK applications and also some flatpak applications. These dependencies include: - xsettingsd - and, xdg-desktop-portal-gtk While xsettings is m

Re: QtWayland 6.7.2 packaging recommendation

On 7/9/24 2:38 PM, Scarlett Moore wrote: To be clear, this only affects 6.7.2, correct? Yes, that's correct. Vlad Scarlett On 7/9/24 02:14, Vlad Zahorodnii wrote: Hello, QtWayland 6.7.2 contains a regression with regards to initializing the popup parent, which can result i

QtWayland 6.7.2 packaging recommendation

Hello, QtWayland 6.7.2 contains a regression with regards to initializing the popup parent, which can result in the plasmashell process getting killed in some circumstances (e.g. https://bugs.kde.org/show_bug.cgi?id=489259). The regression has been fixed in 6.7.3, but according to the Qt rele

kwin 6.1.1 respin request

Hello, The shake cursor feature has regressed quite severely in 6.1.1. The following three commits fix it: - https://invent.kde.org/plasma/kwin/-/commit/7527a9099cfc3f0127b87ddad488c8059cdf3a8d - https://invent.kde.org/plasma/kwin/-/commit/5d94ce9eac18a0ecf4dbbc8dbd04b385dc24c8ff - https://

kwin 6.0.3 respin

Hello, Is it possible to respin kwin 6.0.3 so it includes the following two commits - https://invent.kde.org/plasma/kwin/-/commit/74060343a0286bf9d8054cbe67cb019d07455db3 - https://invent.kde.org/plasma/kwin/-/commit/13e31baca828c912152b8a201224e9f04ec9bea1 We originally wanted to get them i

kwin respin request

Hi, I'd like to request a respin of kwin with https://invent.kde.org/plasma/kwin/-/commit/961a2d70417fe4cb9e053f1348e703fb611065f4 included. That commit fixes a pretty severe issue where the screen may freeze for a second. Cheers, Vlad

Re: Merge Service still in use?

On 12/18/23 19:25, Ben Cooksley wrote: Just out of curiosity - why? It broke down a while ago and, unfortunately, it covers only some of ours needs, not all. So it was not a big loss for us and we simply moved on with merging patches manually. Cheers, Vlad

Re: Merge Service still in use?

On 12/16/23 03:41, Ben Cooksley wrote: Hi all, I've just been reviewing services we're looking after and while doing so have noticed that Marge Bot (invent.kde.org/merge-service ) doesn't seem to have done anything for 4 months. As the two projects with

Re: setcap on kwin

On 9/4/23 13:44, David Edmundson wrote: That was true, we need to research and see if it's still true. Gnome have dropped their cap_sys_nice. For setting nice we many options: - kwin_wayland_wrapper can be cap_sys_nice set it the nice a child PID (needs verifying) - maybe the systemd cgroup

Re: setcap on kwin

On 9/4/23 04:21, Harald Sitter wrote: ...do we still need and want it? It gets in the way of crash tracking because it results in kwin_wayland crashes getting special protection by coredumpd that make the cores unreadable for the user [1][2][3]. So we either need polkit elevation in drkonqi or d

layer shell meeting notes

## Intro - layer-shell: https://wayland.app/protocols/wlr-layer-shell-unstable-v1 - plasma-shell: https://wayland.app/protocols/kde-plasma-shell - Was challenging to switch to layer-shell in Qt 5 times, but should be doable in Plasma 6 and Qt 6.5+ ## DesktopView: - the simplest case, only ne

Re: Soft Feature Freeze Approaching

On 1/5/23 10:50, Marco Martin wrote: I have a minor refactor pending in kwin https://invent.kde.org/plasma/kwin/-/merge_requests/3310 given how fiddly it has been to keep the tests for working, i was meditating that perhaps is not worth the effort and may be abandoned altogether, what do you t

Cherry-picking policy

Hi, At the moment, we have the following bugfixing workflow in plasma: * fix a bug in master * cherry pick the fix to stable branch(es) The last step is usually done without creating a MR. If there is a merge conflict, some people do create a MR though. I propose to make creating MRs for bug

Re: Plasma 5.25.90

On 9/15/22 22:43, Bernhard Rosenkraenzer wrote: On Thursday, September 15, 2022 16:11 CEST, Jonathan Riddell wrote: Plasma 5.25.90 is now released kwin fails to build against kwayland 5.98.0 because autotests/integration/test_helpers.cpp calls KWayland::Client::Output::name(), which onl

Re: Parent windows for system dialogs

On 6/29/22 01:35, Nicolas Fella wrote: Hi, we have several places where we have "system" dialogs that don't have a "real" parent window. Examples would be stuff like KWallet, network management, or anything spawned by kded where there's no corresponding app window. Currently, at least on Wayland

kwin respin request

Hi, I'd like to request a re-spin of kwin. These two commits need to be in the final 5.24.0 release. - https://invent.kde.org/plasma/kwin/-/commit/e26ca3d8d4138f6f174c4c0b798b3b7189383d0f - https://invent.kde.org/plasma/kwin/-/commit/9e9bb6c6deaf76834340b9359d0e19fc7ccee8cd Regard, Vlad

Re: RFC: Using `-Wno-unused-parameter` in Plasma projects

On 10/27/21 20:41, Vlad Zahorodnii wrote: Besides adding more work and code, it's easy to forget to remove Q_UNUSED() once it actually becomes readable used*

RFC: Using `-Wno-unused-parameter` in Plasma projects

Hi, The main issue with -Wunused-parameter is that it makes development more painful. For example, say that you have an observer class and you need to override a dozen of methods to handle various events, but you don't really care about arguments... In every method, you would need to add Q_UN

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

On 8/26/21 9:58 PM, Ben Cooksley wrote: On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii <mailto:vlad.zahorod...@kde.org>> wrote: Hi, Hi Vlad, I've just merged a patch that tweaks some protocol additions in the plasma window management protocol that were made

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

On 8/26/21 9:58 PM, Ben Cooksley wrote: On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii <mailto:vlad.zahorod...@kde.org>> wrote: Hi, Hi Vlad, I've just merged a patch that tweaks some protocol additions in the plasma window management protocol that were made

plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

Hi, I've just merged a patch that tweaks some protocol additions in the plasma window management protocol that were made this month and haven't been released yet. Even though that change won't affect users running stable version of plasma, it may cause issues on developer machines. If you

Re: About some old and hard to maintain effects

On 5/31/21 4:43 PM, Aleix Pol wrote: Do you think these effects could be implemented using other non-deprecated abstractions? Yes. Those effects need to render every animated window into an offscreen texture and then do their thing, e.g. map the offscreen texture on a cube or a cylinder, etc.

About some old and hard to maintain effects

Hi, Currently, we redesign scene abstractions in kwin [1]. https://blog.vladzahorodnii.com/2021/04/12/scene-items-in-kwin/ outlines the end goal and provides an explanation why the scene abstractions need to be reworked. But just to summarize: * kwin renders wayland surfaces differently depe

Re: Re-purposing KWaylandServer

Hi, It looks like we've reached a conclusion. The most compelling option is to bring KWaylandServer under KWin's umbrella instead. The current architecture doesn't work and it makes it harder to push the wayland progress forward. I'll start the work on importing KWaylandServer after Plasma/

Re: Re-purposing KWaylandServer

On 4/28/21 4:27 PM, Aleix Pol wrote: +1 for unifying them and refactoring all within a product. It must stay properly separate but it would allow us to organise the If kwaylandserver is integrated with the rest of kwin, it will be possible to simplify some protocols as wayland bits will be abl

Re: Re-purposing KWaylandServer

On 3/23/21 6:27 PM, Aleix Pol wrote: I don't feel like there's a use-case for it. I also don't have the feeling that having 2 separate repositories help with anything. Moving code from one side to another is cumbersome and makes history tracking more complex. I think it would be even cool if we

Re: plasma-wayland-protocols v1.2.1

mfg Tobias On Mon, 5 Apr 2021 at 20:38, Vlad Zahorodnii wrote: Hi, The v1.2.0 release of plasma-wayland-protocols has wrong project version in CMakeLists.txt, which causes packaging issues in KWayland 5.81. v1.2.1 patch release fixes that problem. Source can be found here: https://download

plasma-wayland-protocols v1.2.1

-v1.2.1.tar.xz Mirrors: https://download.kde.org/stable/plasma-wayland-protocols/plasma-wayland-protocols-v1.2.1.tar.xz.mirrorlist Key fingerprint is EC5516B514543DA145169FD12276F09AF4A790F4 (Vlad Zahorodnii ), the public key can be found at pgp.mit.edu. Cheers, Vlad

Re-purposing KWaylandServer

Hi, Currently, KWaylandServer library is a collection of convenience Qt wrappers around Wayland protocols. The issue with such a design is that the bulk of work needs to be still done in the compositor, for example it still needs to deal with importing client buffers, setting up the session,

Re: KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 826 - Still Failing!

On 3/2/21 2:23 PM, Aleix Pol wrote: I saw. My patch was removing it though and it didn't fail on my system. Maybe it's a different behaviour between gcc and clang. I could try that... Another option is to try to remove #include "keyboard_input.h" in wayland_server.h somehow. As far as I can te

Re: KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 826 - Still Failing!

On 3/2/21 3:15 AM, Aleix Pol wrote: Just reverted my own commit. https://invent.kde.org/plasma/kwin/commit/b409f523f01cad45c9b1f4068ffc9fcf9a72399b I cannot reproduce locally and we better keep a working build

Re: Consistent CMake requirements in Plasma

On 2/9/21 8:32 PM, Nicolas Fella wrote: Hi, while I was doing some cmake cleanup in Plasma I noticed that our stated minimum cmake versions are both somewhat inconsistent and super old. Most Plasma projects state that either 2.8 (released in 2009) or 3.0 (released in 2014) are the minimum. That'

Is it time to fork qtwaylandscanner?

Hi, As you probably know, the Qt company announced [1] that 5.15.3 is going to be a commercial-only release. It won't be exaggeration to say that this is really sad news. Unfortunately, KWin/Wayland is going to be affected by this unexpected freeze of Qt 5.15 for open-source because there is

Re: KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 177 - Still Failing!

I'm on it. On 9/2/20 5:08 PM, CI System wrote: *BUILD FAILURE* Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.15/177/ Project:kf5-qt5 SUSEQt5.15 Date of build: Wed, 02 Sep 2020 14:01:18 + Build duration: 7 min 13 sec and counting *CONS

Re: Integration of layer-shell in plasma

On 8/28/20 9:13 AM, Bhushan Shah wrote: FTR: There's already out-of-tree installation of qtwayland shell integration plugin from Drew : https://github.com/ddevault/qtlayershell/ That looks very promising! However, we still need to address a couple of issues: * QtWayland doesn't allow to use

Integration of layer-shell in plasma

Howdy, As you probably know, surfaces created by plasmashell need to be treated specially by the compositor. For example, notification windows must be always on top, panels may go above and below normal windows. That's why we use a proprietary protocol called plasma-shell for creating shell s

Re: merge request and issue notifications to this list?

On 7/29/20 3:19 PM, Bhushan Shah wrote: > Other option would be to create a separate plasma-notifications mailing > list which people can subscribe if they wish to for this purpose. +1 for this option Cheers, Vlad

Re: Plasma 5.20 and Qt versions

On 7/13/20 3:46 PM, Jonathan Riddell wrote: Sorry for the lack of reply, yes let's go with Qt 5.15 as the required dep for Plasma 5.20. Awesome! Thank you for the update. Cheers, Vlad

Re: Plasma 5.20 and Qt versions

Howdy, On 6/12/20 2:34 PM, David Edmundson wrote: Distros, We're in the process of determining our dependencies for Plasma 5.20, our release in about 4 months. Ideally we would like to depend on Qt5.15, we can land some wayland fixes that would be otherwise hard to  #ifdef as well as do som

Re: Sprint notes for gitlab discussion

Hi, On 6/15/20 1:06 AM, David Edmundson wrote:  - There was a discussion on the two different styles of use gitlab use. Some people squash locally and have a nice neat commit history. Others don't, and then just squash at end.      - Conclusion was it's unreasonable to get devs to squash an

D27004: [kstyle] Drop XCB and KWayland dependency

zzag added a comment. Will move to GitLab. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27004 To: zzag, #plasma, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesli

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag abandoned this revision. zzag added a comment. Will move to GitLab. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragre

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag abandoned this revision. zzag added a comment. Abandoned in favor of https://invent.kde.org/plasma/oxygen/-/merge_requests/1 REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n,

D28922: Port Sensor Face loading from plasmoid

zzag added inline comments. INLINE COMMENTS > SensorFaceController.cpp:177 > +if (component->status() != QQmlComponent::Ready) { > +qCritical() << "Error creating component:"; > +for (auto err : component->errors()) { One could argue that "Error creating component" is a prett

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

zzag added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: What distro are you running? REPOSITORY R119 Plasm

D29476: WIP: Port klipper to use wayland clipboard

zzag added a comment. +1 in general. > Not mergable as-is, especially the hardcoded line in CMakeLists but uploaded to show direction. Heh, it seems like we now have a good reason to upstream FindWaylandProtocols.cmake from KWayland to extra-cmake-modules. :-) REPOSITORY R120 Pla

D29033: Remove duplicated code

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > waylandintegration.cpp:191 > [this] (PlasmaWindow *w) { > -emit KWindowSystem::self()->windowAdded(w->internalId()); > -

D28333: Add a new daemon for stats monitoring

zzag added inline comments. INLINE COMMENTS > nvidia.cpp:2-3 > +/* > +Copyright (c) 2019 David Edmundson > +Copyright (c) 2020 David Edmundson > + Typo? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28333 To: davidedmundson, #plasma Cc: zzag, plasma-deve

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in touchpad.qml:607 > So I can only make it faster? > > Is that sensible? I suspect that a scroll factor less than 1 may screw up discrete axis values. Not sure whether it might be a problem, though. REPOSITORY R119 Plasma D

D28272: Avoid copying buffer twice

zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in screencaststream.cpp:549-563 > The entire framebuffer is superfluous, it is never used. glGetTexImage() > reads from the currently bound texture, which in this case is "texture" since > you bind it at line 546. The fbo is gone 8a

D28272: Avoid copying buffer twice

zzag added inline comments. INLINE COMMENTS > screencaststream.cpp:549-563 > +// bind framebuffer to copy pixels from > +GLuint framebuffer; > +glGenFramebuffers(1, &framebuffer); > +glBindFramebuffer(GL_FRAMEBUFFER, framebuffer); > +glFramebufferTexture2D(GL_FRAMEBUFFER, GL_C

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a comment. > in "Always on" manual mode: when active (not inhibited) I still don't understand why we should hide the applet. If VDG is okay with such behavior, then feel free to push this change, I won't object or anything. INLINE COMMENTS > main.qml:26 > > +import org.kde.

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 78291. zzag added a comment. Rebase on master. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73686&id=78291 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFE

D28141: Add KSysGuard::Sensors library

zzag added inline comments. INLINE COMMENTS > Sensor.h:2 > +/* > +Copyright (C) 2019 Vlad Zagorodniy > +Copyright (C) 2020 Arjen Hiemstra Could you please update my last name? git grep -l 'Vlad Zagorodniy' | xargs sed -i 's/Vlad Zagorodniy/Vlad Zahor

D28154: Add users KCM

zzag added a comment. Some files have the executable bit on, e.g. kcms/users/CMakeLists.txt. 755 -> 644. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

zzag added a comment. Urgh, the authorship information is screwed up. :/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson, zzag Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for the xkb keymap (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=77916&id=78000

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

zzag updated this revision to Diff 77916. zzag added a comment. Rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=39945&id=77916 BRANCH arcpatch-D14910 REVISION DETAIL https://phabricator.kde.org/D14910 AFFECTED FILES autote

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629829 , @ahmadsamir wrote: > Anyway, the important thing is that the test passes on the CI system. Okay, that's good! We still have that qDeleteAll in ~ShadowHelper(), not sure what we have to do about it

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal SIG

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal SIG

D28075: [kstyle] Properly unregister widgets in ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit R31:49fdd73e1629: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28075?vs=77727&id=77893 REVISION

D28073: [kstyle] Properly unregister widgets in ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit R113:19771d84177d: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28073?vs=77725&id=77892

D28055: Fix on wayland activating minimized window will move window to current desktop

zzag added a comment. Yes, on Wayland, a window can be more on than just one desktop. However, in this scenario, the minimized window should not be placed on other desktops. > how should I proceed ? First, we need to make sure that plasmashell doesn't put the window on other desktop

D28055: Fix on wayland activating minimized window will move window to current desktop

zzag added a comment. > it will put window to VD1 and VD2. It seems to me like this bug must be fixed in KWin rather than libtaskmanager. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28055 To: pereira.alex, #plasma, zzag Cc: ngraham, plasma-devel, Orag

D28081: Populate Greeter process exit stderr

zzag added inline comments. INLINE COMMENTS > ksldapp.cpp:256 > } > +qCritical("Greeter process exitted and we could in no way > recover from that!"); > } Shouldn't it be in an else branch? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. Alternatively, we could drop `qDeleteAll( _widgets );` because the style is destroyed after all widgets have been deleted. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: anthonyfieroni, broulik, plasma-devel, O

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. Another way around is not to use `qDeleteAll`, e.g. for( QWidget* widget : _widgets ) { unregisterWidget( widget ); } // or uninstallShadows() Either way, I'm open to suggestions. :-) REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kd

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY After a widget has been unregistered, a WinIdChange event may be sent. If that happens, ShadowHelper is g

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. In D28074#628308 , @broulik wrote: > It would be nice not to mutate a list that's being deleted Well, we could do something like this (not sure whether it works though) for (KWindowShadow *shadow : _shadows)

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. it would be nice to have qSafeDeleteAll or something that takes a copy rather than a const ref. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28073: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. it would be nice to have `qSafeDeleteAll` or something that takes a copy rather than a const ref. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28073 To: zzag, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleig

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. I would say it's undefined behavior. Either way, we should not call qDeleteAll on a container which is being "simultaneously" mutated. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY When a KWindowShadow object is destroyed, it's automatically removed from _shadows and therefore iterator

D28073: [kstyle] Properly unregister widgets in ShadowHelper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY After a widget has been unregistered, a WinIdChange event may be sent. If that happens, ShadowHelper is g

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

zzag added a comment. Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davi

D27980: make opengl module support multiple dri devices

zzag added a comment. In D27980#626500 , @sitter wrote: > Had a quick look, using libdrm seems a bit excessive for what we want to do here. Well, it was worth a try. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kd

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a reviewer: VDG. zzag added a comment. In D27972#626302 , @broulik wrote: > I think this needs a VDG/Usability discussion. Yes! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrows

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added inline comments. INLINE COMMENTS > pdabrowski wrote in main.qml:36-38 > > We want to keep the applet visible even if Night Color is inhibited so user > > can quickly uninhibit it. > > You are right. I have modified the patch to show the icon when inhibited in > timed modes. Why onl

D27984: [WIP] Add a ShadowedRectangle item

zzag added a comment. Are there any significant differences between shadows that were generated using distance fields and shadows that were generated with a blur filter(e.g. box blur or stack blur, etc)? (asking out of curiosity) REPOSITORY R169 Kirigami REVISION DETAIL https://phabrica

D27980: make opengl module support multiple dri devices

zzag added a comment. I'm not sure whether this is useful, but libdrm has an API to enumerate devices. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27980 To: sitter Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, z

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/11/20 10:45 AM, Kai Uwe Broulik wrote: It appears there's a need for a collection/dict API in QImageReader either way. Uh, maybe. At least, applications such as Gwenview need to know the difference between image sequences and image collections in order to display them correctly. Cheers

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/11/20 8:08 AM, David Edmundson wrote: We need to tweak the name as we have many wallpapers that are dynamic. This is a specific subset within that. Yes, agreed! I'm open to suggestions. ;-) Code wise, we have both sun positions and clock skew management in the time dataengine already.

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added inline comments. INLINE COMMENTS > main.qml:36-38 > -if (inhibitor.state != Inhibitor.Uninhibited) { > -return PlasmaCore.Types.ActiveStatus; > } We want to keep the applet visible even if Night Color is inhibited so user can quickly uninhibit it. With th

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a comment. > Fix for NightColor plasmoid active/passive status Could you please describe what's wrong with it right now? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham Cc: plasma-devel, Orage, LeGast

Re: Moving bugzilla components

On 3/11/20 7:11 AM, David Edmundson wrote: As a reminder, bugzilla components should not be moved without prior discussion with maintainers. @nate please inform everyone of the bulk changes made and we'll see which we keep. David What components were moved?

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/10/20 1:27 PM, Kai Uwe Broulik wrote: There's QImageIOHandler::Description which can store arbitrary text data in an image. You reckon QImageIOHandler could be extended to support whatever metadata you need to read/write? Yes, it would be fine for our specific use case. We're interested o

Proposal: Dynamic Wallpapers in Plasma

Hi, I would like to propose a dynamic wallpaper plugin for KDE Plasma [1]. As the name suggests, the plugin updates the background continuously to reflect the user's current light situation. Besides being eye-candy, it can be useful for a Night Mode (if Plasma gets one). The HEIF file format

D27869: Separate processcore/{formatter,unit} into its own library

zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in unit.h:81 > Blame @zzag for that who wrote the original code. :P > > That said, we probably should consider how to deal with localization issues > like that at some point in the future. Oops, sorry. REPOSITORY R111 KSysguard L

Problems in KWayland causes by API and ABI compatibility promises

Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design choice

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. > WARNING: I have no idea whether KDE Plasma 5.19 is going to depend on Qt 5.15. KDE Plasma 5.19 will depend on Qt 5.14. :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Ora

Re: Plasma 5.18 release post-mortem

On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos. I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug is before it even happens. Even for small com

D27237: [Background Finder] Create a valid invocation token

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ae0fafe23700: [Background Finder] Create a valid invocation token (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27237?vs=75232&id=7543

D27237: [Background Finder] Create a valid invocation token

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY According to Qt docs, QUuid() creates a null UUID object. TEST PLAN N/A, plasmashell is very unstable wi

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74622. zzag added a comment. Drop UseWMMoveResize option. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74619&id=74622 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES kstyle/breeze.kcfg ks

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74619. zzag added a comment. Get rid of _cursorOverride REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74617&id=74619 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES kstyle/breezewindowmanage

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. https://www.youtube.com/watch?v=tPh7U9otpy4 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D27004: [kstyle] Drop XCB and KWayland dependency

zzag created this revision. zzag added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY They are not used anywhere. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag created this revision. zzag added reviewers: KWin, Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY QWindow::startSystemMove() is a new feature in Qt 5.15 that provides a platform-ind

  1   2   3   >