[Differential] [Commented On] D4070: Changes to global menu applet

2017-01-11 Thread Kai Uwe Broulik
broulik added a comment. I just noticed when I change the setting in the KCM the icon changes to the warning icon but the button stays enabled, only if I restart plasma the button is disabled INLINE COMMENTS > appmenuapplet.h:69 > +bool appletEnabled() const; > +void updateAppletEna

[Differential] [Commented On] D4070: Changes to global menu applet

2017-01-11 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > appmenuapplet.h:36 > > +Q_PROPERTY(bool useApplet READ useApplet NOTIFY useAppletChanged) > + Maybe "applicationMenuAppletEnabled" or something like that? > main.qml:76 > + > +PlasmaCore.ToolTipArea { > + visible: !useAp

[Differential] [Commented On] D4070: Changes to global menu applet

2017-01-10 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > appmenuapplet.cpp:44 > // TODO Wayland PlasmaShellSurface stuff > +QDBusConnection::sessionBus().connect(QStringLiteral("com.kde.kappmenu"), > + QStringLiteral("/KAppMenu"), I was wondering if we c

[Differential] [Commented On] D4070: Changes to global menu applet

2017-01-10 Thread Kai Uwe Broulik
broulik added a comment. > When applet is placed in a vertical panel force use the compact view. Why? We can show the buttons below each other if the user wants to INLINE COMMENTS > appmenuapplet.cpp:109 > + > +void AppMenuApplet::setUseApplet() > +{ I think update instead of set is bet