Re: Battery applet and KIcon

2010-02-15 Thread Marco Martin
On Monday 15 February 2010, Zack Rusin wrote: On Sunday 14 February 2010 18:24:51 Marco Martin wrote: QRectF makeUniform(const QRect orig, const QRect dst) oring and dist shouldn't them be QRectF in the signature? only if we care about it being anywhere close to

Re: Battery applet and KIcon

2010-02-15 Thread Marco Martin
On Sunday 14 February 2010, Aaron J. Seigo wrote: so what i propose is the following: use the svg for the battery as now, -but- if we are rendering at a certain size, and the element in the svg we want to render is battery search another one with the proper prefix, for instance

Battery applet and KIcon

2010-02-14 Thread Riccardo Iaconelli
Iaconelli ricca...@kde.org Date: Sun, 14 Feb 2010 15:25:47 +0100 Subject: [PATCH] first modifications to convert the battery applet to KIcon Signed-off-by: Riccardo Iaconelli ricca...@kde.org --- plasma/generic/applets/battery/battery.cpp | 33 ++- 1 files changed, 12

Re: Battery applet and KIcon

2010-02-14 Thread Aaron J. Seigo
On February 14, 2010, Riccardo Iaconelli wrote: Hello, to follow up on a message i sent some time ago, I started to convert the battery applet to make it use KIcon. =) a) use reviewboard b) since when have we abandoned scalable interfaces? (nobody uses it larger than 64 pixels, and we will

Re: Battery applet and KIcon

2010-02-14 Thread Marco Martin
On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, Riccardo Iaconelli wrote: Hello, to follow up on a message i sent some time ago, I started to convert the battery applet to make it use KIcon. =) a) use reviewboard b) since when have we abandoned scalable

Re: Battery applet and KIcon

2010-02-14 Thread Aaron J. Seigo
On February 14, 2010, you wrote: On Sunday 14 February 2010 18:59:32 Aaron J. Seigo wrote: b) since when have we abandoned scalable interfaces? (nobody uses it larger than 64 pixels, and we will generate a 256px icon; seriously?) SVG is *not* scalable. given that's what the 's' stands

Re: Battery applet and KIcon

2010-02-14 Thread Aaron J. Seigo
On February 14, 2010, Marco Martin wrote: On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, Riccardo Iaconelli wrote: Hello, to follow up on a message i sent some time ago, I started to convert the battery applet to make it use KIcon. =) a) use reviewboard

Re: Battery applet and KIcon

2010-02-14 Thread Marco Martin
On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, Marco Martin wrote: On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, Riccardo Iaconelli wrote: Hello, to follow up on a message i sent some time ago, I started to convert the battery

Re: Battery applet and KIcon

2010-02-14 Thread Marco Martin
On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, you wrote: On Sunday 14 February 2010 18:59:32 Aaron J. Seigo wrote: b) since when have we abandoned scalable interfaces? (nobody uses it larger than 64 pixels, and we will generate a 256px icon; seriously?) SVG

Re: Battery applet and KIcon

2010-02-14 Thread Riccardo Iaconelli
On Sunday 14 February 2010 20:43:15 Aaron J. Seigo wrote: SVG is not scalable. given that's what the 's' stands for in 'svg', this statement is ironic. (not to mention wrong) Then we're all crazy working at small sized icons, aren't we? Why don't we just scale the oh-so-scalable svg? For

Re: Battery applet and KIcon

2010-02-14 Thread Zack Rusin
On Sunday 14 February 2010 15:33:04 Marco Martin wrote: for a really generic thing, i fear something would be needed at the level of QSvg. and always will have some approximate results. QSvg should do something like: -when rendering a shape, always adjust its bounding rect to the pixel grid.

Re: Battery applet and KIcon

2010-02-14 Thread Nuno Pinheiro
On Sunday, 14 de February de 2010 20:58:40 Marco Martin wrote: On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, you wrote: On Sunday 14 February 2010 18:59:32 Aaron J. Seigo wrote: b) since when have we abandoned scalable interfaces? (nobody uses it larger

Re: Battery applet and KIcon

2010-02-14 Thread Nuno Pinheiro
On Sunday, 14 de February de 2010 19:45:17 Aaron J. Seigo wrote: On February 14, 2010, Marco Martin wrote: On Sunday 14 February 2010, Aaron J. Seigo wrote: On February 14, 2010, Riccardo Iaconelli wrote: Hello, to follow up on a message i sent some time ago, I started to convert

Re: Battery applet and KIcon

2010-02-14 Thread Nuno Pinheiro
On Sunday, 14 de February de 2010 23:24:51 Marco Martin wrote: On Sunday 14 February 2010, Zack Rusin wrote: On Sunday 14 February 2010 15:33:04 Marco Martin wrote: for a really generic thing, i fear something would be needed at the level of QSvg. and always will have some

Re: Battery applet and KIcon

2010-02-14 Thread Zack Rusin
On Sunday 14 February 2010 18:24:51 Marco Martin wrote: QRectF makeUniform(const QRect orig, const QRect dst) oring and dist shouldn't them be QRectF in the signature? only if we care about it being anywhere close to correct. definitely should :) ok, let's see if i got what