D10362: Change reveal password button logic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb18347e4dea: Change reveal password button logic (authored by GB_2). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65592&id=65681 REV

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585&id=65592 BRANCH arcpatc

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551&id=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65551. GB_2 added a comment. Use `length` property and stop revealing password if field is empty REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65541&id=65551 BRANCH arcpatch-D10362 REVISION

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65541. GB_2 added a comment. Fix diff REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65540&id=65541 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 AFFECTED FILE

D10362: Change reveal password button logic

GB_2 updated this revision to Diff 65540. GB_2 added a comment. This revision is now accepted and ready to land. Change `onPressedChanged` back to `onClicked` and only show the button when there is text inside the TextField, like in the PolKit dialog REPOSITORY R242 Plasma Framework (Librar

D10362: Change reveal password button logic

ngraham added a comment. In D10362#488571 , @ndavis wrote: > In D10362#488389 , @ngraham wrote: > > > I think the idea is that you're not supposed to be typing with the characters visible as you typ

D10362: Change reveal password button logic

ndavis added a comment. In D10362#488389 , @ngraham wrote: > I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. I u

D10362: Change reveal password button logic

ngraham added a comment. I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. If you're in an environment where security concerns are sufficiently low as to permit this, it

D10362: Change reveal password button logic

ndavis added a comment. In D10362#202435 , @starbuck wrote: > Would further be also likely more consistent with other toggles in the future, like imagined on mobile "wifi crossed out=disabled", etc. The difference between the WiFi toggle

D10362: Change reveal password button logic

ndavis added a comment. -1 for the current version How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button? -0.75 for the previous version of the patch We normally show the action that will happen when a button is

D10362: Change reveal password button logic

GB_2 added a comment. Ping REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, n

D10362: Change reveal password button logic

GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature li