D11289: checkable FormLayout items

2018-04-09 Thread Julian Wolff
This revision was automatically updated to reflect the committed changes. Closed by commit R169:6ac4e62002ae: checkable FormLayout items (authored by progwolff). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11289?vs=29937=31751 REVISION DETAIL

D11289: checkable FormLayout items

2018-03-19 Thread Julian Wolff
progwolff updated this revision to Diff 29937. progwolff marked 3 inline comments as done. progwolff added a comment. - split buddyComponent and checkableBuddyComponent - toggle checkbox on shortcut activated REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11289: checkable FormLayout items

2018-03-19 Thread Julian Wolff
progwolff planned changes to this revision. progwolff added a comment. In D11289#229340 , @mart wrote: > can you provide screenshots as well t see how does it look? I added one under "test plan". INLINE COMMENTS > mart wrote in

D11289: checkable FormLayout items

2018-03-19 Thread Marco Martin
mart added a comment. can you provide screenshots as well t see how does it look? INLINE COMMENTS > FormLayout.qml:185 > id: buddyComponent > -Kirigami.Heading { > +CheckBox { > id: labelItem what i'm concerned is that this makes every field a checkbox,

D11289: checkable FormLayout items

2018-03-13 Thread Julian Wolff
progwolff created this revision. progwolff added reviewers: VDG, Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY In some cases, form items go together with a