D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 66260. Pitel added a comment. Reabse & polish UI REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=31036=66260 BRANCH fixedSizeOverride2 REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED

D11410: [RFC] Add option to make applet fixed width

mart added a comment. any updates on this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11410: [RFC] Add option to make applet fixed width

mart added a comment. we're here, mergein few days when 5.13 freezes and 5.14 branch opens REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 31036. Pitel added a comment. Fix tooltip text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30728=31036 BRANCH fixedSizeOverride REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED FILES

D11410: [RFC] Add option to make applet fixed width

Pitel added inline comments. INLINE COMMENTS > mart wrote in ConfigOverlay.qml:385 > this will probably need as well > currentApplet.applet.pluginName == "org.kde.plasma.panelspacer" > > or it gets lost when the spacer is configured as not expanding and i guess > the spacer is special and we

D11410: [RFC] Add option to make applet fixed width

mart added a comment. almost there :) I have a couple of points, then it can go :) INLINE COMMENTS > ConfigOverlay.qml:385 > +iconSource: "distribute-horizontal-x" > +visible: currentApplet.expandingApplet > +tooltip: i18n("Make

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 30728. Pitel added a comment. - Remove QtQuick.Controls import (was needed only by Checkbox) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30555=30728 BRANCH fixedSizeOverride REVISION DETAIL

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 30555. Pitel added a comment. - Replace checkbox with a checkable button - Add support for panel spacer -- currently we just check whether the applet is panel spacer and if it is we use `applet.configuration.expanding` instead of our `fixedSizeOverride`.

D11410: [RFC] Add option to make applet fixed width

mart added a comment. In D11410#229494 , @Pitel wrote: > In D11410#229277 , @mart wrote: > > > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer,

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 29940. Pitel added a comment. In D11410#229277 , @mart wrote: > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as

D11410: [RFC] Add option to make applet fixed width

mart added a comment. it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as would need to inject into the applet's contextualactons, so let's forget about it for now. one thing that could be done is

D11410: [RFC] Add option to make applet fixed width

Pitel added a comment. Also do we want this or two options instead: - no expanding: `maximumWidth = preferredWidth`, and - no shrinking: `minimumWidth = preferredWidth`? Because when attempting to use `fillWidth = false` with full version of task manager it will probably overflow

D11410: [RFC] Add option to make applet fixed width

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY @hein refused D10944 with wish to move the config option to