D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. A few more code comments that I missed in the first go-around, sorry. Behavior-wise, I think this is a huge improvement! INLINE COMMENTS > WidgetExplorer.qml:155 > } > + > /* whitespace change :) > WidgetExplorer.qml:236 > +} else { > +

D12855: Move Widget search field to its own row so it doesn't get compressed

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34158. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Units changed to `gridUnits` instead of `smallSpacing`; whitespace cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://p

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > WidgetExplorer.qml:235 > +} else { > + newSearchRow.height = units.gridUnit * 2 > } `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way we can derive this height value pro

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 2 inline comments as done and 2 inline comments as done. sharvey added a comment. More revising in progress. Units. Bah humbug. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:203 > Can we use some multiple of `units.smallSpacing` or something here instead of > a hardcod

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34160. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Remove unneeded commented-out code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34158&id=34

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 3 inline comments as not done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way > we can derive this height value programmatically? We from my (albeit l

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 7 inline comments as done and 5 inline comments as done. sharvey added inline comments. INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > We from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon size

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > We from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon size, a font size, or at > the lowest level, DPI. > > The API page for `Un

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:389 > Looks like it's still there? Not a huge deal, but it would be good to figure > out why your changes keep adding or removing whitespace. F5848538: Screenshot_20180

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 13 inline comments as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > I mean, could we do something like `newSearchRow.height = searchInput.height > + (units.smallSpacing * 2)` or something like that? Would that work? > > Now that

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. Well this looks good to me. Let's let some of the Plasma devs have a say in the matter now! INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > A method to my madness! The size is there so the search bar announces its > arrival by expanding the row, pushing

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (Please don't land this until at least one Plasma developer has also approved it) REPOSITORY R119 Plasma Desktop BRANCH new-search-row (branched from master) REVISION DETAIL https

D12855: Move Widget search field to its own row so it doesn't get compressed

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > WidgetExplorer.qml:275 > +// full width borrowed from panel definition > +width: Math.max(headi

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34761. sharvey marked an inline comment as done. sharvey added a comment. - Merge branch 'master' into new-search-row - Revise QML using relative sizing & spacing instead of fixed values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > davidedmundson wrote in WidgetExplorer.qml:275 > This is all a bit weird. > > This searchBarContainer is 0 px tall as it's not set to be the size of the > children. which is why you need to do that topM

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added a comment. F5865709: Screenshot_20180523_180214.png @davidedmundson (and/or others) - what's the most-correct and most-effective QML method to add a bit of padding around these elements? I know

D12855: Move Widget search field to its own row so it doesn't get compressed

davidedmundson added a comment. Much nicer > what's the most-correct and most-effective QML method to add a bit of padding around these elements? if you're using anchors, which I think is the case here TextField { anchors.top: topBar.bottom anchors.topMargin: someAm

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. Should ‘someAmazingValue’ be an explicit number (like (x) pixels), or something like ‘units.smallValue’ (or whatever the correct syntax is)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34767. sharvey added a comment. - Add `units.smallSpacing` as margins around search bar row REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34761&id=34767 BRANCH new-search-row (branched from master)

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey added a comment. F5865966: Screenshot_20180523_223641.png Two quick injections of `units.smallSpacing` for margins and we have a nice sleek display with no overlap. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. @davidedmundson does this look okay now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, s

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. @davidedmundson ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08983522bfb4: Move Widget search field to its own row so it doesn't get compressed (authored by sharvey). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1285