D13095: Scren brightness follow a quatratic progression

romangg added a comment. Please create a table with what would happen when. To me it sounds like something would not work out in the end, but I can be wrong. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc:

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. In D13095#473975 , @kjslag wrote: > > Well it's not me that matters; it's all the other people with weird screens like mine, as well as the prople whose screens don't do this. We need to wither come up with a solution

D13095: Scren brightness follow a quatratic progression

kjslag added a comment. > Well it's not me that matters; it's all the other people with weird screens like mine, as well as the prople whose screens don't do this. We need to wither come up with a solution that works for everyone, or else mark some class of screen as misconfigured so we can

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. In D13095#472946 , @kjslag wrote: > In D13095#467997 , @ngraham wrote: > > > Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen//

D13095: Scren brightness follow a quatratic progression

kjslag added a comment. In D13095#467997 , @ngraham wrote: > Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen// right? I don't see why. It seems better to put the screen into a low energy mode

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. In D13095#467779 , @romangg wrote: > In D13095#279659 , @thsurrel wrote: > > > - accept to break some systems (but who wants that ?) > > > If these systems' breakage

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen// right? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc: kjslag, sharvey, zzag, ngraham, romangg,

D13095: Scren brightness follow a quatratic progression

kjslag added a comment. @romangg The current code selects from a discrete set of brightness levels which starts at zero. I was suggesting just removing the zero brightness level and using the next level as the minimum brightness level. I didn't realize turning off the screen at the

D13095: Scren brightness follow a quatratic progression

romangg added a comment. In D13095#279659 , @thsurrel wrote: > - accept to break some systems (but who wants that ?) If these systems' breakage is because of an erroneous kernel driver, we can accept it. My system goes with brightness

D13095: Scren brightness follow a quatratic progression

kjslag added a comment. I like the idea of this patch. I just reassigned my brightness hotkeys to a small script that does almost exactly what this patch does before I discovered this patch. In order to deal with Nate's problem, perhaps instead of starting with brightness=0, we could

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. A couple of random ideas: - The Arch Wiki has a lengthy page on screen brightness. Maybe there's something there that can help. - Is there a valid use case for going all the way to zero? Minimum doesn't

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. I don't think we want the possibility of breaking anyone. A setting doesn't seem ideal either; who would ever find and change this? Rather, let's focus on the issue that's hurting us here to see if we can resolve it somehow. Is there any way to programmatically

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. > Same values as `/sys/class/backlight/*/brightness`, in other words. Thanks Nate, even if that's not the answer I was hoping for ... The future of this patch: - accept to break some systems (but who wants that ?) - add an option for this quadratic

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. Lowest setting: $ cat /sys/class/backlight/intel_backlight/actual_brightness 0 Next setting: $ cat /sys/class/backlight/intel_backlight/actual_brightness 2 Same values as `/sys/class/backlight/*/brightness`, in other words. REPOSITORY

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. It seems I have some system rebuilding to do first. I'm not up for tackling it tonight. I'll work on it in the morning and try to get you some more data. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma,

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. In D13095#277963 , @thsurrel wrote: > Hi Scott, thanks for the help! > If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Hi Scott, thanks for the help! If you can apply the patch, we could see if you have the same behavior than Nate with his hardware: when setting a very low value (for him, it's in the range 1 to 5) to /sys/class/backlight//brightness his screen does not turn on at

D13095: Scren brightness follow a quatratic progression

sharvey added a comment. Hope you don't mind me jumping in - I'm another one of Nate's protegees... here's some data for you. These values are before your patch. Let me know if you'd like me to apply your patch and redo the testing. 0 (lowest) 75 (backlight on) 150 225

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Hi Nate, sorry I'm asking you one more thing before giving up on this patch (even though I find it really useful for my personal use). When your screen is off, with a brightness value of 4 for example, could you tell me what is the value reported in

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. My backlight turns on at 6. It's off at 5. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc: zzag, ngraham, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Thanks Nate. If your screen does not turn on while passing from 0 to 2, than this patch is in trouble ... Could you tell me at what value your screen does turn on for the first time, starting from 0 (by writing values directly in /sys/class/backlight//brightness)

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. Max brightness: 937 Individual brightness levels per key-press: 0 (lowest setting) 2 9 21 37 59 84 115 150 190 234 283 337 396 459 527 600 677 759 846 937 (highest setting)

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Could you provide the value of the system brightness after each key press (cat /sys/class/backlight/*/brightness) as well as the maximun brightness of your hardware (cat /sys/class/backlight/*/max_brightness) ? I know, I'm asking you to work with a black screen

D13095: Scren brightness follow a quatratic progression

zzag added inline comments. INLINE COMMENTS > powerdevilbrightnesslogic.cpp:135 > +return value * 100.0 / m_valueMax; > +} else { > +return valueToStep(value) * 100.0 / m_steps; Coding style nitpick: don't use "else" after a return statement. Same down below.

D13095: Scren brightness follow a quatratic progression

thsurrel updated this revision to Diff 34825. thsurrel added a reviewer: Plasma. thsurrel added a comment. Added context REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13095?vs=34812=34825 REVISION DETAIL https://phabricator.kde.org/D13095 AFFECTED

D13095: Scren brightness follow a quatratic progression

romangg added a comment. Pls add context and reviewer Plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13095: Scren brightness follow a quatratic progression

thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Modern hardware allow to adjust the screen brightness very precisely, with more than hundreds