D14855: Add applet with screen layouts and presentation mode

dhaumann added a comment. @broulik Could we clarify the copyright? INLINE COMMENTS > kscreenapplet.h:3-4 > + * Copyright (c) 2018 Kai Uwe Broulik > + *Work sponsored by the LiMux project of > + *the city of Munich. > + * Hi Kai. Imo this copyright is

D14855: Add applet with screen layouts and presentation mode

This revision was automatically updated to reflect the committed changes. Closed by commit R104:b4baa322c361: Add applet with screen layouts and presentation mode (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14855?vs=40245=40434#toc REPOSITORY R104 KScreen

D14855: Add applet with screen layouts and presentation mode

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. OK, let's do it :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy, gladhorn Cc: anthonyfieroni,

D14855: Add applet with screen layouts and presentation mode

abetts added a comment. Love! Love! <3 Thanks for working on it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot,

D14855: Add applet with screen layouts and presentation mode

ngraham added a comment. +1 on the UI now. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: anthonyfieroni, ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14855: Add applet with screen layouts and presentation mode

broulik updated this revision to Diff 40245. broulik edited the test plan for this revision. broulik added a comment. - Fixup wording - Improve layout of Presentation Mode checkbox REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14855?vs=40088=40245

D14855: Add applet with screen layouts and presentation mode

anthonyfieroni added a comment. @broulik, i'm pretty sure that it has a review that enable accessing OSD by mouse, can you investigate and ship it. I'm not against this but accessing OSD by mouse is pretty good feature after all. REPOSITORY R104 KScreen REVISION DETAIL

D14855: Add applet with screen layouts and presentation mode

broulik added a comment. Then please make a final layout image that I can change my work to, preferably not being *completely* different from what I have now … also, the headings are smaller than e.g. System Tray's "Status and Notifications" heading REPOSITORY R104 KScreen REVISION

D14855: Add applet with screen layouts and presentation mode

ngraham added a comment. Maybe, but right now it's being oppressed to death by huge headers! :) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel,

D14855: Add applet with screen layouts and presentation mode

broulik added a comment. The presentation mode doesn't really relate to the layouts that's why I put the headings in there. Just placing a checkbox there will make it drown underneath the layout buttons REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To:

D14855: Add applet with screen layouts and presentation mode

ngraham added inline comments. INLINE COMMENTS > main.qml:44 > +// does this need an ellipsis? > +readonly property string kcmLabel: i18nc("Open the full display settings > module", "Advanced Display Settings...") > +readonly property string kcmIconName:

D14855: Add applet with screen layouts and presentation mode

abetts added a comment. In D14855#312321 , @ngraham wrote: > Instead of: > > Presentation mode > This will prevent your screen and computer from turning off automatically >[] Enable Presentation Mode > > > I would prefer to

D14855: Add applet with screen layouts and presentation mode

ngraham added a comment. Instead of: Presentation mode This will prevent your screen and computer from turning off automatically [] Enable Presentation Mode I would prefer to get rid of some redundancy and instead do one of these: [] Enable Presentation Mode

D14855: Add applet with screen layouts and presentation mode

broulik updated this revision to Diff 40088. broulik added a comment. - Share monitor preset code between OSD and applet REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14855?vs=39779=40088 REVISION DETAIL https://phabricator.kde.org/D14855 AFFECTED

D14855: Add applet with screen layouts and presentation mode

mart added a comment. would this applet be on by default? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14855 To: broulik, #plasma, #vdg, fischbach, harmathy Cc: mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14855: Add applet with screen layouts and presentation mode

broulik added inline comments. INLINE COMMENTS > gladhorn wrote in daemon.h:66 > Could this be unified in some nice way with the above function > (applyOsdAction) which does the same based on the enum...? Maybe just use the > enum, or is there a reason for using a string here but not in other

D14855: Add applet with screen layouts and presentation mode

gladhorn added a comment. This looks generally nice, I like it. Since we're short on people maintaining this stuff, I'd like more of the code to be shared though. INLINE COMMENTS > daemon.h:66 > +// DBus > +void applyLayoutPreset(const QString ); > Q_SIGNALS: Could

D14855: Add applet with screen layouts and presentation mode

abetts added a comment. On the first string I would change the wording: "Configurations become enabled when another screen is connected" The second string could read: "It will prevent the screen from turning off" (automatically = optional) REPOSITORY R104 KScreen REVISION

D14855: Add applet with screen layouts and presentation mode

broulik updated this revision to Diff 39779. broulik added a comment. - Use "application enforce presentation mode" to communicate better that the checkbox might be overruled REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14855?vs=39763=39779 REVISION

D14855: Add applet with screen layouts and presentation mode

broulik created this revision. broulik added reviewers: Plasma, VDG, fischbach. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One of LiMux client's requirements is for display configuration to be easily