This revision was automatically updated to reflect the committed changes.
Closed by commit R126:14198396c974: Fix logic error in kioclient noninteractive
argument handling (authored by davidedmundson).
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I'm not sure anymore what the best default is. There are two different use
cases, that's all.
REPOSITORY
R126 KDE CLI Utilities
BRANCH
master
REVISION DETAIL
https://phabricator.kde
davidedmundson updated this revision to Diff 47922.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.
update
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17652?vs=47894&id=47922
BRANCH
master
REVISION DETAIL
davidedmundson added a comment.
> Why would we want to break compatibility yet again? ;-)
It's the better default.
I've removed the TODO, but I've deliberately not said which is default in the
--help output which hopefully will encourage people to still type
--noninteractive if they g
dfaure added a comment.
Looks good except for the TODO comment. I think the comment that is actually
needed is one about why we have a "noninteractive" option and it has no effect
whatsoever ;)
INLINE COMMENTS
> kioclient.cpp:278
> +// interactive used to be the default, but due to
davidedmundson updated this revision to Diff 47894.
davidedmundson added a comment.
Make non-interactive default
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17652?vs=47760&id=47894
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
broulik added a comment.
> note how it said "ninteractive", the "no" was toggling the value).
I assumed it was a typo. Yay :)
REPOSITORY
R126 KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D17652
To: davidedmundson, #plasma, nerdopolist, dfaure
Cc: broulik, plasma-dev
dfaure added a comment.
Good find. However for users who didn't want a progress dialog, and who never
got a conflict (e.g. if they were copying into an empty dir), kioclient was
non-interactive, so I think our previous reasoning still holds.
REPOSITORY
R126 KDE CLI Utilities
REVISION DETA
davidedmundson added a comment.
There's a new twist!
Even in non interactive mode we still got dialogs for file conflicts. See
https://phabricator.kde.org/D17703
Because of this the current state isn't non-interactive. It's a horrible mess
of both.
Whatever we do will result in a
dfaure added a comment.
No, the commit in 2006 wasn't buggy. There was special logic in KCmdLineArgs
for the case of the "no" prefix (note how it said "ninteractive", the "no" was
toggling the value). This is a porting error when going from KCmdLineArgs to
QCommandLineParser.
So it's "only
davidedmundson added a comment.
That's a good point. So we would have an interactive flag and a working
noninteractive flag, but change the default to be non-interactive so that the
no args case remains the same?
I'll tag David Faure (given his plane didn't crash after
39f61b5114ef8352
broulik added a comment.
Given this has been broken for more than a decade (original commit from 2006
already had this bug), I think all users of this binary rely on the fact that
calling `kioclient5` with no arguments is non-interactive and doesn't cause and
blocking or waiting for user inp
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If noninteractive /is/ set s_interactive should be false.
When s_interactiv
13 matches
Mail list logo
