D18244: Check for python-cairo

cgiboudeaux added a comment. In D18244#394859 , @rikmills wrote: > This breaks NeonKubuntu builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not.

D18244: Check for python-cairo

rikmills added a comment. This breaks Neon builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not. https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull

D18244: Check for python-cairo

This revision was automatically updated to reflect the committed changes. Closed by commit R98:fda7d4375883: Check for python-cairo (authored by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49627&id=49641 REVISION DETAIL ht

D18244: Check for python-cairo

cgiboudeaux added a comment. +1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham, cgiboudeaux Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D18244: Check for python-cairo

davidedmundson updated this revision to Diff 49627. davidedmundson added a comment. move set(python_exec) into relevant scope REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49525&id=49627 REVISION DETAIL https://phabricator.kde.org/D18244

D18244: Check for python-cairo

cgiboudeaux added inline comments. INLINE COMMENTS > zzag wrote in FindPythonCairo.cmake:6 > Shouldn't it be right after find_package(Python3)? Correct, or this will be empty with CMake < 3.12 REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244

D18244: Check for python-cairo

zzag added inline comments. INLINE COMMENTS > FindPythonCairo.cmake:6 > +endif() > +set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}") > + Shouldn't it be right after find_package(Python3)? REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 To: d

D18244: Check for python-cairo

davidedmundson updated this revision to Diff 49525. davidedmundson added a comment. update REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49448&id=49525 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 AFFECTED FILES

D18244: Check for python-cairo

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonCairo.cmake:8 > +# Check for python cairo > +execute_process(COMMAND ${PYTHON_EXECUTABLE} -c "import cairo" > +RESULT_VARIABLE PYTHON_CAIRO_RESULT) FindPython3.cmake doesn't define PYTHON_EXECUTABLE but Python3_EXECUT

D18244: Check for python-cairo

davidedmundson added a comment. Which change of that is relevant? REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBo

D18244: Check for python-cairo

zzag added a comment. Well, something like this works fine, though this is a quick and dirty solution. if (CMAKE_VERSION VERSION_LESS 3.12.0) find_package (PythonInterp 3 REQUIRED) set (_py_exe ${PYTHON_EXECUTABLE}) else () find_package (Python 3.0 REQUIRED C

D18244: Check for python-cairo

ngraham added a comment. $ (arcpatch-D18244) cmake -DCMAKE_INSTALL_PREFIX=/usr -DPYTHON_EXECUTABLE=/usr/bin/python3 . -- The following RUNTIME packages have been found: * GTKEngine, Pixmap/Pixbuf theme engine for GTK 2, Required for GTK 2 theme

D18244: Check for python-cairo

davidedmundson added a comment. and/or change python_executable to Python3_EXECUTABLE REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham Cc: ngraham, zzag, plasma-devel, sukalyanbanga, jraleigh, GB_2, rag

D18244: Check for python-cairo

davidedmundson added a comment. @zzag could you run with cmake -DPYTHON_EXECUTABLE=/usr/bin/python3 REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham Cc: ngraham, zzag, plasma-devel, sukalyanbanga,

D18244: Check for python-cairo

ngraham added a comment. In D18244#392953 , @zzag wrote: > For me it fails even though I have python-cairo installed, e.g. > >$ python >Python 3.7.2 (default, Jan 10 2019, 23:51:51) >[GCC 8.2.1 20181127] on linux >Type "

D18244: Check for python-cairo

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me and CMake code looks good. For now we should probably ship this here for the 5.15 release, but maybe this should also go into ECM and then we can use it from there in subsequ

D18244: Check for python-cairo

zzag added a comment. For me it fails even though I have python-cairo installed, e.g. $ python Python 3.7.2 (default, Jan 10 2019, 23:51:51) [GCC 8.2.1 20181127] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import cairo >>> cair

D18244: Check for python-cairo

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Works correctly when installed Changed cmake locally to "import asdfasdf" Got