D18528: [Desktop Toolbox] Use a clearer name when the label is shown

2019-01-25 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bb3a1fc1828e: [Desktop Toolbox] Use a clearer name when the label is shown (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

2019-01-25 Thread Nathaniel Graham
ngraham updated this revision to Diff 50270. ngraham added a comment. Use an emdash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18528?vs=50265=50270 BRANCH desktop-toolbox-clearer-naming (branched from master) REVISION DETAIL

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

2019-01-25 Thread Björn Feber
GB_2 added a comment. Looks good! INLINE COMMENTS > ToolBoxButton.qml:30 > > -property string text: main.Plasmoid.activityName > +property string text: main.Plasmoid.activityName == i18n("Default") ? > i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", >

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

2019-01-25 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY When the Desktop Toolbox is dragged out of the corner, its label is shown. Currently this