tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.
REVISION SUMMARY
Move public classes to Internal Structs
Make sure we are not accessing something wrong
No need to clear on destruction
S
argonel added inline comments.
INLINE COMMENTS
> SensorBrowser.cpp:51
> +const int id;
> +KSGRD::SensorAgent * sensorAgent;
> +const QString hostName;
This one caused me to notice the style issues. The rule is "For pointers or
references, use a single space before '*' or '&', but no
tcanabrava added inline comments.
INLINE COMMENTS
> argonel wrote in SensorBrowser.cpp:51
> This one caused me to notice the style issues. The rule is "For pointers or
> references, use a single space before '*' or '&', but not after"
ups. that was a typo.
> argonel wrote in SensorBrowser.cpp:
tcanabrava updated this revision to Diff 51655.
tcanabrava added a comment.
- Fix code style
- re-add assert
- Fix code style
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18579?vs=50423&id=51655
BRANCH
CleanSensorBrowser
REVISION DETAIL
https:
zzag added a comment.
> Fix code style
In general, the coding style situation in KSysGuard is a bit sad. I
personally can't trace any distinct coding style, it's basically a mix of every
potential coding style.
We should probably run clang-format and clang-tidy over it some time lat
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Marking as requst changes due till we get the minor comments from zzag done
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D18579
To: t
