D19392: shannon entropy to guess monochrome icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:8306d82f0a61: shannon entropy to guess monochrome icon (authored by mart). CHANGED PRIOR TO COMMIT

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#424581 , @davidedmundson wrote: > > so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6.

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6. It won't magically happen on it's own. I've emailed the XDG mailing

D19392: shannon entropy to guess monochrome icon

mart updated this revision to Diff 52845. mart added a comment. - Merge branch 'master' into mart/iconentropyheuristic - adress some style comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19392?vs=52750=52845 BRANCH mart/iconentropyheuristic

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421950 , @davidedmundson wrote: > > The problem with using -symbolic for all monochrome icons is that we'd have to create color icons without -symbolic to replace the old monochrome icons without -symbolic. >

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > The problem with using -symbolic for all monochrome icons is that we'd have to create color icons without -symbolic to replace the old monochrome icons without -symbolic. Why would breeze need two versions? If an app requests -symbolic you get a

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421923 , @ndavis wrote: > In D19392#421903 , @ngraham wrote: > > > Actually we're discussing in VDG-land whether or not this is something we should do anyway,

D19392: shannon entropy to guess monochrome icon

ndavis added a comment. In D19392#421903 , @ngraham wrote: > Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421903 , @ngraham wrote: > Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size

D19392: shannon entropy to guess monochrome icon

ngraham added subscribers: VDG, ndavis, GB_2, ngraham. ngraham added a comment. In D19392#421900 , @mart wrote: > In D19392#421881 , @davidedmundson wrote: > > > > so, we colorize monochrome icons

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421881 , @davidedmundson wrote: > > so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored (all icon names that end up with -symbolys usually are monochrome, but in breeze and

D19392: shannon entropy to guess monochrome icon

mart added inline comments. INLINE COMMENTS > cfeck wrote in desktopicon.cpp:545 > You are caching the result per size, but the initial decision depends on the > actual icon image, right? Is it possible that the first icon examined is > colorful, but the rest is not, or vice versa? If yes,

D19392: shannon entropy to guess monochrome icon

cfeck added inline comments. INLINE COMMENTS > desktopicon.cpp:522 > +//don't try for too big images > +if (img.width() > 256 || m_theme->supportsIconColoring()) { > +return false; Did you mean `>= 256`? > desktopicon.cpp:545 > +if (findIt !=

D19392: shannon entropy to guess monochrome icon

mart added a comment. the final visual problem is that often i get people complaining are things like icons in a menu or in a list view that have here and there a colored breeze icon that became an unrecognizable black splorch or the opposite problem, a monochrome black icon that is

D19392: shannon entropy to guess monochrome icon

mart added a comment. > Can you elaborate on the problem we're trying to fix. so, when we have KiconLoader (ie using the desktop style and we can rely on kf5 dependencies) to colorize icons we use our stylesheet-based color replacement in svgs and everything is always awesome:

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. Can you elaborate on the problem we're trying to fix. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19392 To: mart, #kirigami Cc: davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein

D19392: shannon entropy to guess monochrome icon

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY since we can't directly access the svg file, when we can't use KIconLoader try to detect monochrome