D19837: Add support for applications in KNSBackend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ffc6023c5412: Add support for applications in KNSBackend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19837?vs=54204&id=5421

D19837: Add support for applications in KNSBackend

leinir updated this revision to Diff 54204. leinir marked 2 inline comments as done. leinir added a comment. Address various comments, and also fix one issue discovered while addressing those REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D19837: Add support for applications in KNSBackend

leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:151 > we can just compare with == here, it will be easier to read. Tru dat... i was just keeping consistency with the long list below, but yeah, at the very least for now we've

D19837: Add support for applications in KNSBackend

apol added inline comments. INLINE COMMENTS > KNSBackend.cpp:151 > > -const auto topLevelName = knsrcPlasma.contains(fileName)? i18n("Plasma > Addons") : i18n("Application Addons"); > -const QUrl decoration(knsrcPlasma.contains(fileName)? > QStringLiteral("https://c2.staticflickr.com/

D19837: Add support for applications in KNSBackend

leinir added a comment. In D19837#433343 , @ngraham wrote: > Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline

D19837: Add support for applications in KNSBackend

ngraham added a comment. Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org. INLINE COMMENTS > KNSB

D19837: Add support for applications in KNSBackend

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch,