D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. The companion patches have landed; this can go in now! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham, abetts Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh,

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 60584. filipf added a comment. highlight effect: remove unused ID and bettery opacity values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60583&id=60584 BRANCH master REVISION DETAIL https://phabr

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 60583. filipf added a comment. Also implement the upcoming highlight style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60115&id=60583 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. In D20908#485103 , @filipf wrote: > Preview of a highlight style in line with what's being discussed in T11124 : > > F6927189: image.png > >

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. Preview of a highlight style in line with what's being discussed in T11124 : F6927189: image.png From a technical POV is it possible to reuse the widgets/tasks SVG here? REPOSITORY R

D20908: RFC: Redesign QML applet configuration windows

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. There we go, much better. F6917696: Screenshot_20190620_151607.png This is so nice. Let's not commit it until @mart's companion patch for B

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 60115. filipf added a comment. fix wrong sidebar width REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60101&id=60115 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES

D20908: RFC: Redesign QML applet configuration windows

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, something's not right anymore: F6917589: Screenshot_20190620_143140.png REPOSITORY R119 Plasma Desktop REVISION DETAIL http

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 60101. filipf added a comment. line 218: width -> implicitWidth REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60100&id=60101 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECT

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 60100. filipf added a comment. rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57680&id=60100 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES deskt

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. This is the rough patch which gives a rough implementation of this look into qwidget config dialogs F6866217: fullsidebar.diff The real hack which I consider a no-go (and no idea how to avoid) is this piece: - layout->ad

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57680. filipf added a comment. Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to Theme.View instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57255&id=57680 BRANCH master R

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In D20908#461487 , @mart wrote: > from the screenshots, i like it a lot,the code seems clean enough. > > However, to continue with that i think some attempt should be done to make qwidget based apps follow this as wel

D20908: RFC: Redesign QML applet configuration windows

abetts added a comment. Love it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham, abetts Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. that's a veeery quick and dirty attempt: (so hacky that there is not really usable code i'm afraid) F6811626: Screenshot_20190506_123026.png apart the lack of right margin, that should be easily fixable, the worst parts seem

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. In D20908#458426 , @broulik wrote: > I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal space

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. from the screenshots, i like it a lot,the code seems clean enough. However, to continue with that i think some attempt should be done to make qwidget based apps follow this as well. (I think we should go on a campaign to remove unnecessary frames here too) with

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. I'm so in love with this new style. it's just astonishingly good-looking. F6801451: Screenshot_20190430_065515.png Once this is in users' hands (in conjunction with no borders by default for Breeze), I predict that we g

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. Fixed. Not sure if the top separator should stay, but I guess it makes more sense if it does: F6801409: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plas

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57255. filipf added a comment. Don't draw sidebar and its separator when there is only 1 category, also add left margin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57227&id=57255 BRANCH master REV

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. Yeah I think keeping the icons on top is nice here since it makes for large click areas. Putting the icon beside the text makes more sense when the number of categories is very large, which isn't normally the case for settings windows. In D20908#458428

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. In D20908#458426 , @broulik wrote: > I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal spa

D20908: RFC: Redesign QML applet configuration windows

broulik added a comment. I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal space? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org

D20908: RFC: Redesign QML applet configuration windows

GB_2 added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

hein added a comment. Looks great to me. Subtle visual refreshs like this are very appreciated, especially when they improve consistency, too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: hein, plasma-devel, jra

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. Beautiful. Now we just need to do it in Breeze too, and turn off those borders when using Breeze window decorations. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham Cc: plasma-devel, jrale

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57227. filipf added a comment. have top separator fill the window's width REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57218&id=57227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D209

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In D20908#458307 , @filipf wrote: > I agree, the sidebar looks a bit lost there. So do you mean to turn on the separator in KWin or add it ourselves like this? > > F6800729: image.png

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. I agree, the sidebar looks a bit lost there. So do you mean to turn on the separator in KWin or add it ourselves like this? F6800729: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In general, this is a change I hugely support. This look for sidebars is already used in System Settings, Discover, and other QML-ish apps. It's attractive and clean, and provides adequate separation between dissimilar elements. Looking at your Breeze Light and

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57218. filipf added a comment. remove unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57217&id=57218 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES

D20908: RFC: Redesign QML applet configuration windows

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This is patch is a sketch meant to open up discussion about redesigning our configuration windows. We currently have insconsiste