D21934: Ensure no one but us writes to stdout

2019-06-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:ee36561ca66f: Ensure no one but us writes to stdout (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21934?vs=60182&id=60290

D21934: Ensure no one but us writes to stdout

2019-06-21 Thread Kai Uwe Broulik
broulik updated this revision to Diff 60182. broulik added a comment. - dup2 REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21934?vs=60145&id=60182 REVISION DETAIL https://phabricator.kde.org/D21934 AFFECTED FILES host/connection.cp

D21934: Ensure no one but us writes to stdout

2019-06-20 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > connection.cpp:39 > +int newStdout = dup(STDOUT_FILENO); > +close(STDOUT_FILENO); > +m_stdOut.open(newStdout, QIODevice::WriteOnly); I'd `dup2(STDER

D21934: Ensure no one but us writes to stdout

2019-06-20 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I originally didn't consider this neccessary because we have a `qMessageHan