D24517: Port kcm cursor to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f53d7844fbb5: Port kcm cursor to KConfigXT (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67948=67951 REVISION DETAIL

D24517: Port kcm cursor to KConfigXT

bport updated this revision to Diff 67948. bport added a comment. Move install line to the good section REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67605=67948 REVISION DETAIL https://phabricator.kde.org/D24517 AFFECTED FILES

D24517: Port kcm cursor to KConfigXT

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Just a last nitpick. INLINE COMMENTS > CMakeLists.txt:24 > +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc > GENERATE_MOC) > +install(FILES

D24517: Port kcm cursor to KConfigXT

bport updated this revision to Diff 67605. bport added a comment. - Install kcfg file - Remove uneeded include from kcfg file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67559=67605 REVISION DETAIL https://phabricator.kde.org/D24517

D24517: Port kcm cursor to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:22 > Can you also add > > install(FILES kded/touchpaddaemon.kcfg > DESTINATION ${KDE_INSTALL_KCFGDIR}) > >

D24517: Port kcm cursor to KConfigXT

bport added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:22 > Can you also add > > install(FILES kded/touchpaddaemon.kcfg > DESTINATION ${KDE_INSTALL_KCFGDIR}) > > This doesn't explicitly do anything useful, but it allows future metadata > extraction

D24517: Port kcm cursor to KConfigXT

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:22 > set(kcm_cursortheme_PART_SRCS kcmcursortheme.cpp ${libnoinst_SRCS}) > - > +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc > GENERATE_MOC) > add_library(kcm_cursortheme MODULE

D24517: Port kcm cursor to KConfigXT

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY - Allow code reuse REPOSITORY R119 Plasma Desktop REVISION DETAIL