D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-15 Thread Benjamin Port
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b2f75f13e0e: Fix a bug in KCM cursor theme, after applying change, cursor preview dont work (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24520?vs=67607=67954#toc

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-10 Thread Benjamin Port
bport updated this revision to Diff 67607. bport added a comment. a cleaner approach to fix the bug REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24520?vs=67562=67607 REVISION DETAIL https://phabricator.kde.org/D24520 AFFECTED FILES

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-09 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Overall this doesn't look like the proper fix to me. A setter should not do anything if we pass the current value to it. From your description it seems to indicate that a call to

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-09 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand this patch in relation to the title. If no-one uses this property this shouldn't make a difference? REPOSITORY R119 Plasma Desktop

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

2019-10-09 Thread Benjamin Port
bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24520 AFFECTED FILES