This revision was automatically updated to reflect the committed changes.
Closed by commit R871:210c9d88fb81: disable bug report when there are signs of
an update (authored by sitter).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25002?vs=68966&id=69320
REV
sitter updated this revision to Diff 68966.
sitter added a comment.
typo--
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25002?vs=68965&id=68966
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25002
AFFECTED FILES
src/backtracewidget.cp
sitter updated this revision to Diff 68965.
sitter added a comment.
switch from list to bool since we don't actually use the list anyway
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25002?vs=68878&id=68965
BRANCH
master
REVISION DETAIL
https://phabr
sitter planned changes to this revision.
sitter added inline comments.
INLINE COMMENTS
> apol wrote in drkonqibackends.cpp:172
> Maybe we don't need to store all of them? I only see it used as "isEmpty()".
I suppose, my plan was actually to list the changed files but I've seen
abandoned that id
sitter added inline comments.
INLINE COMMENTS
> sitter wrote in drkonqibackends.cpp:172
> I suppose, my plan was actually to list the changed files but I've seen
> abandoned that idea because it's largely useless information. I'll change it
> to a bool.
*since abandoned
REPOSITORY
R871 DrKo
apol added inline comments.
INLINE COMMENTS
> drkonqibackends.cpp:172
> +
> +a->m_deletedFiles = deletedPaths;
> +
Maybe we don't need to store all of them? I only see it used as "isEmpty()".
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D25002
To: sitter, #p
sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
this actually improves UX more than anything. when there was an update it
is fairly impossible to i
