D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-12-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:96f485db411c: [Notifications KCM] Show hint if notifications arent available or provided by… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-12-09 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71137. broulik edited the test plan for this revision. broulik added a comment. - Disable controls which won't affect other notification services - Job tracking is independent of notification service REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-12-05 Thread Kai Uwe Broulik
broulik updated this revision to Diff 70981. broulik added a comment. - Use `NotificationManager.ServerInfo` from D25772 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25097?vs=69123=70981 REVISION DETAIL

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-11-01 Thread Kai Uwe Broulik
broulik added a comment. I think it might make sense to move that to libnotification `Server` so the applet can get the same information without duplicating code there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 To: broulik, #plasma, #vdg Cc:

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-10-31 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. Alright, will disable those REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. If there are any settings that have no effect while something else is handling notifications or there's no widget, I think it makes sense to disable those. Other settings that are more universal can stay enabled for sure. REPOSITORY R119 Plasma Desktop REVISION

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-10-31 Thread Kai Uwe Broulik
broulik added a comment. > Would it makes sense to also disable all the controls in the KCM when either of these messages are open? I was wondering that, too, but not sure I want to artificially block those settings. Perhaps for the upper check boxes. Progress reporting is unaffected

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. +1 conceptually. Would it makes sense to also disable all the controls in the KCM when either of these messages are open? INLINE COMMENTS > main.qml:56 > +type: Kirigami.MessageType.Error > +text: i18n("Could not find a 'Notifications'

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

2019-10-31 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I've seen people complaining about ugly notification popups when they were in fact running