D25449: Start of the new Formats KCM

meven added a comment. ping @tcanabrava REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham Cc: meven, ahiemstra, anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, Orage, LeGast0

D25449: Start of the new Formats KCM

ahiemstra added a comment. Note that the interaction model is that way because that's how the system locale works. The KCM sets a bunch of environment variables (LC_ALL and related) which Qt then uses to determine what format to use. These generally correspond to certain country formats. Whi

D25449: Start of the new Formats KCM

ngraham added a comment. More generally, I'm not sure the interaction model of the Detailed Settings part of this KCM (both old and new) makes any sense. Once I choose my global locale, if I want to override individual elements, I want to choose the exact format I want, which I currently can

D25449: Start of the new Formats KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The preview area from the current KCM is missing. In the sheet, the scrollview below the search field seems to be on top of the search field, and the sheet's close button is

D25449: Start of the new Formats KCM

tcanabrava marked 4 inline comments as done. tcanabrava added a comment. F7877402: Screenshot_20200111_155924.PNG With OverlaySheet INLINE COMMENTS > anthonyfieroni wrote in kcm.cpp:41 > https://doc.qt.io/qt-5/qqmlengine-obsolete.html The non obso

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73281. tcanabrava added a comment. - Merge branch 'master' into arcpatch-D25449 - Use OverlaySheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73236&id=73281 BRANCH arcpatch-D25449 REVISION D

D25449: Start of the new Formats KCM

anthonyfieroni added inline comments. INLINE COMMENTS > kcm.cpp:39 > +{ > +qmlRegisterType(); > +qmlRegisterUncreatableType("org.internal.kcm.formats", 1, > 0, "LocaleModel", QStringLiteral("Model to access the data")); https://doc.qt.io/qt-5/qqmlengine-obsolete.html > kcm.cpp:41 > +

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73236. tcanabrava added a comment. - Fix esc and click outside to close the overlay REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73209&id=73236 BRANCH arcpatch-D25449 REVISION DETAIL https://p

D25449: Start of the new Formats KCM

ngraham added a comment. Still needs more overlaySheet :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, j

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73209. tcanabrava added a comment. - Fix some keyboard whoes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73188&id=73209 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D254

D25449: Start of the new Formats KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Got this tested. I'm sorry to say that I really really really really don't like the pop-out drawer-style list at all. It's unlike the way we do pop-up lists anywhere else,

D25449: Start of the new Formats KCM

tcanabrava added a comment. (Ignore my broken Theme - i'm trying to discover what's happening.) F7874644: Screenshot_20200110_121232.PNG F7874646: Screenshot_20200110_121252.PNG REPOSITORY R119 Plasma Desk

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73188. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Remove code dependant on Qt 5.14 - Mark that we will use some text in the future - Remove uneeded virtual - Update role names to something more explicit - Correctly

D25449: Start of the new Formats KCM

tcanabrava marked 23 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:37 > You're not importing this anywhere, and this still works? Makes me wonder why > Qt went through the trouble of introducing this when it makes no diference > over `qmlR

D25449: Start of the new Formats KCM

mart added a comment. design wise i would go this way: left column: A FormLayout with labels and buttons aligned in the usual standard centered way right Column: Either an overlaysheet that opens over everything like the translations kcm, or if you want to keep the drag and drop po

D25449: Start of the new Formats KCM

mart added a comment. tested it: - i have al horizontal scroll of the left column that should never happen: F7874187: Screenshot_20200110_112412.png - opening it in kcmshell tries to resize the window to 100% height of the screen - it tr

D25449: Start of the new Formats KCM

tcanabrava marked an inline comment as done. tcanabrava added a comment. > Imho a custom `ComboBox` with a search field in its popup or something like that would be a better control. I tried to use the combobox (but of course phabricator destroys my history so it's hard to even loo

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73145. tcanabrava added a comment. - Readd writeexports.h REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73135&id=73145 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449

D25449: Start of the new Formats KCM

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:39 > +{ > +qmlRegisterAnonymousType("kcm.kde.org", 1); > +qmlRegisterAnonymousType("kcm.kde.org", 1); this is 5.14 only from which we can't depend

D25449: Start of the new Formats KCM

broulik added a comment. I'm not a huge fan of that language list selection mode, it's unlike anything we use anywhere else. Most importantly, it makes the KCM take *forever* to load as it creates the entire list at once. Instead, you want to use the `ListView` properly so only that part s

D25449: Start of the new Formats KCM

ngraham added reviewers: VDG, Plasma. ngraham added a comment. Doesn't build for me: [ 67%] Building CXX object kcms/spellchecking/CMakeFiles/kcmspellchecking.dir/kcmspellchecking_autogen/mocs_compilation.cpp.o /home/nate/kde/src/plasma-desktop/kcms/formats/kcm.cpp: In constructor

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73135. tcanabrava added a comment. - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73130&id=73135 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449 AFFECTED FILE

D25449: Start of the new Formats KCM

mart added a comment. code-wise looks good now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragr

D25449: Start of the new Formats KCM

ngraham added a comment. Can you please rebase this on current master? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava, ervin Cc: ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampa

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73130. tcanabrava added a comment. - Change how we set locales - Set the locale - Add missing files - Typos - Set the correct size of the list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73

D25449: Start of the new Formats KCM

broulik added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmformats.pot > -rm -f rc.cpp > - > +$EXTRACTRC `find . -name "*.qml"` >> rc.qml || exit 11 > +$XGETTEXT `find . -name "*.qml"` -o $podir/kcm5_formats.

D25449: Start of the new Formats KCM

tcanabrava updated this revision to Diff 73061. tcanabrava added a comment. - Correctly extract qml - Update documentation text - Remove deprecated calls - Correct placement of pointer and reference symbols - Rename variables on kconfigxt and use name and key - Correct constructor -

D25449: Start of the new Formats KCM

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Like the other ones, please use name and key in the entry elements of your kcfg files. INLINE COMMENTS > kcm.cpp:33 > + > +Formats::Formats(QObject* parent, const QVariantList& arg

D25449: Start of the new Formats KCM

davidedmundson added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmformats.pot > +$EXTRACTRC `find . -name "*.ui"` >> rc.cpp || exit 11 > +$XGETTEXT `find . -name "*.cpp"` -o $podir/kcm5_formats.pot this shou

D25449: Start of the new Formats KCM

tcanabrava added a comment. ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25449 To: tcanabrava Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensr

D25449: Start of the new Formats KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Detangle the code, implement models and start the Qml REPOSITORY R119 Plasma Desktop BRANCH kcm_formats REVISION DETAIL