D25772: [Notifications] Add ServerInfo class

2019-12-12 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:147debe3758f: [Notifications] Add ServerInfo class (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=71345=71348 REVISION

D25772: [Notifications] Add ServerInfo class

2019-12-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 71345. broulik added a comment. - Drop `Q_INVOKABLE` - Rename slot - Add missing `ServerInfo` file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25772?vs=70976=71345 REVISION DETAIL

D25772: [Notifications] Add ServerInfo class

2019-12-09 Thread Kai Uwe Broulik
broulik added a comment. In D25772#574317 , @nicolasfella wrote: > I would like to have something like this in KNotifications to be able to check which features/hints the server supports without doing the DBus stuff myself This is

D25772: [Notifications] Add ServerInfo class

2019-12-09 Thread Nicolas Fella
nicolasfella added a comment. I would like to have something like this in KNotifications to be able to check which features/hints the server supports without doing the DBus stuff myself REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25772 To: broulik,

D25772: [Notifications] Add ServerInfo class

2019-12-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > broulik wrote in server_p.cpp:93 > Just noticed I can probably reuse the inhibition service watcher rather than > do a wildcard watch here? Actually not, I misread the code and documentation: > This signal is emitted by the D-Bus server when

D25772: [Notifications] Add ServerInfo class

2019-12-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > server_p.cpp:93 > if (!master) { > -connect(dbusIface, ::serviceUnregistered, > this, [=](const QString ) { > -if (serviceName == notificationService) { > -qCDebug(NOTIFICATIONMANAGER) << "Lost ownership

D25772: [Notifications] Add ServerInfo class

2019-12-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It can be used to query information about the current notification server (vendor, name,