D26530: ScrollView: Do not overlay scrollbars over contents

nicolasfella added a comment. This has caused a regression in the plasma-pa KCM. The scrollview content is now a bit larger than the scrollview itself which results in a horizontal scrollbar appearing F7965068: Screenshot_20200126_181545.PNG

D26530: ScrollView: Do not overlay scrollbars over contents

This revision was automatically updated to reflect the committed changes. Closed by commit R858:06d4bb0e6b86: ScrollView: Do not overlay scrollbars over contents (authored by ahiemstra). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra updated this revision to Diff 73495. ahiemstra added a comment. - Review comments REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26530?vs=73093=73495 BRANCH scrollview_scrollbar_spacing REVISION DETAIL

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. ok for it, provided it still has overlay scrollbars on tablet mode INLINE COMMENTS > ScrollView.qml:47 > + > +readonly property bool _backgroundVisible: background && > background.visible > +readonly property real _verticalScrollBarWidth: >

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. Also, just want to reiterate that I actually don't really care about how things look, what I care about is the amount of workarounds that are introduced by the scrollbar behaviour as it is. One current example is D26586 but I

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. > yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided) The patch as-is does not, what you see is the default scrollview background that I

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#593152 , @mart wrote: > yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided)

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. i'm giving a try to give breeze qstyle that look, then we can revisit this REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma, #goal_consistency, mart Cc: kmaterka, mart, ndavis, IlyaBizyaev,

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#593123 , @ngraham wrote: > In D26530#592999 , @mart wrote: > > > It would already be much better if the track was actually very visible, visually delimiting the space

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#592999 , @mart wrote: > It would already be much better if the track was actually very visible, visually delimiting the space > F7880630: image.png I think it

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#591355 , @ngraham wrote: > Yeah, I really dislike the fully-disappearing scrollbars too, for the same reason. I also like the GNOME approach when overlay-style scrollbars absolutely have to be used. That seems

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#591413 , @ahiemstra wrote: > Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little

D26530: ScrollView: Do not overlay scrollbars over contents

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. In D26530#591641 , @ngraham wrote: > I think this is why the best compromise for desktop usage is to use thick always-visible

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#591622 , @kmaterka wrote: > Example when current way looks bad: D22176 . We can live with that and add margins/padding when needed. Or not :) > > - Old-fashioned

D26530: ScrollView: Do not overlay scrollbars over contents

kmaterka added a comment. Example when current way looks bad: D22176 . We can live with that and add margins/padding when needed. Or not :) - Old-fashioned scrollbars are also bad, they look old and sometimes ugly (especially when list has different

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. All the various pieces of software that use fake overlay-style scrollbars by simply making the track disappear and blend in with the background (e.g. Konsole, Dolphin, Plasma) appear to have successfully fooled everyone into believing that they're real overlay-style

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little more ugly than necessary. This is what it would look like with fixed background

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. Yeah, I really dislike the fully-disappearing scrollbars too, for the same reason. I also like the GNOME approach when overlay-style scrollbars absolutely have to be used. That seems like a genuine innovation. However I've found myself surprised by the volume of

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#590657 , @ngraham wrote: > It might be worth comparing with what other platforms do: > > - Windows: old apps use real separated always-visible scrollbars; new apps use real overlay scrollbars that overlap

D26530: ScrollView: Do not overlay scrollbars over contents

ndavis added a comment. +1 to not using overlay scrollbars on desktop and mimicking their look instead. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma, #goal_consistency Cc: ndavis, IlyaBizyaev, ngraham,

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. It might be worth comparing with what other platforms do: - Windows: old apps use real separated always-visible scrollbars; new apps use real overlay scrollbars that overlap content but disappear when not in use - macOS: all apps use real overlay scrollbars

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In a nutshell: Overlay scroll bars //disappear//. Separated scrollbars //stay visible//. The QQC2 style scrollbars in question stay visible but try to use an overlay style anyway, and to make this work they overlap the scrollview's background but try to avoid

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#590649 , @IlyaBizyaev wrote: > Visually, this looks like a step back to me... Do you also envision Konsole using opaque overlay scrollbars again? Konsole doesn't use overlay style scrollbars; it simply

D26530: ScrollView: Do not overlay scrollbars over contents

IlyaBizyaev added a comment. Visually, this looks like a step back to me... Do you also envision Konsole using opaque overlay scrollbars again? The current scrollbar appearance is quite common on desktop (Telegram and GNOME apps come to mind), so it's not odd/out-of-place by any means.

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a reviewer: Goal: Consistency. ngraham added a comment. From T9126 , the proposal is to use disappearing overlay scrollbars on mobile, and regular/old fashioned separated non-disappearing scrollbars on the desktop. This is what QWidgets apps

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. > every application developer needs to account for the scrollbars Says who? If the standard qqc2 desktop style item delegate and kirigami list delegate take it into account for their padding //reliably// you get 99% covered. > I was assuming mobile was out

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. I think overlay scrollbars just cause more problems than they solve. Basically every application developer needs to account for the scrollbars, rather than just using ScrollView without bothering about it. Additionally, as mentioned, it is inconsistent with all

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. I thought back then we explicitly did not want that? Also, how does this behave on mobile, ie. "transient scrollbars"? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma Cc: broulik,

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This ensures the scrollbar of a ScrollView do not overlap the ScrollView's contents. It