D26895: Introduce an Info Center mode

ovichiro added a comment. In D26895#605603 , @ngraham wrote: > Sounds sensible. Would you like to submit a patch? I don't know how yet. I need to brush up on C++ first. I'll see what I can do in the next few days or weeks. REPOSITORY

D26895: Introduce an Info Center mode

ngraham added a comment. In D26895#605255 , @ovichiro wrote: > Not sure it's my place to do so, but I'd like to make a small comment. > Instead of passing `mode` around and all the `if` statements, wouldn't it be better to have a single

D26895: Introduce an Info Center mode

ovichiro added inline comments. INLINE COMMENTS > main.cpp:68 > +aboutData = KAboutData(QStringLiteral("systemsettings"), > i18n("System Settings"), QLatin1String(PROJECT_VERSION), i18n("Central > configuration center by KDE."), KAboutLicense::GPL, i18n("(c) 2009, Ben > Cooksley")); >

D26895: Introduce an Info Center mode

ovichiro added a comment. Not sure it's my place to do so, but I'd like to make a small comment. Instead of passing `mode` around and all the `if` statements, wouldn't it be better to have a single decision point in `main.cpp`, like a factory class? Use polymorphism and create

D26895: Introduce an Info Center mode

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ca28b62000ff: Introduce an Info Center mode (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74491=74492 REVISION DETAIL

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74491. mart added a comment. - better todo message REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74487=74491 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECTED

D26895: Introduce an Info Center mode

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > SidebarMode.cpp:589 > > -if (introPageVisible) { > -d->activeCategoryRow = -1; > -emit activeCategoryRowChanged(); > -

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74487. mart added a comment. - use mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74481=74487 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECTED FILES

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > main.cpp:81 > > -SettingsBase *mainWindow = new SettingsBase(); > +if (binaryName == QStringLiteral("kinfocenter")) { > +aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter")); You can use mode here REPOSITORY R124

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74481. mart added a comment. - remove usekless qdebug REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74422=74481 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > BaseMode.cpp:32 > #include "ModuleView.h" > - > +#include > class BaseMode::Private { Not needed > mart wrote in ModuleView.cpp:349 > that's a good point. > Tough, at the moment we don't do anything with the statistics in kinfocenter > mode,

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74422. mart marked 6 inline comments as done. mart added a comment. - base behavior on executable name REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74307=74422 BRANCH mart/kinfoCenterMode REVISION

D26895: Introduce an Info Center mode

mart added inline comments. INLINE COMMENTS > meven wrote in ModuleView.cpp:349 > We might want to have a different url scheme like "kinfo" insteat of "kcm" > and "org.kde.kinfocenter" instead of "org.kde.systemsettings" that's a good point. Tough, at the moment we don't do anything with the

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > MenuModel.cpp:26 > #include "MenuItem.h" > - > +#include > not needed > ModuleView.cpp:349 > if (activeModule) { > - > KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") + >

D26895: Introduce an Info Center mode

davidedmundson added inline comments. INLINE COMMENTS > SettingsBase.h:48 > +// This has effect only if set right after the ctor > +void setInfoCenterMode(bool set); > bool queryClose() override; why not an arg in the ctor then? > SettingsBase.h:95 > +MenuItem * homeModule =

D26895: Introduce an Info Center mode

broulik added a comment. Great idea! INLINE COMMENTS > SettingsBase.h:100 > KAboutApplicationDialog * aboutDialog = nullptr; > +bool m_infoCenterMode = false; > }; I would prefer this to be an enum > main.cpp:66 > +if (infoCenterMode) { > +

D26895: Introduce an Info Center mode

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY withthe command line switch -i, start systemsettings loading the KInfoCenter modules and hyerarchy