D28873: Add SwipeNavigator component

cblack abandoned this revision. cblack added a comment. Moving to a GitLab MR REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#672598 , @mart wrote: > what should happen in this case? > F8331924: Screenshot_20200518_114607.png My answer would be "set a minimum window size", though on mobi

D28873: Add SwipeNavigator component

mart added a comment. what should happen in this case? F8331924: Screenshot_20200518_114607.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolo

D28873: Add SwipeNavigator component

mart added a comment. can you add an example about it in /examples ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson,

D28873: Add SwipeNavigator component

ngraham added a comment. Looking fine. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiems

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82965. cblack added a comment. Improve the small toolbar REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=82962&id=82965 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82962. cblack added a comment. Rebase on master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80804&id=82962 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.org/D2887

D28873: Add SwipeNavigator component

mart added a comment. yes, that screenshot is really broken. to me is important that the tabbar tries to take all the space available before doing any eliding. Probably whether starting to elide a lot and make the tabs actually scrollable, will depend case by case depending fro mthe app

D28873: Add SwipeNavigator component

ngraham added a comment. When there isn't room to show all labels, eliding the labels or collapsing the inactive tabs to square-ish icons-only things that are still clickable/touchable would seem to make more sense to me. The above screenshot kind of looks like a visual glitch IMO. REPOSITO

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#671043 , @ngraham wrote: > In that window, there's plenty of space for the component to expand horizontally. I would prefer to avoid scrolling tabs; their interaction is usually not great. It's collapsin

D28873: Add SwipeNavigator component

ngraham added a comment. In D28873#671042 , @mart wrote: > If i make the window narrow enough, that's what happens > F8319940: Screenshot_20200514_164118.png > > perhaps it tabbar should scroll instea

D28873: Add SwipeNavigator component

mart added a comment. If i make the window narrow enough, that's what happens F8319940: Screenshot_20200514_164118.png perhaps it tabbar should scroll instead? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: c

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 80804. cblack added a comment. Adjust tab stylings REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80281&id=80804 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28873: Add SwipeNavigator component

ngraham resigned from this revision. ngraham added a subscriber: squeakypancakes. ngraham added a comment. All right, you've convinced me. As for the appearance, we probably need for that to be defined using styles. IMO the material style should get this very google-looking appearance and

D28873: Add SwipeNavigator component

niccolove added a comment. In D28873#652724 , @mart wrote: > for those that are a sidebar, there is already a standard, agreed upon look, that is being slowly and painfully moved to be adopted, which is: > F8249505: Screenshot_20200420_180317.

D28873: Add SwipeNavigator component

ngraham added a comment. In D28873#653148 , @cblack wrote: > IMO, the affordances of a traditional tab style hint at tabs being editable. This is fairly established: Chrome uses the traditional tab style for its user-manipulatable tabs, while us

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#652727 , @ngraham wrote: > "Lateral navigation" is basically a tabbed view. So to me this looks like a tabbed view with a different UI for the tabs. We've actually needed a tabbed view component for a while: htt

D28873: Add SwipeNavigator component

mart added a comment. In D28873#652747 , @ngraham wrote: > Like you mentioned, don't we want to use the tabbed sidebar view thingy for that? i think it probably depends from the app both from tab numbers and semantics of the app? mayeb

D28873: Add SwipeNavigator component

ngraham added a comment. Like you mentioned, don't we want to use the tabbed sidebar view thingy for that? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg, ngraham Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampa

D28873: Add SwipeNavigator component

mart added a comment. This patch is about having the whole app navigation as a tabbed thing, so more like tabs in a webbrowser than a generic tabview (with frame and all which this shouldn't have) so they are 2 different things: i still think a drop in replacement for a tabview will be nee

D28873: Add SwipeNavigator component

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. "Lateral navigation" is basically a tabbed view. So to me this looks like a tabbed view with a different UI for the tabs. We've actually needed a tabbed view component for a whi

D28873: Add SwipeNavigator component

mart added a comment. In D28873#649459 , @niccolove wrote: > My opinion from the consistency side: I actually think this is a good possibility for the Consistency goal. After some digging around, my opinion is that > > > Tabs should only be

D28873: Add SwipeNavigator component

niccolove added inline comments. INLINE COMMENTS > mart wrote in SwipeNavigator.qml:55 > different tabbars should really depend only on whether it's a mobile device > or not (and be at bottom if mobile): a very small window on desktop is not a > mobile app I think the tabbar should not be at t

D28873: Add SwipeNavigator component

cblack added inline comments. INLINE COMMENTS > mart wrote in Page.qml:238 > again, not convinced we should have this, seems a bit oddly specific it's not uncommon for apps to have one page associated with an ongoing task. examples: - clocks app running a progress indicator in reverse to indica

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 80281. cblack marked 5 inline comments as done. cblack added a comment. Address some feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80259&id=80281 BRANCH cblack/lateral (branched from master) REVIS

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#649570 , @camiloh wrote: > What about having as a view a component that is not a Kirigami.Page? Such as a StackView or a Rectangle. Why not use an attached property to define its title, icon and other props inst

D28873: Add SwipeNavigator component

camiloh added a comment. What about having as a view a component that is not a Kirigami.Page? Such as a StackView or a Rectangle. Why not use an attached property to define its title, icon and other props instead of focing to wrap those components into a kirigami.Page? REPOSITORY R169 Kir

D28873: Add SwipeNavigator component

niccolove added a comment. My opinion from the consistency side: I actually think this is a good possibility for the Consistency goal. After some digging around, my opinion is that > Tabs should only be used on application views that are user-editable (eg: when it's possible to open a n

D28873: Add SwipeNavigator component

mart added inline comments. INLINE COMMENTS > Page.qml:223 > + */ > +property variant icon > + for consistency, should be a private/ActionItemGroup.qml (which mimics the upstream qqc2 api icon.name/source/width/height/color) > Page.qml:238 > + */ > +property var progress: undef

D28873: Add SwipeNavigator component

mart added a comment. The tabbars have their own look, which it's against the consistency goal. I do prefer this look to the current breeze one, but this is a debate to have at the level of the future breeze direction. It's ok in the case of mobile with the tbbar on the bottom as it's a pre

D28873: Add SwipeNavigator component

ndavis added a comment. So are these just all views that run simultaneously like apps on a task bar? What makes this different from tabs? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: ndavis, camiloh, plasma-devel, fbampalouk

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#649388 , @ndavis wrote: > What is the usecase for this? Apps that have shallow and primarily lateral navigation. > The progress tab's page highlight changes width with the percent of progress, correc

D28873: Add SwipeNavigator component

ndavis added a comment. What is the usecase for this? The progress tab's page highlight changes width with the percent of progress, correct? I think it looks wrong like that, unless I'm missing an important bit of context. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 80259. cblack added a comment. Add end-of-file newlines REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80258&id=80259 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.o

D28873: Add SwipeNavigator component

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY SwipeNavigator is a component optimized for lateral page navigation rather than hierarchical pa