D28985: [Kickoff] Disable tabBar's mouseArea when searching

This revision was automatically updated to reflect the committed changes. Closed by commit R119:020c67fc8ba3: [Kickoff] Disable tabBar's mouseArea when searching (authored by trmdi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D28985: [Kickoff] Disable tabBar's mouseArea when searching

ngraham added a comment. Actually not that I think about it, I'd teach you how, but since we're moving to GitLab in a few weeks, it would be a useless skill so I'll just do it now. :) REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff REVISION DETAIL https://phabricator.kde.org/D28985

D28985: [Kickoff] Disable tabBar's mouseArea when searching

trmdi added a comment. In D28985#652097 , @ngraham wrote: > Excellent! > > Please land on the `Plasma/5.18` branch and then merge to master. Let me know if you need a hand with that. Yes, please. I don't know how to do that. REPOSITO

D28985: [Kickoff] Disable tabBar's mouseArea when searching

davidedmundson resigned from this revision. davidedmundson added a comment. Ah, I see. name: "Search" PropertyChanges { target: tabBar opacity: 0 } It's opacity zero, but technically still visible, still enabled and with the same val

D28985: [Kickoff] Disable tabBar's mouseArea when searching

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand. Why is the search page a special case that should affect the tab bar behaviour? REPOSITORY R119 Plasma Desktop REVISION DETAIL https:

D28985: [Kickoff] Disable tabBar's mouseArea when searching

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent! Please land on the `Plasma/5.18` branch and then merge to master. Let me know if you need a hand with that. REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff REVISIO

D28985: [Kickoff] Disable tabBar's mouseArea when searching

bugseforuns added a comment. Patch also working on Neon unstable edition. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28985 To: trmdi, #plasma, hein Cc: bugseforuns, dginovker, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28985: [Kickoff] Disable tabBar's mouseArea when searching

dginovker added a comment. Hi - I'm the original bug reporter, hopefully I'm allowed to comment here. The patch provided works, tested on 2 machines running Manjaro KDE :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28985 To: trmdi, #plasma, hein Cc: dgin

D28985: [Kickoff] Disable tabBar's mouseArea when searching

trmdi created this revision. trmdi added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY When the root is in the "Search" state, we can safely disable it. BUG: 420282 REPOSITORY R1