D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

2020-05-15 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R126:424217083a8c: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

2020-05-15 Thread Kai Uwe Broulik
broulik updated this revision to Diff 82950. broulik added a comment. - Drop manual startup stuff - Drop C stuff REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29621?vs=82500=82950 REVISION DETAIL https://phabricator.kde.org/D29621 AFFECTED

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

2020-05-12 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > kstart.cpp:121 > +} else { > +printf("%d\n", job->pid()); > +} I know it's copied but, there's no need to randomly go to C to use std::cout > kstart.cpp:128 > +if (job->error()) { > +

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

2020-05-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The existing `--service` is kept for compatibility as it prints out the actually