This revision was automatically updated to reflect the committed changes.
Closed by commit R108:90e77a939a4d: [effects] Support xcbConnectionChanged for
support properties (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in blur.cpp:76
> I was expecting you to do what you for the present windows effect with
> calling your local lambda announceSupportProperties.
>
> IMHO it's neater than duplicating - but this is fine too.
I didn't go for
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> blur.cpp:76
> connect(effects, SIGNAL(screenGeometryChanged(QSize)), this,
> SLOT(slotScreenGeometryChanged()));
> +connect(effects,
graesslin updated this revision to Diff 19381.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Addressed David's comments
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7761?vs=19367=19381
BRANCH
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> contrast.cpp:63
> +[this] {
> +net_wm_contrast_region =
> effects->announceSupportProperty(s_contrastAtomName, this);
> +
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Several effects announce a support property atom on the root window. This
change forwards the KWin::Application's signal that the
