mart closed this revision.
mart added a comment.
dependencies are up to date now in metadata
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: bcooksley, davidedmundson, plasma-devel, ZrenBot,
bcooksley reopened this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
This code introduces a new dependency which has yet to be declared in the
kde-build-metadata repository.
As this has been several days now, i'll be reverting this commit and any
mart marked an inline comment as done.
mart added a comment.
In https://phabricator.kde.org/D7941#151979, @davidedmundson wrote:
> Is 5.39 tagged already?
should be tagged next saturday.
the two issues are adressed in master.
REPOSITORY
R858 Qt Quick Controls 2: Desktop
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:aa33639fcfd9: use Kirigami Theme for colors (authored by
mart).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7941?vs=20296=20299
davidedmundson added a comment.
Is 5.39 tagged already?
INLINE COMMENTS
> plasmadesktoptheme.cpp:48
> +this, [this]() {
> +if (m_parentItem && m_parentItem->window()) {
> +connect(m_parentItem->window(),
> ::activeChanged,
and
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
mart/kirigamiintegration
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot,
mart reopened this revision.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart,
mart updated this revision to Diff 20296.
mart added a comment.
- add the kirigami plasma desktop integration here
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7941?vs=20293=20296
BRANCH
mart/kirigamiintegration
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:1190c5e0c9f2: use Kirigami Theme for colors (authored by
mart).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7941?vs=19981=20293
mart updated this revision to Diff 19981.
mart added a comment.
- use Kirigami Theme for colors
- clean dead code
- use kirigami colors
- get rid of SystemPaletteSingleton and TextSingleton
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
mart reopened this revision.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart,
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:9e3ee983d161: clean dead code (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7941?vs=19942=19943#toc
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE
mart updated this revision to Diff 19942.
mart added a comment.
proper diff?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7941?vs=19940=19942
BRANCH
mart/kirigamiintegration
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kquickstyleitem.cpp:167
> I meant specifically the setInherit
>
> that's also exposed in QML and you have that being explicitly set there.
ouch yeah, that's actually a leftover :)
REPOSITORY
R858 Qt Quick Controls 2:
mart updated this revision to Diff 19940.
mart added a comment.
Restricted Application added a project: Kirigami.
remove dead code
update colors on the fly on qapp palette change
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kquickstyleitem.cpp:167
> I don't understand what this is doing? It looks wrong?
I meant specifically the setInherit
that's also exposed in QML and you have that being explicitly set there.
REPOSITORY
R858 Qt
mart added a comment.
In https://phabricator.kde.org/D7941#148757, @davidedmundson wrote:
> This is set to be a framework.
> We can't have a framework that imports something from workspace.
it imports kirigami, which is a framework, so it just makes it tier2
INLINE COMMENTS
>
davidedmundson added a comment.
This is set to be a framework.
We can't have a framework that imports something from workspace.
INLINE COMMENTS
> Label.qml:32
>
> -height: Math.round(Math.max(paintedHeight,
> StylePrivate.TextSingleton.height * 1.6))
> +height:
mart added reviewers: Plasma, Kirigami, hein.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
it makes possible to use kirigami's color sets
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
mart/kirigamiintegration
REVISION
20 matches
Mail list logo
