This revision was automatically updated to reflect the committed changes.
Closed by commit R108:54b36325f717: Support software QtQuickRendering in
Aurorae (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8039?vs=21699=21707
REVISION
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8039
To: davidedmundson, #plasma, graesslin
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
davidedmundson updated this revision to Diff 21699.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Avoid all GL in software mode.
Had a bit of a reshuffle to create the view first, so we can use the
graphicsAPI from that
rather than
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in aurorae.cpp:354
> Changing the rendering doesn't block making calls to any of the openGL calls
> in QtBase.
> The only changes are purely inside QtQuick
>
> So:
> creating a context still works fine
> creating an FBO
graesslin added a comment.
Ah sorry, I had my comment here for weeks, just unsubmitted :-(
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8039
To: davidedmundson, #plasma
Cc: graesslin, apol, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
davidedmundson updated this revision to Diff 20565.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Check Qt version
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8039?vs=20050=20565
BRANCH
master
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in aurorae.cpp:344
> `#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?
Yeah, makes sense, it got +2'd quicker than I expected.
> graesslin wrote in aurorae.cpp:354
> stupid question: but why is this code working? I would assume that
graesslin added inline comments.
INLINE COMMENTS
> aurorae.cpp:354
> [this] {
> if (!m_context->makeCurrent(m_offscreenSurface.data())) {
> return;
stupid question: but why is this code working? I would assume that making the
context current
apol added inline comments.
INLINE COMMENTS
> aurorae.cpp:344
>
> +//workaround for https://codereview.qt-project.org/#/c/207198/
> +m_renderControl->sync();
`#if QT_VERSION < QT_VERSION_CHECK(5,10,0)`?
REPOSITORY
R108 KWin
REVISION DETAIL
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
For software QtQuick rendering we want to create a pixmap buffer and
render our
10 matches
Mail list logo
