This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1ded47814a61: Port KAccess away from kdelibs4support
(authored by apol).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8115?vs=20782&id=20783
REVISION DETA
apol updated this revision to Diff 20782.
apol added a comment.
Fix
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8115?vs=20557&id=20782
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8115
AFFECTED FILES
kaccess/CMakeLists.txt
apol updated this revision to Diff 20557.
apol added a comment.
Remove comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8115?vs=20258&id=20557
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8115
AFFECTED FILES
kaccess/CMake
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> main.cpp:91
>
> -app.setXkbOpcode(xkb_opcode);
> -app.disableSessionManagement();
> +// app.setXkbOpcode(xkb_opcode);
> return app.exe
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kaccess.cpp:722
> we've effectively removed this connect to dialogClosed. Now closing goes to
> noClicked.
>
> Is this a problem?
I noticed. I'm not sure to be honest.
My thinking is that the user shouldn't notice the diffe
davidedmundson added a comment.
nice
INLINE COMMENTS
> kaccess.cpp:722
> -connect(dialog, &KDialog::noClicked, this, &KAccessApp::noClicked);
> -connect(dialog, &KDialog::closeClicked, this,
> &KAccessApp::dialogClosed);
> }
we've effectively removed this connect to dia
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Executed it locally, can start and stop orca
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https:/
