D8232: Add option to center shadow

rpelorosso created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds an option to center the Breeze's decoration shadow. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/

D8232: Add option to center shadow

rpelorosso added a reviewer: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8232: Add option to center shadow

mart added a reviewer: VDG. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

mart added a comment. i would love that REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

davidedmundson added a comment. Rule of thumb: If you tag VDG in a review, you need screenshots. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D8232: Add option to center shadow

rpelorosso updated this revision to Diff 20566. rpelorosso edited the summary of this revision. rpelorosso added a comment. Aligned the "Center Shadow" checkbox to the left F5381122: image.png CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D8232: Add option to center shadow

ngraham added a comment. I want this. REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8232: Add option to center shadow

rkflx added a comment. FWIW, I would love this too. IMHO this should even be the default (but is obviously something for the https://phabricator.kde.org/tag/vdg/ to decide). Reasons: - The shadow not only adds a spatial dimension to the visuals, it also is important in separating the co

D8232: Add option to center shadow

rkflx set the repository for this revision to R31 Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8232: Add option to center shadow

rkflx added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: rkflx, ngraham, davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8232: Add option to center shadow

hpereiradacosta added a comment. Hi, Thanks for the patch. Few comments (on the functionality, not yet on the code) 1/ this is a decision VDG should make (Thomas Pfeiffer ?): when I first wrote the code for breeze we discussed this possibility to have the shadow centered (as well as

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#155232, @rkflx wrote: > FWIW, I would love this too. IMHO this should even be the default (but is obviously something for the https://phabricator.kde.org/tag/vdg/ to decide). Reasons: > > - The shadow not only adds

D8232: Add option to center shadow

ngraham added a comment. I agree that this should be a change, not a new option. Personally, in addition to aesthetics, I like the change because it fixes the following visual glitches: - Having a small shadow on the left side looks like a visual bug when you tile windows to sides of th

D8232: Add option to center shadow

mvourlakos added a comment. Personally I like the feeling of the shadow falling at the bottom right. I just found it a bit too much. I think it must go a little more to the left and top but preserve the feeling that the shadow falls at bottom-right like the original designer thought it.

D8232: Add option to center shadow

rpelorosso added a comment. In https://phabricator.kde.org/D8232#155278, @hpereiradacosta wrote: > 4/ note that oxygen has centered shadows everywhere (decoration, menus and buttons). That's true, but Oxygen shadows suffer from a different issue, as they seem to blend in an odd w

D8232: Add option to center shadow

ngraham added a comment. > ! In https://phabricator.kde.org/D8232#155370, @rpelorosso wrote: > For me, the screenshot you present just feels unbalanced, and trying to focus on the window content makes me feel dizzy. +1, me too. REPOSITORY R31 Breeze REVISION DETAIL https://phabri

D8232: Add option to center shadow

mvourlakos added a comment. my previous screenshot was to show you the problem with the current implementation not to suggest new defaults... in order to demonstrate you the best in my liking I will give you two screenshots using the current breeze defaults. The first one is the defaul

D8232: Add option to center shadow

rkflx added a comment. In https://phabricator.kde.org/D8232#155402, @mvourlakos wrote: > Proposed: > F5429752: screen_shadow_proposed.png This compromise would work really well for me. REPOSITORY R31 Breeze REVISION DETAIL https://pha

D8232: Add option to center shadow

progwolff added a comment. I am on Michail's side. Having the shadow falling at the bottom right feels more natural to me. I also like the sharper edge at the left. Makes the overall look of the desktop a little cleaner. Actually, the clean look of breeze was the main reason why I fina

D8232: Add option to center shadow

ngraham added a comment. FWIW, I gave some substantive, non-aesthetic reasons to at least center the shadow up-thread at https://phabricator.kde.org/D8232#155293 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: pr

D8232: Add option to center shadow

rkflx added a comment. Let me illustrate the problem I have with the current shadows. Imagine this situation: - Not a single window on a background to just look pretty, but a multitude of windows scattered all around to do actual work. - Window switching by focus-follows-mouse, i.e. a

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#155433, @rkflx wrote: > Let me illustrate the problem I have with the current shadows. Imagine this situation: > > - Not a single window on a background to just look pretty, but a multitude of windows scattered all

D8232: Add option to center shadow

rkflx added a comment. In https://phabricator.kde.org/D8232#155435, @hpereiradacosta wrote: > Can you explain in which situation/workflow these two screenshots are the only part of the screen that you see ? This is mainly on external displays with a lot of windows open, some maxi

D8232: Add option to center shadow

ngraham added a comment. I completely agree, @rkflx. For just this reason, 10 years ago Apple changed the window shadows to be super super gigantic: https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/ F5429828: leopard-window.png It was a

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#155436, @ngraham wrote: > I completely agree, @rkflx. For just this reason, 10 years ago Apple changed the window shadows to be super super gigantic: https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/ A huge s

D8232: Add option to center shadow

abetts added a comment. That's a cool idea. I would just try to make it smoother. The proposals still look pretty rough. I don't know programming, but can you tell me the current parameters to create the shadow with this patch? Blur, spread, color? REPOSITORY R31 Breeze REVISION DETAIL

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#155450, @abetts wrote: > That's a cool idea. I would just try to make it smoother. The proposals still look pretty rough. I don't know programming, but can you tell me the current parameters to create the shadow with this p

D8232: Add option to center shadow

rpelorosso added a comment. In https://phabricator.kde.org/D8232#155436, @ngraham wrote: > I completely agree, @rkflx. For just this reason, 10 years ago Apple changed the window shadows to be super super gigantic: https://arstechnica.com/gadgets/2007/10/mac-os-x-10-5/3/ > > It was a

D8232: Add option to center shadow

alake added a comment. +1 for the centered shadow proposal as an option. I'd hesitate for this to be the default since to do it well, in my opinion, it'd take a complete lighting (re)design effort on Breeze to help ensure visually consistency. REPOSITORY R31 Breeze REVISION DETAIL

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#155473, @alake wrote: > +1 for the centered shadow proposal as an option. > > I'd hesitate for this to be the default since to do it well, in my opinion, it'd take a complete lighting (re)design effort on Breeze to

D8232: Add option to center shadow

alex-l added a comment. Absolutely +1, I was waiting for this option since Plasma 5 was launched. I suggest to make it default, I can't really get why the shadow should be on the right. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vd

D8232: Add option to center shadow

ngraham added a comment. Check out the large centered shadows in ElementaryOS. They're goregeous: F5430019: photos.jpg REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: al

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#155503, @ngraham wrote: > Check out the large centered shadows in ElementaryOS. They're goregeous.. The thing is that they arent totally centered. They are centered at x but they have a small y offset, it gives the f

D8232: Add option to center shadow

alake added a comment. Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overlapping windows could be improved. The proposed compromise solution actually looks decent too and it keeps the lighting reasonably consistent. The VDG

D8232: Add option to center shadow

rpelorosso added a comment. I didn't want to stop mentioning that, unless I'm missing something, it looks like breeze *window* shadows are not taking into consideration the Screen Scaling settings, so basically they don't scale if that value is incremented, making the shadows look small in 4

D8232: Add option to center shadow

rpelorosso added a comment. In https://phabricator.kde.org/D8232#155519, @alake wrote: > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overlapping windows could be improved. The proposed compromise solution actually loo

D8232: Add option to center shadow

rpelorosso added a comment. In https://phabricator.kde.org/D8232#155503, @ngraham wrote: > Check out the large centered shadows in ElementaryOS. They're goregeous: > > F5430019: photos.jpg They look amazing! REPOSITORY R31 Breeze REVIS

D8232: Add option to center shadow

januz added a comment. Personally, I'm in the centered shadows camp. I have windows set up to have no borders and they always seem to visually blend into each other in a similar way to what @rkflx describes. I don't understand the reasoning behind light coming from the top-left, it seems

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#155519, @alake wrote: > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overlapping windows could be improved. The proposed compromise solution actually loo

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#156934, @mvourlakos wrote: > In https://phabricator.kde.org/D8232#155519, @alake wrote: > > > Ok, I agree now that there shouldn't be an option. I think it is fair to say that the contrast on the left side of overla

D8232: Add option to center shadow

mvourlakos added a comment. In https://phabricator.kde.org/D8232#156965, @hpereiradacosta wrote: > I think the consensus (from Telegram discussions) was that I would submit two review requests to superseed this one: > > - one where the whole of breeze is now centered (shadows for wind

D8232: Add option to center shadow

rkflx added a comment. Thanks for summarizing the discussion and doing the prototyping, that's appreciated. Just noticed a point which has not been mentioned yet: There are also the shadows of the Plasma widgets to consider. Ironically, those are already centered

D8232: Add option to center shadow

ngraham added a comment. More evidence for the superiority of the centered approach. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davided

D8232: Add option to center shadow

rkflx added a comment. In https://phabricator.kde.org/D8232#156982, @ngraham wrote: > More evidence for the superiority of the centered approach. :) Let's not jump to conclusions here too fast :) We should evaluate both approaches in how they solve the problem at hand (if that's d

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#156982, @ngraham wrote: > More evidence for the superiority of the centered approach. :) Sorry to say, but this is a completely gratuitous, non constructive and demotivating comment nathaniel. Hugo REPOSIT

D8232: Add option to center shadow

ngraham added a comment. Sorry guys, didn't mean to offend. Though I currently favor the centered approach, I'm absolutely willing to be convinced out of it, if VDG can come up with a non-centered shadow that looks good and resolves the issues with insufficient depth and contrast on windows'

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#156981, @rkflx wrote: > Thanks for summarizing the discussion and doing the prototyping, that's appreciated. > > Just noticed a point which has not been mentioned yet: There are also the shadows of the Plasma widge

D8232: Add option to center shadow

rkflx added a subscriber: sebas. rkflx added a comment. Let's put is this way: Ideally the shadows of the Plasma widgets would follow whatever the window decoration is doing. Especially the Plasma popup widgets are very similar to a normal widget menu popup, from the user's point of view – s

D8232: Add option to center shadow

ngraham added a comment. Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phabricator.kde.org/D9549 REPOSITORY R31 Breeze REVISION DETAIL h

D8232: Add option to center shadow

abetts added a comment. In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizontally center window and menu shadows, and make them a bit larger: https://phab

D8232: Add option to center shadow

hpereiradacosta added a comment. In https://phabricator.kde.org/D8232#184470, @abetts wrote: > In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > > > Per recent https://phabricator.kde.org/tag/vdg/ discussions, I've put together a patch that changes the defaults to horizon

D8232: Add option to center shadow

abetts added a comment. In https://phabricator.kde.org/D8232#184486, @hpereiradacosta wrote: > In https://phabricator.kde.org/D8232#184470, @abetts wrote: > > > In https://phabricator.kde.org/D8232#183783, @ngraham wrote: > > > > > Per recent https://phabricator.kde.org/tag/vdg/ di

D8232: Add option to center shadow

ngraham added a comment. Does this revision need to stay open? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta Cc: emateli, sebas, januz, alex-l, alake, abetts, progwolff, mvourlakos, rkflx, ngraham, davidedmundson,

D8232: Add option to center shadow

rpelorosso abandoned this revision. rpelorosso added a comment. Closing this revision in favor of https://phabricator.kde.org/D9549 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze, #vdg, hpereiradacosta