xuetianweng added a comment.
In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
> Sorry for the long delay on a review.
>
> Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec352304d357: Add xf86-input-libinput support for X11
mouse backend. (authored by xuetianweng).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8798?vs=22774=23472#toc
REPOSITORY
R119 Plasma
xuetianweng added a comment.
In https://phabricator.kde.org/D8798#175698, @subdiff wrote:
> Sorry for the long delay on a review.
>
> Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is
subdiff added a comment.
Sorry for the long delay on a review.
Can you give a short overview on how the switching works between Xlib and
libinput backend on X? So what's the runtime detection if libinput is available
or not? Somebody above said mouse kcm is not available without
jriddell added a comment.
+1 to Pointer Accelaration
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
ngraham added a comment.
Or maybe just, "Pointer Acceleration:"?
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.
I'm sorry I indeed didn't have that package installed because I'm using HWE
packages, I've installed it now and xinput shows my touchpad as using libinput.
kcmshell5 mouse now
ngraham added a comment.
On Ubuntu:
sudo apt install xserver-xorg-input-libinput
sudo apt remove xserver-xorg-input-mouse xserver-xorg-input-evdev
xserver-xorg-input-[anything else]
[reboot]
Package names may be slightly different on non-Ubuntu distros.
REPOSITORY
R119
jriddell added a comment.
This is my output from xinput which suggests it's using evdev, how do I get
it to use libinput?
>xinput list-props 14
Device 'ImExPS/2 Generic Explorer Mouse':
Device Enabled (140): 1
Coordinate Transformation Matrix (142):
xuetianweng added a comment.
@jriddell ping?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
xuetianweng marked 3 inline comments as done.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma, jriddell
Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas,
xuetianweng added a comment.
In https://phabricator.kde.org/D8798#170892, @jriddell wrote:
> This disables the input kcm if libinput x11 plugin is not found. I expect
this is fine, it is for ubuntu distros at least, but it might be worth asking
distros if it causes them a problem.
xuetianweng updated this revision to Diff 22774.
xuetianweng added a comment.
revert the accidentally changed currentIndex in ui file when save in designer.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8798?vs=22543=22774
BRANCH
mouse
REVISION
xuetianweng added a comment.
Whether it shows up reallys depends on your system. Especially when there's
multiple mouse driver available and you may using evdev.
For example, here's one output on my system, when you see something like
this, you'll know it's using libinput's xf86 driver.
jriddell added a comment.
Using the patch the acceleration profile box doesn't show. I have a KDE
Slimbook with and xinput reports this:
⎡ Virtual core pointer id=2[master pointer (3)]
⎜ ↳ Virtual core XTEST pointerid=4[slave
jriddell added a comment.
This disables the input kcm if libinput x11 plugin is not found. I expect
this is fine, it is for ubuntu distros at least, but it might be worth asking
distros if it causes them a problem.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
ngraham added a comment.
In https://phabricator.kde.org/D8798#170879, @jriddell wrote:
> on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this
isn't a surprise as your patch doesn't touch the touchpad kcm. Should it?
That would be probably be handled by a
jriddell added a comment.
on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this
isn't a surprise as your patch doesn't touch the touchpad kcm. Should it?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham,
jriddell requested changes to this revision.
jriddell added a comment.
This revision now requires changes to proceed.
kcms/input/kcmmouse.ui
Don't change as that makes the default tab
seem wrong
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To:
xuetianweng added a comment.
@apol got a chance to test it?
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
xuetianweng added a comment.
In https://phabricator.kde.org/D8798#169156, @apol wrote:
> In https://phabricator.kde.org/D8798#169155, @ngraham wrote:
>
> > $ kcmshell5 touchpad
> > kcm_touchpad: Using X11 backend
> >
> >
> > The file on disk is at
apol added a comment.
In https://phabricator.kde.org/D8798#169155, @ngraham wrote:
> $ kcmshell5 touchpad
> kcm_touchpad: Using X11 backend
>
>
> The file on disk is at
`/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so` (on KDE Neon and other
Ubuntu-based distros)
ngraham added a comment.
$ kcmshell5 touchpad
kcm_touchpad: Using X11 backend
The file on disk is at
`/usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so` (on KDE Neon and other
Ubuntu-based distros)
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
apol added a comment.
I wanted to test it, but I'm not sure how to.
`kcmshell5 input` doesn't give me anything, am I looking at the right place?
REPOSITORY
R119 Plasma Desktop
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: apol,
ngraham accepted this revision.
ngraham added a subscriber: rkflx.
ngraham added a comment.
This revision is now accepted and ready to land.
Thanks, looks good. Might wanna wait for at least one more review before
committing.
Ready for the next patch!
REPOSITORY
R119 Plasma Desktop
xuetianweng updated this revision to Diff 22543.
xuetianweng added a comment.
Fix based on comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8798?vs=22284=22543
BRANCH
mouse
REVISION DETAIL
https://phabricator.kde.org/D8798
AFFECTED
ngraham added a comment.
@xuetianweng any update?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham added a comment.
@ xuetianweng any update?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> x11mousebackend.cpp:186
> +m_supportedAccelerationProfiles.clear();
> +bool adaptiveAvaiable = false;
> +bool flatAvailable = false;
xuetianweng added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8798
To: xuetianweng, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
xuetianweng created this revision.
xuetianweng added a reviewer: ngraham.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Added libinput support to X11 backend. It also adds an new option to backend
which is only available to libinput device currently.
TEST PLAN
Manually
31 matches
Mail list logo
