D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-05 Thread Nathaniel Graham
ngraham updated this revision to Diff 24771. ngraham added a comment. Use combobox to determine shadow size (massive amount of help from Hugo) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9627?vs=24674&id=24771 BRANCH master REVISION DETAIL https://ph

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-04 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D9627#185604, @rkflx wrote: > One more thing: Is the 100px max working for you? Mine is still capped at 64px Figured that one out: The problem is clearly with https://phabricator.kde.org/D9549, because it only changed `breeze

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-04 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#185783, @ngraham wrote: > I'm working on the combobox patch, but in my KDE Neon machine, I'm having trouble getting my changes applied when I open the Breeze settings in the Window Decoration KCM. I'm building to /usr

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Nathaniel Graham
ngraham added a comment. I'm working on the combobox patch, but in my KDE Neon machine, I'm having trouble getting my changes applied when I open the Breeze settings in the Window Decoration KCM. I'm building to /usr and can verify that `/usr/lib/x86_64-linux-gnu/qt5/plugins/styles/breeze.so

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Nathaniel Graham
ngraham added a comment. Excellent ideas, everyone. I'll see if I can work up something with a combobox. Also with that approach, I can fine-tune the menu shadows for each option to make sure they look good. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Henrik Fehlauer
rkflx added a comment. @hpereiradacosta +1 Essentially this: https://phabricator.kde.org/D9549#184975 (but a "No" option could be added). REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc:

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#185615, @ngraham wrote: > Those are valid concerns, and I will think on them! I always admire your thoroughness, @rkflx. > > That said, for upgrades, users who did not manually change the shadow size should get the

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Nathaniel Graham
ngraham added a comment. Those are valid concerns, and I will think on them! I always admire your thoroughness, @rkflx. That said, for upgrades, users who did not manually change the shadow size should get the new setting since they will not have a config file written out to override th

D9627: Reduce menu shadows to 25% of the window shadow size

2018-01-03 Thread Nathaniel Graham
ngraham retitled this revision from "Reduce menu shadows to half the size of the window shadows" to "Reduce menu shadows to 25% of the window shadow size". REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, a